Link List Problem

[bird1234]

This Code is Working Fine but i want the output in right order not in reverse order i am so confused (new to data structure)

#include<iostream>
using namespace std;

class Node
{
private:
	Node* start;
	Node* next;
	Node* temp;
	int data;
public:
	void insert(int);
	void display();
	Node();
};

Node::Node()
{
	start = NULL;
}

void Node::insert(int item)
{
	temp = new Node;
	temp->data = item;
	temp->next = start;
	start = temp;
}

void Node::display()
{
	Node* show = temp;
	while (show != NULL)
	{
		cout << show->data << endl;
		show = show->next;
	}
}


int main()
{
	Node n;
	n.insert(1);
	n.insert(2);
	n.insert(3);
	n.insert(4);
	n.insert(5);

	n.display();
	system("pause");

}

Expected Output
1
2
3
4
5

Getting Output
5
4
3
2
1

[dhayden]

Normally a list uses two classes: one for the list itself and one for a node within the list. You're using one class to represent both, which is a little unusual.

temp should be a local variable declared whereever you need it, not a member of the Node class.

Node's constructor should set the next pointer to NULL. Otherwise the last item's next pointer will point off to lala land.

That said, your items are printing in reverse order because you insert the items at the beginning of the list, so they occur in the list in the reverse order from which they were inserted.

[gunnerfunner]

- use the ctor's to initialize objects when feasible;
- const qualify variables and member methods likewise;
- the linked list also needs a destructor

#include<iostream>
using namespace std;

struct Node
{
	Node* next;
	int data;
	Node(const int d) : data(d), next(nullptr) {}
	~Node() {std::cout << "Goodbye " << data << '\n';}
};
struct LList
{
    Node* start = nullptr;
    void insert (const int& item);
    void display()const;
    ~LList()
	{
	    Node* temp = start;
	    while (temp)
        {
            Node* next = temp -> next;
            delete temp;
            temp = next;
        }
        start = nullptr;
    }
};
void LList::insert(const int& item)
{
	Node* temp = new Node(item);
	if(!start)
    {
        start = temp;
    }
    else
    {
        Node* last = start;
        while (last -> next)
        {
            last = last -> next;
        }
        last -> next = temp;
    }
}
void LList::display()const
{
	Node* show = start;
	while (show)
	{
		std:: cout << show ->data << '\n';
		show = show->next;
	}
}
int main()
{
	LList n;
	n.insert(1);
	n.insert(2);
	n.insert(3);
	n.insert(4);
	n.insert(5);

	n.display();
}

Output

1
2
3
4
5
Goodbye 1
Goodbye 2
Goodbye 3
Goodbye 4
Goodbye 5