having a hard time with logic

[flyraf821]

So i've been struggling with this program and everytime I figure something out I get stuck on something new.The program is supposed to count the number of words, consonants, digits, and sentences in a file. I figured out the digits and consonants with some help but I'm struggling with the words and sentences.

#include <iostream>
#include <string>
#include <cctype>
#include <fstream>

using namespace std;

bool at_endl(ifstream&);
void skip_blanks(ifstream&);
void reformat(string&);
void getfilename(string,string&);
void count_digit(string,int&);
void count_consonants(string, int&);


int main()
{
    string word, filename;
    char ch;
    int digits=0, numcons=0, words=0;
    ifstream input;
    getfilename("input",filename);
    input.open(filename.c_str());
    input >> word;
    while (!input.eof())
        {
            reformat(word);
            count_digit(word,digits);
            count_consonants(word,numcons);
            cout << word;
            skip_blanks(input);
            if (at_endl(input))
                {
                    cout << endl;
                }
            else
                cout << " ";
            input >> word;
        }
            cout << digits << endl;
            cout << numcons;
            return 0;
}

void getfilename(string filetype, string& filename)
{
    cout << "Enter the name of " << filetype << " file\n";
    cin >> filename;
}

bool at_endl(ifstream& input)
{
    return (input.peek() == '\n');
}

void skip_blanks(ifstream& input)
{
    char ch;
    while (input.peek() == ' ')
        input.get(ch);
}

void reformat(string& word)
{
    int wlength;
    wlength = word.length();
    word[0] = toupper(word[0]);
    for (int i=1; i<wlength; i++)
        word[i] = tolower(word[i]);
}

void count_digit(string word, int& digits)
{
    int wlength;
    wlength = word.length();
    for (int i=1; i<wlength; i++)
    {
        if (isdigit(word[i]))
            digits = digits + 1;
    }
}

void count_consonants(string word, int& numcons)
{
    int wlength;
    wlength = word.length();
    for (int i=0; i<wlength; i++)
    {
        word[i] = toupper(word[i]);
        if (word[i] >= 'A' && word[i] <= 'Z')
            {
                if (word[i] != 'A' && word[i] != 'E' && word[i] != 'I' && word[i] != 'O' && word[i] != 'U')
                    numcons = numcons + 1;
            }
    }
}

i wrote a function to count words but its not working:

void count_words(ifstream& input, int& words)
{
    string tempstring;
    int wlength;
    getline(input,tempstring);
    wlength = tempstring.length();
    for(int i=0; i<wlength; i++)
        if (tempstring[i] == ' ')
            words++;
}

Any help would be awsome!

[Computergeek01]

An over simple and not quite right way to count sentances is simply to count the number of times '.' appears in the file. To do it right you're looking at A LOT of work.

For your word counting function getline(...) is your problem, this looks for a return carridge deliminator. Replace getline(...) with something like input >> tempstring. It looks like the count_words(...) function is trying to count the words in the sentence, is this the case? If it is we have to go about it in a differant way.

Also shouldn't most of these functions be returning int's?

[flyraf821]

no i have to count the number of words in the entire file, and in my case a word is defined as a series of any non-white space characters.

yes most of these return ints, does that mean i should have written them as value returning functions instead?

[Jahmbo]

To count sentences you would have to count the following as valid delimiters,

? ! .

To count words it would probably be easiest (from my limited experience) to use a vector as in the following example from Thinking In C++.

int main() {
  vector<string> words;
  ifstream in("GetWords.cpp");
  string word;
  while(in >> word)
    words.push_back(word); 
  for(int i = 0; i < words.size(); i++)
    cout << words[i] << endl;
}

[flyraf821]

thanks Jahmbo, unfortunately i cant use vectors in this exercise :-(