Vector's problem

[Alex009988]

Hello! I have someting strange in my code.
There is my program.

  #include "stdafx.h"
#include <iostream>
#include <string>
#include <sstream>
#include <algorithm>
#include <numeric>
#include <vector>
#include <cstdlib> 
using namespace std;
template<typename T>
vector<T> getSeparatedValuesFromUser(char separator = ',')
{
stringstream ss;
string str;
getline(cin, str);
replace(str.begin(), str.end(), separator, ' ');
ss << str;
T value{ 0 };
vector<T> values;
while (ss >> value) { values.push_back(value); }
return values;
}
int main()
{

double y;
cout << "Imput something\n";
cin >> y;
auto t = getSeparatedValuesFromUser<double>();
cout<< t[0];
system("pause\n");
return 0;
}

And it dosent work.
When I swap the lines it starts to work.

int main()
{
double y;
cout << "Imput something\n";
auto t = getSeparatedValuesFromUser<double>();
cin >> y;
cout<< t[0];
system("pause\n");
return 0;
}

So what is the problem? Thanks in advance.

[helios]

What's the point of cin >> y;? You don't use the value of y for anything.

[Alex009988]

There is a part of my program. When I get things together where "auto t" is below some "cin" 's. I have the same problem.

[lastchance]

cin >> y >> ws;

Mixing cin >> and getline() is fraught with difficulty.
cin >> will leave linefeed '\n' in the stream ... to be picked up by a following getline(), resulting (probably) in an empty line.
getline() extracts '\n' from the stream.

ws - see http://www.cplusplus.com/reference/istream/ws/
may be used to remove any succeeding whitespace - including the linefeed - from the stream.

[Alex009988]

Thank you for your reply.

int main()
{

	double y,x;
	cout << "Input something\n";
	cin >> y>>ws;
	cout << "Input X\n";
	cin >> x>>ws;
	auto t = getSeparatedValuesFromUser<double>();
	cout << t[0];
	system("pause\n");
	return 0;
}

It is closer to my code. And in this way, it still dpsen't work((
EDIT 2

	double y,x;
	cout << "Input something\n";
	cin >> y;
	cout << "Input X\n";
	cin >> x>>ws;
	cout << "Input t\n";
	auto t = getSeparatedValuesFromUser<double>();
	cout << t[0];
	system("pause\n");
	return 0;

With this I get this output:

Input something
5
Input X
6
7 8 9
Input t
7

Why "imput t" follows after the "cout << "Imput t\n";"?

[lastchance]

#include <iostream>
#include <string>
#include <sstream>
#include <algorithm>
#include <vector>
using namespace std;
template<typename T>
vector<T> getSeparatedValuesFromUser(char separator = ',')
{
stringstream ss;
string str;
getline(cin, str);
replace(str.begin(), str.end(), separator, ' ');
ss << str;
T value{ 0 };
vector<T> values;
while (ss >> value) { values.push_back(value); }
return values;
}

int main()
{
	double y,x;
	cout << "Imput[sic] something\n";
	cin >> y;
	cout << "Imput X\n";
	cin >> x >> ws;            // Only put ws here, because of getline to follow.
	auto t = getSeparatedValuesFromUser<double>();
	cout << t[0];
}

Imput[sic] something
0
Imput X
0
3,4,5
3 

Alternatively:

int main()
{
    string dummy;
	double y,x;
	cout << "Imput[sic] something\n";
	cin >> y;
	cout << "Imput X\n";
	cin >> x;   getline( cin, dummy );
	auto t = getSeparatedValuesFromUser<double>();
	cout << t[0];
}

[Alex009988]

Thank you. Now I have another problem.

int main()
{
	string dummy;
	double y,a;
	cout << "Input[sic] something\n";
	cin >> y;           // Only put ws here, because of getline to follow.
	getline(cin, dummy);
	cout << "Input Array\n";
	auto t = getSeparatedValuesFromUser<double>();
	a= accumulate(t.begin(), t.end(), 0);
	cout << "Output:   " << a;
	system("pause\n");
	return 0;
}

and I get

Input[sic] something
5
Input Array
0.5 0.5
Output:   0

I have something wrong with accumulate function. It acts like int, but it should be double.

[Peter87]

accumulate returns a value of the same type as the third argument.

Try like this instead:

a = accumulate(t.begin(), t.end(), 0.0);

[Alex009988]

Thank you. I want to loop my program and use this code

setlocale(LC_CTYPE, "rus");
	char yn;
	do
	{
...............................
cout<< "Type Y or Д" << flush;
	} while (cin >> yn && (yn == 'Y' || yn == 'y' || yn == 'Д' || yn == 'д'));

The problem is that the loop works with letter Y, but dosent work with cyrillic letter Д in spite of having setlocate. When I press Д it just closes the program.