using a recursive function with a linked list

[Kukamunga]

i need help creating the print() function. It is supposed to print all elements of the list from first to last. since i had to create this program in separate files it may appear messy and i am very sorry about that. the function is under the linked_list.cpp section. thank you to anyone who can offer assistance.

  //node.h

#ifndef NODE_H
#define NODE_H

//class node definition
class Employee
{
	
	private:
		//private variables
		int id;
		float salary;
		short int dependents;

		
	public:
		//default constructor
		Employee();
		
		//constructor with parameters
		Employee(int, float, short int);
		
		//get and set functions
		
		int getId();
		void setId(int);
		
		float getSalary();
		void setSalary(float);
		
		short int getDep();
		void setDep(short int);
		

		
};

class Node
{
	private:
		Employee* emp;
		Node* next;
		
	public:
		Node();
		
		Node(Employee* emp);
		
		
		Employee* getEmp();
		void setEmp(Employee*);
		
		Node* getNext();
		void setNext(Node*);
};
#endif

//node.cpp

#include "node.h"

//constructor definition
Employee::Employee()
{
	id = 0;
	salary = 0.0;
	dependents = 0;
}

//constructor with values definition
Employee::Employee(int id, float salary, short int dependent)
{
	this->id = id;
	this->salary = salary;
	this->dependents = dependents;
}

int Employee::getId()
{
	return id;
}

void Employee::setId(int id)
{
	this->id = id;
}

float Employee::getSalary()
{
	return salary;
}

void Employee::setSalary(float salary)
{
	this->salary = salary;
}

short int Employee::getDep()
{
	return dependents;
}

void Employee::setDep(short int)
{
	this->dependents = dependents;
}

//node definitions

Node::Node()
{
	emp = 0;
	next = 0;
}

Node::Node(Employee* emp)
{
	this->emp = emp;
	next = 0;
}

Employee* Node::getEmp()
{
	return emp;
}

void Node::setEmp(Employee* emp)
{
	this->emp = emp;
}

Node* Node::getNext()
{
	return next;
}

void Node::setNext(Node* next)
{
	this->next = next;
}

//Linked_List.h

#ifndef LINKED_LIST_H
#define LINKED_LIST_H

#include "node.h"


class LinkedList
{
	private:
		Node* head;
		
		void display(Node*);
		
	public:
		LinkedList();
		
		LinkedList(Node*);
		
		Node* getHead();
		void setHead(Node*);
		
		
		void insert(int, float, short int);
		
		void remove();
		
		void display();
		
		void print();
		
		void clear();
};

#endif

//linked_list.cpp

#include <iostream>
#include "linked_list.h"

using namespace std;


//linkedlist

LinkedList::LinkedList()
{
	head = 0;
}

LinkedList::LinkedList(Node* head)
{
	this->head = head;
}

void LinkedList::display(Node* head)
{
	if (head == 0)
		return;
	else
	cout << "ID: " << head->getEmp()->getId() << "\t Salary: " << head->getEmp()->getSalary() <<
  		  "\tDependents: \n" << head->getEmp()->getDep();
  	display(head->getNext());
}

void LinkedList::display()
{
	if (head == 0)
		cout <<"List is empty.";
	else
		display(head);
}

void LinkedList::insert(int id, float salary, short int dependents)
{
	Employee *newEmp = new Employee(id, salary, dependents);
	Node *newNode =  new Node(newEmp);
	
	newNode->setNext(head);
	head = newNode;
}


void LinkedList::remove()
{
	if (head == 0)
	{
		cout << "List is empty.\n";
		return;
	}
	
	Node* it = head;
	Node* prev = 0;
	
	while(it->getNext() != 0)
	{
		prev = it;
		it = it->getNext();
	}
	
	delete it;
	it = 0;
	
	if (prev != 0)
		prev->setNext(0);
	else
		head = 0;
}

//******************************************************
void LinkedList::print()
{
	
}
//******************************************************

void LinkedList::clear()
{
	while(head != 0)
	{
		Node* prev = head;
		head = head->getNext();
		delete prev;
	}
}

//main.cpp

#include <iostream>
#include "linked_list.h"

using namespace std;

int main()
{
	
	LinkedList *list = new LinkedList();
	
	while(true)
	{
	   cout << "1. Insert Employee\n";
       cout << "2. Remove Last Employee\n";
       cout << "3. Display List\n";
       cout << "4. Clear List\n";
       cout << "5. Print List (First to Last)\n";
       cout << "6. Exit\n";

       int input;
       cout << "\nEnter choice (1-4): ";
       cin >> input;
       
       
       switch(input)
	   {
	   	
	   	case 1:
	   		int id;
	   		float salary;
	   		short int dependents;
	   		cout << "Enter ID Number, Salary and number of Dependents: ";
	   		cin >> id >> salary >> dependents;
	   		
	   		list->insert(id, salary, dependents);
	   		cout << "Added to the front of the list.\n";
	   		break;
	   		
	   	case 2:
               list->remove();
               cout << "Last employee removed!" << endl;
               break;
               
        case 3:
               cout << "Displaying List: \n";
               list->display();
               break;
               
        case 4:
               list->clear();
               cout << "List cleared!" << endl;
               break;
               
        case 5:
               cout<<"List in order: \n";
               list->print();
               break; 
               
        case 6:
               cout << "Thank you!" << endl;
               return 0;
               
        default:
               cout << "Please enter correct option!\n";	
	   	
       	
	   }
       
	}
		
	
	
}

[salem c]

Where is your main to drive that code?

What results do you see?
- nothing printed
- something printed, but incorrect in some way
- the recursion blows up.

Using recursion to traverse a LL is bad code anyway.
You just replicate the list on the stack in doing so, which if your list is very long risks blowing the stack.

[Kukamunga]

whoops i totally forgot to include main of course. the program seems to work fine when i run it but i am just struggling when it comes to recursive functions especially when working with already confusing linked lists. as for recursion being bad code for a LL, i'm just following the instructions from my professor.