Dynamic Array Class

Hi! I'm making a dynamic array class for an exercise but I'm having some trouble with my code. I'm getting something like 'there might be a corruption in the heap' or something. Here's the implementation of the class:

#include "ArrayClass.h"


ArrayClass::ArrayClass()
{
	mSize=0;
	mData=new float[0];
}


ArrayClass::~ArrayClass()
{
	delete[] mData;
	mData=0;
	
}

ArrayClass::ArrayClass(int size)
{
	mSize=size;
	mData=new float[mSize];
}

float& ArrayClass::operator[](int i)
{
	return mData[i];
}


int ArrayClass::size()
{
	
	return mSize;
}


ArrayClass::ArrayClass(const ArrayClass& rhs)
{
	int len=rhs.mSize;
	mData=new float[len];

	for(int i=0;i<rhs.mSize;++i)
	{
		mData[i]=rhs.mData[i];
	}

}


ArrayClass& ArrayClass::operator=(const ArrayClass& rhs)
{
	if(this==&rhs)
	{
		return *this;
	}


	delete[] mData;

	for(int i=0;i<rhs.mSize+1;++i)
	{
		mData[i]=rhs.mData[i];
	}

	return *this;
}


void ArrayClass::resize(int newSize)
{
	
	float* newArray=new float[newSize+1];

	if(newSize>=mSize)
	{
		for(int i=0;i<mSize;++i)
		{
			newArray[i]=mData[i];
		}
	}

	else if(newSize<mSize)
	{
		for(int i=0;i<newSize;++i)
		{
			newArray[i]=mData[i];
		}
	}

	
	mData=newArray;
	mSize=newSize;

	

}

What's wrong with it? Thanks a lot!

Lowest0ne (1536)

Don't make an array of size zero or confuse NULL with zero.

if (mSize <= 0)
  mData = NULL;
else
 mData = new float[mSize];

delete [] mData;
mData = NULL;

In your = operator, you delete mData and then start using it as if it wasn't deleted, this could be where your warning is coming from.

Last edited on

caladan21ph (7)

Thanks!

One question though, if I don't delete mData, then how do I free the memory previously stored in mData(if there was any).

Topic archived. No new replies allowed.

C++

Forum

Dynamic Array Class