Code is not working

[LN7oGNh0]

This code is supposed to find the remainder of a very large number, then show the number that was divided by the very large number. (only if the remainder is equal to 0)

Here is the code:

#include < iostream>

using namespace std;

//Foward Decalration of function that will find the remainder of two values
long long int findRemainder(long long int x, long long int y)
{
	return x % y;
}

int main()
{
	long long int longNumber = 600851475143;
	long long int y;
	int result = findRemainder(longNumber, y);
	
	for(y = 2; result != 0; y++); 
	{
		findRemainder(longNumber, y);
	}

	cout << y;

cin.get();	
return 0;
}

I suspect that it might have to do with the integer 'y'. (I think I initialized it to 2, then initialized it again to 2 in the for loop. Warnings come up, but they go away as soon as the console window opens. Can anyone fix this?

Thanks!


EDIT: I just noticed that 'int result' is not a long long integer, so I have changed that.

[chucthanh]

My opinions:

Line 15: y is used without initiation. That statement is redundant actually.

Line 19: inside the loop, result is not updated. It should be result=...

Reading the whole program, it is like you want to find the first number completely dividing longNumber.

[vlad from moscow]

Variable y was not initialized. So this code has no any sense

	long long int y; // What is the value of y???
	int result = findRemainder(longNumber, y);

Also it is no clear what this statement does

for(y = 2; result != 0; y++);

Take into account the semicolon after the statement.

[LN7oGNh0]

Ya, I addressed, the variable y not being initialized in the EDIT.

@chucthanh: Yes. Thats what i want.

[chucthanh]

Fixing line 19 as I said and line 17 as vlad said should work for you, I guess.