"Expected expression" before return

[Prodevus]

So after putting the nHigh/nLow example (5.9) in Xcode (like I do with all examples), it gave me a warning - expected expression - whilst pointing to return.

Here's the code:

#include <iostream>
#include <cstdlib> // Rand and srand
using namespace std;

int main()
{
    // Random number between nHigh and nLow
    unsigned int GetRandomNumber(int nLow, int nHigh)
    {
        return (rand() % (nHigh - nLow + 1)) + nLow; // Here's "return"
    };
    
    cout << GetRandomNumber(1, 6);
}

What do I have to put in front of return?

[TheGrayWolf]

Define the function outside of main()

 
#include <iostream>
#include <cstdlib> // Rand and srand
using namespace std;


// Random number between nHigh and nLow
unsigned int GetRandomNumber(int nLow, int nHigh)
{
    return (rand() % (nHigh - nLow + 1)) + nLow; // Here's "return"
};


int main()
{
    ... 
}

[MrHutch]

Move the whole function outside of main. Either above it or below it with a prototype above it.

[Prodevus]

Ah, works fine now! This is my current code:

#include <iostream>
#include <cstdlib> // Rand and srand
using namespace std;

// Random number between nHigh and nLow
unsigned int GetRandomNumber(int nLow, int nHigh)
{
    return (rand() % (nHigh - nLow + 1)) + nLow;
};

int main()
{
    cout << GetRandomNumber(1, 6);
}

However, I still have a problem: every time I compile it, it gives the same number. 1 and 6 gives 2 every time, 1 and 20 gives 8 every time, etcetera. Is this intentional?

[MrHutch]

You need to seed the PRNG first.

#include <ctime>

// Then, in main...
srand( time( NULL ) );

[Lynx876]

@iHutch, Why ctime, and not time.h?

@Prodevus, like iHutch said. But you only ever need to seed it once. i.e. Don't use srand( time( NULL ) ); in a loop. Just add it to the start of main() etc.

[MrHutch]

They're the same thing. Including ctime is the standard C++ convention.

The same reason you include iostream and not iostream.h.

[Lynx876]

Oh, I never knew that! Thanks! I've always included time.h... lol (: