C++

Forum

 
Help with Random Number Selector.

KeegM480 (14)
Hello, I need to get player two to become like an AI and randomly pick the number. I have been having difficulty with this, please help me!!

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
 
 // Tic Tac Toe, by Keegan Mathur

// Include the libraries
#include <iostream>
#include <string>

//Use the standard namespace
using namespace std;

// Declare global variables
char Board[9];

// Declare functions
void showBoard ( );
bool moveIsValid (int m);
int whoWon ( ); //Returns 0 if no one has won, 1 if player 1 has won, and 2 if player 2 has won


void main ( )
{
   // Declare local variables
   string Player_1_Name;
   string Player_2_Name;
   int Whose_Turn = 1; // 1 means it's player 1's turn, 2 means it's player 2's turn
   int Move; // Stores where the player wants to move
   int Total_Moves = 0;

   //Assign values to the playing board
   Board[0] = '0';
   Board[1] = '1';
   Board[2] = '2';
   Board[3] = '3';
   Board[4] = '4';
   Board[5] = '5';
   Board[6] = '6';
   Board[7] = '7';
   Board[8] = '8';

   // Get player names
   cout << "Player 1: Please enter your name." << endl;
   cin >> Player_1_Name;
   cout << "Player 2: Please enter your name." << endl;
   cin >> Player_2_Name;

   while (whoWon ( ) == 0 && Total_Moves < 9)
   {
      // Do this until the player chooses a valid move
      do
      {
         // Show the board
         showBoard ( );

         // Tell which player to move
         if (Whose_Turn == 1)
         {
            cout << Player_1_Name << ": It's your turn." << endl;
         }
         else
         {
            cout << Player_2_Name << ": It's your turn." << endl;
         }
         // Get the move
         cout << "Enter the number of the spot where you'd like to move." << endl;
         cin >> Move;
      } while (moveIsValid (Move) != true);

      // Add 1 to Total_Moves
      Total_Moves++;

      // Change whose turn it is
      switch (Whose_Turn)
      {
      case (1):
         {
            Board[Move] = 'x';
            Whose_Turn = 2;
            break;
         }
      case (2):
         {
            Board[Move] = 'o';
            Whose_Turn = 1;
         }
      }
   }
   // Show the board
   showBoard ( );
 
   if (whoWon ( ) == 1)
   {
      cout << Player_1_Name << " has won the game!" << endl;
   }
   else if (whoWon ( ) == 2)
   {
      cout << Player_2_Name << " has won the game!" << endl;
   }
   else
   {
      cout << "It's a tie game!" << endl;
   }

   system ("PAUSE");
}

void showBoard ( )
{
   cout << endl;
   cout << Board[0] << " | " << Board[1] << " | " << Board[2] << endl;
   cout << "--+---+--" << endl;
   cout << Board[3] << " | " << Board[4] << " | " << Board[5] << endl;
   cout << "--+---+--" << endl;
   cout << Board[6] << " | " << Board[7] << " | " << Board[8] << endl;
   cout << endl;
}

bool moveIsValid (int m)
{
   if (Board[m] != 'x' && Board[m] != 'o')
   {
      return true;
   }
   else
   {
      return false;
   }
} 

int whoWon ( )
{
   if (Board[0] == Board[1] && Board[1] == Board[2])
   {
      if (Board[0] == 'x')
      {
         return 1;
      }
      else
      {
         return 2;
      }
   }
   if (Board[3] == Board[4] && Board[4] == Board[5])
   {
      if (Board[3] == 'x')
      {
         return 1;
      }
      else
      {
         return 2;
      }
   }
   if (Board[6] == Board[7] && Board[7] == Board[8])
   {
      if (Board[6] == 'x')
      {
         return 1;
      }
      else
      {
         return 2;
      }
   }
   if (Board[0] == Board[3] && Board[3] == Board[6])
   {
      if (Board[0] == 'x')
      {
         return 1;
      }
      else
      {
         return 2;
      }
   }
   if (Board[1] == Board[4] && Board[4] == Board[7])
   {
      if (Board[1] == 'x')
      {
         return 1;
      }
      else
      {
         return 2;
      }
   }
   if (Board[2] == Board[5] && Board[5] == Board[8])
   {
      if (Board[2] == 'x')
      {
         return 1;

      }
      else
      {
         return 2;
      }
   }
   if (Board[0] == Board[4] && Board[4] == Board[8])
   {
      if (Board[0] == 'x')
      {
         return 1;
      }
      else
      {
         return 2;
      }
   }
   if (Board[2] == Board[4] && Board[4] == Board[6])
   {
      if (Board[2] == 'x')
      {
         return 1;
      }
      else
      {
         return 2;
      }
   }
   return 0;
}


Thanks!
abhishekm71 (820)
Please specify what 'difficulty' you are having.
KeegM480 (14)
Im just not sure where exactly I would put the function to generate the random number (between 0-8) for player 2
abhishekm71 (820)
I'm not sure but what I understand is that your player 2 is computer and you want to generate the move for it.

1
2
3
4
5
6
7
8
9
10
11
 
// Tell which player to move
         if (Whose_Turn == 1)
         {
            cout << Player_1_Name << ": It's your turn." << endl;
         cin >> Move;
         }
         else
         {
            cout << Player_2_Name << ": It's your turn." << endl;
            // generate the random move here.
         }

KeegM480 (14)
thats what i meant, this is what I did, I have two errors?

1
2
3
4
5
6
7
8
9
10
11
12
13
14
 
// Tell which player to move
         if (Whose_Turn == 1)
         {
            cout << Player_1_Name << ": It's your turn." << endl;
         }
         else
         {
            cout << Player_2_Name << ": It's your turn." << endl;
			rand ( ) 1 - 8
         }
         // Get the move
         cout << "Enter the number of the spot where you'd like to move." << endl;
         cin >> Move;
      } while (moveIsValid (Move) != true);
abhishekm71 (820)
You will have to include <cstdlib> to use the rand() function, and probably <ctime> if you want to seed the random number generator with a time value:

1
2
3
4
5
 
#include <cstdlib>
#include <ctime>

// in your main function
srand( time( NULL ) );


And in your loop,
1
2
3
4
5
6
7
8
9
10
11
12
 
// Tell which player to move
         if (Whose_Turn == 1)
         {
            cout << Player_1_Name << ": It's your turn." << endl;
            cin >> Move;
         }
         else
         {
            cout << Player_2_Name << ": It's your turn." << endl;
            Move = rand() % 9;
            
         }

KeegM480 (14)
Ok so no errors with just the loop part, bt 43 errors when I added the top part.

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
 
  #include <cstdlib>
   #include <ctime>

   // in your main function
   srand( time( NULL ) );

   while (whoWon ( ) == 0 && Total_Moves < 9)
   {
      // Do this until the player chooses a valid move
      do
      {
         // Show the board
         showBoard ( );

         // Tell which player to move
         if (Whose_Turn == 1)
         {
            cout << Player_1_Name << ": It's your turn." << endl;
         }
         else
         {
            cout << Player_2_Name << ": It's your turn." << endl;
            Move = rand() % 9;
         }
         // Get the move
         cout << "Enter the number of the spot where you'd like to move." << endl;
         cin >> Move;

      } 
	  while (moveIsValid (Move) != true);


What did I do wrong?? Im sorry, Im new to C++ only bee doing it for a little while, I am in an intro class. Thank you very much for your help!
abhishekm71 (820)
Please show your full updated code.
KeegM480 (14)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
 
 // Tic Tac Toe, by Keegan Mathur

// Include the libraries
#include <iostream>
#include <string>

//Use the standard namespace
using namespace std;

// Declare global variables
char Board[9];

// Declare functions
void showBoard ( );
bool moveIsValid (int m);
int whoWon ( ); //Returns 0 if no one has won, 1 if player 1 has won, and 2 if player 2 has won


void main ( )
{
   // Declare local variables
   string Player_1_Name;
   string Player_2_Name;
   int Whose_Turn = 1; // 1 means it's player 1's turn, 2 means it's player 2's turn
   int Move; // Stores where the player wants to move
   int Total_Moves = 0;

   //Assign values to the playing board
   Board[0] = '0';
   Board[1] = '1';
   Board[2] = '2';
   Board[3] = '3';
   Board[4] = '4';
   Board[5] = '5';
   Board[6] = '6';
   Board[7] = '7';
   Board[8] = '8';

   // Get player names
   cout << "Player 1: Please enter your name." << endl;
   cin >> Player_1_Name;
   cout << "Player 2: Please enter your name." << endl;
   cin >> Player_2_Name;

   #include <cstdlib>
   #include <ctime>

   // in your main function
   srand( time( NULL ) );

   while (whoWon ( ) == 0 && Total_Moves < 9)
   {
      // Do this until the player chooses a valid move
      do
      {
         // Show the board
         showBoard ( );

         // Tell which player to move
         if (Whose_Turn == 1)
         {
            cout << Player_1_Name << ": It's your turn." << endl;
         }
         else
         {
            cout << Player_2_Name << ": It's your turn." << endl;
            Move = rand() % 9;
         }
         // Get the move
         cout << "Enter the number of the spot where you'd like to move." << endl;
         cin >> Move;

      } 
	  while (moveIsValid (Move) != true);

      // Add 1 to Total_Moves
      Total_Moves++;

      // Change whose turn it is
      switch (Whose_Turn)
      {
      case (1):
         {
            Board[Move] = 'x';
            Whose_Turn = 2;
            break;
         }
      case (2):
         {
            Board[Move] = 'o';
            Whose_Turn = 1;
         }
      }
   }
   // Show the board
   showBoard ( );
 
   if (whoWon ( ) == 1)
   {
      cout << Player_1_Name << " has won the game!" << endl;
   }
   else if (whoWon ( ) == 2)
   {
      cout << Player_2_Name << " has won the game!" << endl;
   }
   else
   {
      cout << "It's a tie game!" << endl;
   }

   system ("PAUSE");
}

void showBoard ( )
{
   cout << endl;
   cout << Board[0] << " | " << Board[1] << " | " << Board[2] << endl;
   cout << "--+---+--" << endl;
   cout << Board[3] << " | " << Board[4] << " | " << Board[5] << endl;
   cout << "--+---+--" << endl;
   cout << Board[6] << " | " << Board[7] << " | " << Board[8] << endl;
   cout << endl;
}

bool moveIsValid (int m)
{
   if (Board[m] != 'x' && Board[m] != 'o')
   {
      return true;
   }
   else
   {
      return false;
   }
} 

int whoWon ( )
{
   if (Board[0] == Board[1] && Board[1] == Board[2])
   {
      if (Board[0] == 'x')
      {
         return 1;
      }
      else
      {
         return 2;
      }
   }
   if (Board[3] == Board[4] && Board[4] == Board[5])
   {
      if (Board[3] == 'x')
      {
         return 1;
      }
      else
      {
         return 2;
      }
   }
   if (Board[6] == Board[7] && Board[7] == Board[8])
   {
      if (Board[6] == 'x')
      {
         return 1;
      }
      else
      {
         return 2;
      }
   }
   if (Board[0] == Board[3] && Board[3] == Board[6])
   {
      if (Board[0] == 'x')
      {
         return 1;
      }
      else
      {
         return 2;
      }
   }
   if (Board[1] == Board[4] && Board[4] == Board[7])
   {
      if (Board[1] == 'x')
      {
         return 1;
      }
      else
      {
         return 2;
      }
   }
   if (Board[2] == Board[5] && Board[5] == Board[8])
   {
      if (Board[2] == 'x')
      {
         return 1;

      }
      else
      {
         return 2;
      }
   }
   if (Board[0] == Board[4] && Board[4] == Board[8])
   {
      if (Board[0] == 'x')
      {
         return 1;
      }
      else
      {
         return 2;
      }
   }
   if (Board[2] == Board[4] && Board[4] == Board[6])
   {
      if (Board[2] == 'x')
      {
         return 1;
      }
      else
      {
         return 2;
      }
   }
   return 0;
}
abhishekm71 (820)
Change your code to:

// Tic Tac Toe, by Keegan Mathur

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
 
// Include the libraries
#include <iostream>
#include <string>
#include <cstdlib>
#include <ctime>

//Use the standard namespace
using namespace std;

// Declare global variables
char Board[9];

// Declare functions
void showBoard ( );
bool moveIsValid (int m);
int whoWon ( ); //Returns 0 if no one has won, 1 if player 1 has won, and 2 if player 2 has won


void main ( )
{
   // Declare local variables
   string Player_1_Name;
   string Player_2_Name;
   int Whose_Turn = 1; // 1 means it's player 1's turn, 2 means it's player 2's turn
   int Move; // Stores where the player wants to move
   int Total_Moves = 0;

   //Assign values to the playing board
   Board[0] = '0';
   Board[1] = '1';
   Board[2] = '2';
   Board[3] = '3';
   Board[4] = '4';
   Board[5] = '5';
   Board[6] = '6';
   Board[7] = '7';
   Board[8] = '8';

   // Get player names
   cout << "Player 1: Please enter your name." << endl;
   cin >> Player_1_Name;
   cout << "Player 2: Please enter your name." << endl;
   cin >> Player_2_Name;

   srand( time( NULL ) );

   while (whoWon ( ) == 0 && Total_Moves < 9)
   {
      // Do this until the player chooses a valid move
      do
      {
         // Show the board
         showBoard ( );

         // Tell which player to move
         if (Whose_Turn == 1)
         {
            cout << Player_1_Name << ": It's your turn." << endl;
         cin >> Move;
         }
         else
         {
            cout << Player_2_Name << ": It's your turn." << endl;
            Move = rand() % 9;
         }

      } 
	  while (moveIsValid (Move) != true);

      // Add 1 to Total_Moves
      Total_Moves++;

      // Change whose turn it is
      switch (Whose_Turn)
      {
      case (1):
         {
            Board[Move] = 'x';
            Whose_Turn = 2;
            break;
         }
      case (2):
         {
            Board[Move] = 'o';
            Whose_Turn = 1;
         }
      }
   }
   // Show the board
   showBoard ( );
 
   if (whoWon ( ) == 1)
   {
      cout << Player_1_Name << " has won the game!" << endl;
   }
   else if (whoWon ( ) == 2)
   {
      cout << Player_2_Name << " has won the game!" << endl;
   }
   else
   {
      cout << "It's a tie game!" << endl;
   }

   system ("PAUSE");
}

void showBoard ( )
{
   cout << endl;
   cout << Board[0] << " | " << Board[1] << " | " << Board[2] << endl;
   cout << "--+---+--" << endl;
   cout << Board[3] << " | " << Board[4] << " | " << Board[5] << endl;
   cout << "--+---+--" << endl;
   cout << Board[6] << " | " << Board[7] << " | " << Board[8] << endl;
   cout << endl;
}

bool moveIsValid (int m)
{
   if (Board[m] != 'x' && Board[m] != 'o')
   {
      return true;
   }
   else
   {
      return false;
   }
} 

int whoWon ( )
{
   if (Board[0] == Board[1] && Board[1] == Board[2])
   {
      if (Board[0] == 'x')
      {
         return 1;
      }
      else
      {
         return 2;
      }
   }
   if (Board[3] == Board[4] && Board[4] == Board[5])
   {
      if (Board[3] == 'x')
      {
         return 1;
      }
      else
      {
         return 2;
      }
   }
   if (Board[6] == Board[7] && Board[7] == Board[8])
   {
      if (Board[6] == 'x')
      {
         return 1;
      }
      else
      {
         return 2;
      }
   }
   if (Board[0] == Board[3] && Board[3] == Board[6])
   {
      if (Board[0] == 'x')
      {
         return 1;
      }
      else
      {
         return 2;
      }
   }
   if (Board[1] == Board[4] && Board[4] == Board[7])
   {
      if (Board[1] == 'x')
      {
         return 1;
      }
      else
      {
         return 2;
      }
   }
   if (Board[2] == Board[5] && Board[5] == Board[8])
   {
      if (Board[2] == 'x')
      {
         return 1;

      }
      else
      {
         return 2;
      }
   }
   if (Board[0] == Board[4] && Board[4] == Board[8])
   {
      if (Board[0] == 'x')
      {
         return 1;
      }
      else
      {
         return 2;
      }
   }
   if (Board[2] == Board[4] && Board[4] == Board[6])
   {
      if (Board[2] == 'x')
      {
         return 1;
      }
      else
      {
         return 2;
      }
   }
   return 0;
}

KeegM480 (14)
Thank you, thank you, thank you! I am so happy right now!!!
Topic archived. No new replies allowed.