My program won't run

[wdpats]

I have programmed a program for billing system. I have used parameters and arrays. All the functions are working except a one function. (Regular package function). Please help me to solve that.

#include <iostream> 
#include <fstream>
#include <string> 
#include <ctime>

using namespace std;

void main(int &minutes, int &minutesd,int &minutesn)
{
	//functions declaring
	void menu(int &minutes,int &minutesd,int &minutesn);
	void help();
	void login(int &minutes,int &minutesd,int &minutesn);
	void bill(int &minutes,int &minutesd,int &minutesn);
	void regular(int &minutes);
	void blaster(int &minutesd, int &minutesn);

	//function calling
	login(minutes,minutesd,minutesn);
}
 
void login(int &minutes, int &minutesd,int &minutesn)
{
	//menu function declaring
	void menu(int &minutes, int &minutesd,int &minutesn);
	
	//variable declare
	string username,password;
	string ps[2];
	string un[2];
	int x;
	
	//collect login details
	logins:
	cout<<""<<endl;
	cout<<"Enter Username : ";
	cin>>username;
	cout<<""<<endl;
	cout<<"Enter Password : ";
	cin>>password;

	ifstream loginfile;
	loginfile.open("login.txt");

	for (x=0; x<2; x++)
	{
		loginfile>>un[x]>>ps[x]; //read login detailes from the file
		loginfile.close();
	
	//check login details
	if(username==un[x] && password==ps[x])
	
	{
		menu(minutes,minutesd,minutesn);
	}

	else
	{
		cout<<""<<endl;
		cout << "Invalid login details" << endl;
		cout << "" << endl;
		goto logins; //return to get login details
	}
	}
	

}

void menu(int &minutes, int &minutesd,int &minutesn)
{
	//functions declaring
	void help();
	void bill(int &minutes, int &minutesd,int &minutesn);

	themenu:
	int sel;
	cout<<"\t \t \t \t ..:::  Menu :::.."<<endl;
	cout<<""<<endl;
	cout<<"\t \t \t ==============================="<<endl;
	cout<<""<<endl;
	cout<<""<<endl;
	cout<<"\t \t \t \t 1.Help     "<<endl;
	cout<<""<<endl;
	cout<<"\t \t \t \t 2.Generate Bill   "<<endl;
	cout<<""<<endl;
	cout<<"\t \t \t \t 3.Exit    "<<endl;
	cout<<""<<endl;
	cout<<""<<endl;
	cout<<"\t \t \t ==============================="<<endl;
	cout<<""<<endl;
	cout<<"\t \t \t Enter your Selection : ";
	cin>>sel;

	switch(sel)
	{
	case 1: help();
	break;
	case 2: bill(minutes,minutesd,minutesn);
	break;
	case 3: system("exit");
	break;
	
	default:
		cout<<"Invalid Selection"<<endl;
		cout<<""<<endl;
		cout<<"Please Renter Your Selection"<<endl;
		goto themenu;
		break;
	}
}


void help()
{
	cout<<"\t \t \t======================"<<endl;
	cout<<"\t \t \t   System Guildelines"<<endl;
	cout<<"\t \t \t======================"<<endl;
	cout<<""<<endl;
	cout<<"When you enter the package type in the invoice you have to enter the package type as follows "<<endl;
	cout<<""<<endl;
	cout<<"\t \t Regular Package- 'r' or 'R' "<<endl;
	cout<<"\t \t Blaster Package- 'b' or 'B' "<<endl;
	cout<<""<<endl;
	cout<<"If you are using regular package use should enter minutes that you have used. If you are using blaster package you have to enter minutes that you have used in day time and night time seperatly"<<endl;
	cout<<""<<endl;
	cout<<"Time ranges are as follows,"<<endl;
	cout<<""<<endl;
	cout<<"\t \tDay Time   : 6.00 am to 6.00 pm"<<endl;
	cout<<"\t \tNight Time : 6.00 am to 6.00 pm"<<endl;
}



void bill(int &minutes, int &minutesd,int &minutesn)
{
	//external function declare
	void regular(int &minutes);
	void blaster(int &minutesd, int &minutesn);

	//variables declaring
	int accno,totalamount,amount,blamind,blaminn;
	char servicecode;
	string servicetype;

	//collect details
	ag:
	cout<<""<<endl;
	cout<<"Please Enter Your Account Number"<<endl;
	cin>>accno;
	service:
	cout<<"Please Enter Your Service Code"<<endl;
	cin>>servicecode;

	//check the package type
	if (servicecode =='r' | servicecode =='R' )       
	{
		regular(minutes); //call regular package fucntion
		servicetype="Regular Package";
		
		int rm=minutes;

		if (rm>50)
		{
			amount=(rm-50)*0.75;
			totalamount=100+amount;
		}
		
		else
		{
			amount=0;
		}
	} 

	else if (servicecode =='b' | servicecode =='B')       
	{
		blaster(minutesd,minutesn);  //call blaster package fucntion
		servicetype="Blaster Package";

		int md=minutesd;
		int mn=minutesn;

		if (md>75)
		{
			blamind=(md-75)*0.50;
		}
		else
		{
			blamind=0;
		}
		
		if (mn>100)
		{
			blaminn=(mn-100)*0.25;
		}

		else
		{	
			blaminn=0;
		}

		totalamount=250+blamind+blaminn;
	}
	else 
	{
		cout<<"Service Code is Wrong"<<endl;
		goto service;  //return to get service type	
	}

	//generate the bill
	time_t tme;
	time (&tme);
	cout<<""<<endl;
	cout<<"\t \t ===================================="<<endl;
	cout<<" \t \t \t \t Invoice "<<endl;
	cout<<"\t \t ===================================="<<endl;
	cout<<""<<endl;
	cout<<""<<endl;
	//cout<<"\t \t \tDate & Time    : "<<ctime(&tme)<<endl; 
	cout<<""<<endl;
	cout<<"\t \t Account No : "<<accno<<endl;
	cout<<""<<endl;
	cout<<"\t \t Service Type : "<<servicetype<<endl;
	cout<<""<<endl;

	if (servicetype =="Regular Package")
	{
		cout<<"\t \t Used Minutes Amount : "<<minutes<<endl;
		cout<<""<<endl;

		//export to data file
		ofstream detailsfile;
		detailsfile.open("regular.txt");
		detailsfile<<"\n"<<endl;
		detailsfile<<accno<<"\t";
		detailsfile<<minutes<<"\t";
		detailsfile<<totalamount;
		detailsfile<<"\n"<<endl;
		detailsfile.close();
	}

	else
	{
		cout<<"\t \t Used Minutes of Day Time : "<<minutesd<<endl;
		cout<<""<<endl;
		cout<<"\t \t Used Minutes of Night Time : "<<minutesn<<endl;
		cout<<""<<endl;

		//export to data file
		ofstream detailsfile;
		detailsfile.open("blaster.txt");
		detailsfile<<"\n"<<endl;
		detailsfile<<accno<<"\t";
		detailsfile<<minutesd<<"\t";
		detailsfile<<minutesn<<"\t";
		detailsfile<<totalamount;
		detailsfile<<"\n"<<endl;
		detailsfile.close();
		

	}

	cout<<"\t \t Total Charges : "<<totalamount<<endl;

}

void regular(int &minutes)
{
		
		cout<<"Please Enter the Used Number of the Minutes "<<endl;
		cin>>minutes;
		
}

void blaster(int &minutesd, int &minutesn)
{
		cout<<"Please Enter the Used Number of the Minutes in Day Time "<<endl;
		cin>>minutesd;

		cout<<"Please Enter the Used Number of the Minutes in Night Time "<<endl;
		cin>>minutesn;
		

		
}
		

[jh5jz8AR]

Hey wdpats,

I am still fresh to c++ so forgive me if I am mistaken.

On line 155 and 174, you have:

if (servicecode =='r' | servicecode =='R' )


else if (servicecode =='b' | servicecode =='B')

should they not be:


if (servicecode == 'r' || servicecode == 'R')


else if (servicecode == 'b' || servicecode == 'B')

[bugbyte]

@usdblades:
It is very likeley he wants "||", logical or, and not '|', bitwise or.

@wdpats
Apart from that, I don't know what your definition of "not working" is, and I am most certainly not going to try to guess what your error is in those 285 lines of code, so please describe what is "not working" e.g. where your problem is.

[mutexe]

I am most certainly not going to try to guess what your error is in those 285 lines of code

Just reading to line 8 points out a large issue:
void main(int &minutes, int &minutesd,int &minutesn)

This is not what your main function should look like.
Have a look here:
http://en.wikipedia.org/wiki/Entry_point#C_and_C.2B.2B

lines 11 - 16 should not be inside main either. You declare outside. See
http://www.cplusplus.com/doc/tutorial/functions/

Sort these out first then show us any compilation errors.

edit: using goto is fairly bad. Consider loops instead.