Program Doesn't Alphabetize Strings Help

[deckonsoul]

I do not know what I am doing wrong. I cant seem to get my program to alphabetize a vector string. Can anyone help me spot the error? It displays the names, but not in a sorted order.

 




void sort_names(vector<string> &nameList)
{
     int i, minIndex;

     string minValue;

     int size;



     size = nameList.size();



     for (i = 0; i < (size - 1); i++)

     {

            minIndex = i;

            minValue = nameList[i];

     for (int index = i + 1; index < size; index++)

         {

              if (nameList[index] < minValue)

                 {

                 minValue = nameList[index];

                 minIndex = index;

                 }

          }

                nameList[minIndex] = nameList[i]; 
                 nameList[i] = minValue;

     }




      //cout << endl << "Sorted names..." << nameList[i] << endl;

[cire]

It displays the names, but not in a sorted order.

Two things: Your display_names function does not display the names in the vector it is given as a parameter, and you don't call display_names after you call sort_names.

Get rid of lines 120 through 126. Change lines 129 to 138 to:

    for (int i=0; i<namelist.size(); ++i)
        cout << namelist[i] << '\n' ;

And remember to call display_names after you sort.

[deckonsoul]

int i, minIndex;

string minValue;

int size;



size = nameList.size();



for (i = 0; i < (size - 1); i++)

{

minIndex = i;

minValue = nameList[i];

for (int index = i + 1; index < size; index++)

{

if (nameList[index] < minValue)

{

minValue = nameList[index];

minIndex = index;

}

}

nameList[minIndex] = nameList[i];
nameList[i] = minValue;

}




cout << endl << "These are the name that have been sorted...." << endl;
cout << endl;
cout << nameList[i] << endl;
}

[cire]

What do you think cout << nameList[i] << endl; does in sort_names?

[deckonsoul]

Thanks Cire!! Really appreciate your help!