need help with formatting and math error

[mikeal200]

Sorted by name
ID Name Salary
------------------------------------
, $
2000 Adams, John $15000
1717 Bush, George $80000
1515 Carter, Jimmy $78000
1212 Jefferson, Thomas $34000
1313 Lincoln, Abraham $45000
1000 Washington, George $10000


Sorted by salary
ID Name Salary
------------------------------------
, $
1000 Washington, George $10000
2000 Adams, John $15000
1212 Jefferson, Thomas $34000
1313 Lincoln, Abraham $45000
1515 Carter, Jimmy $78000
1717 Bush, George $80000

Total Payroll $2.60867e-321

how do i get the numbers to allign ive tried right and left and setw() but that doesnt work also for some reason a comma and a $ get printed at the beginning of each report and my total payroll is fucked up can someone help me figure this out

#include <iostream>
#include <fstream>
#include <algorithm>
#include <vector>
#include <sstream>
#include <iomanip>
#include <string>

using namespace std;

class Presidents {
public:
	string firstname;
	string lastname;
	string salary;
	string id;
		
	Presidents (const string &firstname, 
		    const string &lastname, 
		    const string &salary, 
		    const string &id) {
		    this->firstname = firstname;
		    this->lastname = lastname;
		    this->salary = salary;
		    this->id = id;
	}
}; 

int get_file (ifstream& in, ofstream& out, string filename, string output); //this function opens the input file and output file and checks to see if they are open
void get_line (ifstream& in, ofstream& out); //this function brings the input file into a string and then changes all lowercase letters to uppercasse and leaves uppercase letters alone and changes digits to a * symbol then outputs its a$
//void name (ifstream& in, ofstream& out);
//void salary (ifstream& in, ofstream& out);
 
int main () {
	
        ifstream in; //instream
        ofstream out; //outstream
        string filename, output; //input and output file
        get_file (in, out, filename, output);
        get_line (in, out);
//        name (in, out);
//        salary (in, out);
}
int get_file (ifstream& in, ofstream& out, string filename, string output) {
        cout << "enter the file you would like to open" << endl;
        cin >> filename; //takes in the name of the file your opening
        in.open (filename.c_str()); //opens the file
        if (in.fail()) { //checks to see if the file is open
               cout << "that is not a file" << endl;
               return 0;
        }
        cout << "Input the name of the output file" << endl;
        cin >> output;
        out.open (output.c_str());
        if (in.fail()) {
                cout << "that is not a file" << endl;
                return 0;
        }

	return 0;
}
void get_line (ifstream& in, ofstream& out) {
	std::vector <Presidents> sort;
        string line;
	double total;
	out << "Sorted by name" << endl;
	out << "ID      Name                Salary" << endl;
	out << "------------------------------------" << endl;
        while (getline (in, line)){ // using getline to read in a single line at a time
		string id, firstname, lastname, salary;
		istringstream iss (line);
		iss >> id >> firstname >> lastname >> salary;
		Presidents person (firstname, lastname, salary, id);
		sort.push_back (person);
	}
	std::sort (sort.begin(), sort.end(), [] (const Presidents &a, const Presidents &b){return a.lastname < b.lastname; });
        for (Presidents i : sort) {
		out << i.id << "    " << i.lastname << ", " << i.firstname << " " << setw(12) << right << "$" << left << i.salary << endl;
	}
	out << endl << endl;
	out << "Sorted by salary" << endl;
	out << "ID      Name                Salary" << endl;
	out << "------------------------------------" << endl;
	while (getline (in, line)){ // using getline to read in a single line at a time
		string id, firstname, lastname, salary;
		int money = 0;
		istringstream iss (line);
		iss >> id >> firstname >> lastname >> salary >> total;
		if ( ! (istringstream(salary) >> money)) money = 0;
		Presidents person (firstname, lastname, salary, id);
		sort.push_back (person);
		total = money + total;
	}
	std::sort (sort.begin(), sort.end(), [] (const Presidents &a, const Presidents &b){return a.salary < b.salary; });
        for (Presidents i : sort) {
		out << i.id << "    " << i.lastname << ", " << i.firstname << " " << setw(12) << right << "$" << left << i.salary << endl;
	}
	
	out << endl << "Total Payroll $" << total << endl;
        in.close (); //closes the input file
        out.close (); //closes the output file
}

[jlb]

also for some reason a comma and a $ get printed at the beginning of each report

Please post a sample of your input file.

my total payroll is fucked up can someone help me figure this out

Where are you initializing total to some initial value?

how do i get the numbers to allign ive tried right and left and setw() but that doesnt work

Show your code that shows what you've tried.

[48T7M4Gy]

http://www.cplusplus.com/forum/general/212940/

[mikeal200]

my input file is
1000 George Washington 10000
2000 John Adams 15000
1212 Thomas Jefferson 34000
1313 Abraham Lincoln 45000
1515 Jimmy Carter 78000
1717 George Bush 80000
for total when i declared it i have = 0 now like double total = 0; and the output is total payroll = 0 so thats still messed up and i dont know why and how many attempts do you want me to put

[jlb]

You need to enclose your sample input file into code tags to preserve the actual file format.

Why are you trying to read the file twice?

...
       while (getline (in, line)){ // using getline to read in a single line at a time
		string id, firstname, lastname, salary;
		istringstream iss (line);
		iss >> id >> firstname >> lastname >> salary;
		Presidents person (firstname, lastname, salary, id);
		sort.push_back (person);
	}
	std::sort (sort.begin(), sort.end(), [] (const Presidents &a, const Presidents &b){return a.lastname < b.lastname; });

...
//////// You've already read the complete file above so why try (and fail) to read the file again? ///////
	while (getline (in, line)){ // using getline to read in a single line at a time

And you will need to make sure total is initialized before you try to use it.

By the way having a variable that has the same name as a standard function is really not a good idea. I would rename your "sort" variable to a better more descriptive name.

[mikeal200]

because i need to read it twice because i sort it in different ways if you look at the output unless i only need to read it in once also the input file is in its actual format its exactly like that

1000 George Washington 10000
2000 John Adams 15000
1212 Thomas Jefferson 34000
1313 Abraham Lincoln 45000
1515 Jimmy Carter 78000
1717 George Bush 80000

and i already initialized total by doing this double total = 0; and the output file just says the total payroll is 0 also thanks for the tip about changing sort

[jlb]

because i need to read it twice because i sort it in different ways

Why do you need to read the file twice just to sort the vector?

Answer, you don't and you're not really reading the file twice, which is why money is staying at zero. When you finish with your first loop the stream is in an error state (eof was triggered) and when a stream is in an error stream no further operations on the stream will occur until the error is cleared, then it would be possible to re-position the file pointer to the beginning of the file and then re-read the file.

However re-reading the file is not necessary in this case, just do the "money" calculations in the first loop.

Something like this:

...
    while(getline(in, line))    // using getline to read in a single line at a time
    {
        string id, firstname, lastname, salary;
        istringstream iss(line);
        iss >> id >> firstname >> lastname >> salary;

        sort.push_back({firstname, lastname, salary, id});  // Using initialization semantics.

        double money = 0.0;
        istringstream(salary) >> money;

        total += money;
    }

    std::sort(sort.begin(), sort.end(), [](const Presidents & a, const Presidents & b)
    {
        return a.lastname < b.lastname;
    });

    for(Presidents i : sort)
    {
        out << i.id << "    " << i.lastname << ", " << i.firstname << " " << setw(12) << right << "$" << left << i.salary << endl;
    }

    out << endl << endl;
    out << "Sorted by salary" << endl;
    out << "ID      Name                Salary" << endl;
    out << "------------------------------------" << endl;

    std::sort(sort.begin(), sort.end(), [](const Presidents & a, const Presidents & b)
    {
        return a.salary < b.salary;
    });

    for(Presidents i : sort)
    {
        out << i.id << "    " << i.lastname << ", " << i.firstname << " " << setw(12) << right << "$" << left << i.salary << endl;
    }

[mikeal200]

thank you very much for this it helps me learn