Code works on Linux but not on Windows OS

[adjaharrison]

Hi,
I have been wondering why the code below is giving me different output on Windows OS. Meanwhile, the same code works well on Ubuntu.

#include <iostream>
#include <cstring>

using namespace std;

string getname(void);
char getgender(string);
void setinfo(string,char);

int main()
{
    string customer = "";
    char gender;
    do {
        do{
            customer = getname();
        }while(customer =="");
        do{
            gender = getgender(customer);
            cout << "Gender in Main block is: " << gender << endl;
        }while(gender != 'm' && gender != 'f');
        setinfo(customer,gender);
        break;
    }while(1);
    return 0;
}

string getname(void)
{
    string name = "";
    cout <<"Please Enter your Name: " ;
    getline(cin,name);
    if(name == ""){
        cout << "Error: Name cannot be empty" <<  endl;
    }
    return name;
}

char getgender(string name)
{
    char gender;
    string strgender;
    cout << "Male / Female[m/f]: ";
    getline( cin,strgender);
    gender = strgender[0];
    strgender.clear();
    gender = tolower(gender);
    if(gender == 'm' || gender == 'f'){
        cout << "Gender in getgender() is: " << gender << endl;
        return gender;
    }
    else
        cout <<"Error: Must be m/ f" << endl;
}

void setinfo(string customer, char gender)
{
    string prefix;
    if(gender == 'm')
        prefix =  "Mr.";
    else
        prefix = "Ms/Mrs.";
    cout << "Hello " << prefix << " " << customer << endl;
    cout << "Welcome to TOWER HEIGHT" << endl;
}

On my Ubuntu machine, this code works fine. But when I compile and run it on Windows, I get different output and it keeps looping at getgender().

Please Enter your Name: My Name
Male / Female[m/f]: m
Gender in getgender() is: m
Gender in Main block is: ╕

Male / Female[m/f]: f
Gender in getgender() is: f
Gender in Main block is: ╕

Male / Female[m/f]:

Thank you for your time.
Adja

[b2ee]

Interesting.

Try to directly change "gender" in main by
getgender(string, char&); //put gender as the second parameter, and in getgender to assign the result directly to the reference.

Take a look what will happen.

[adjaharrison]

Thanks for the reply. I am yet to get to pointers and references so can you please give example of how to put gender as the second parameter.
I was taught functions so I decided to create a program using it.

I enabled warnings on my linux box using -Wall compiler flag and got this message:

chartest.cpp: In function ‘char getgender(std::string)’:
chartest.cpp:54: warning: control reaches end of non-void function

so I added return 0 after the else statement and it works well now.

I will try on how to change gender and see what will happen when I get to pointers.



Thank you very much for your help

[b2ee]

Good on you.

In declaration,
char getgender(string, char&);

Then, In main, call it like this
getgender(customer, gender);

In the function, use the input "gender" parameter like a normal local variable.

Google it, you can find many examples about reference. In C++, try to more use reference than pointer.