Set Class - Copy constructor

[aab1990]

I keep running into segmentation faults with my current copy constructor.

Set::Set( const Set & A)
{
   Node * Temp = A.Head->Succ;
   while ((Temp) )
   {
      insert(Temp->Item);
      Temp = Temp->Succ;
   }
}

[Gumbercules]

the head hasn't been set to null.
You probably want to start with temp = A.Head, else you're missing the first item.

[aab1990]

That still seg faults.... I have been running some tests and the insert( Temp->Item); makes it seg fault right away, but if i take that out the Temp = Temp->Succ; will run til the end of the set then seg fault...

[Gumbercules]

Did you do this?

Set::Set( const Set & A)
{
   head == NULL;
   Node * Temp = A.Head;
   while ((Temp) )
   {
      insert(Temp->Item);
      Temp = Temp->Succ;
   }
}

[aab1990]

This is what I got... I needed to make a new Node for the head of the Set, but It still seg faults at the end... any ideas?

Set::Set( const Set & A)
{
   this->Head = new (nothrow) Node;
   this->Head->Succ = NULL;
   Node * Temp = A.Head;

   while (Temp)
   {
      Temp = Temp->Succ;
      insert(Temp->Item);
   }
}

[Gumbercules]

now you're advancing to the next pointer before inserting, meaning when you try to insert NULL->Item.

[aab1990]

There is a dummy node at the front of the set. So A.head->Succ really points to the first item in the set. Then i try and insert and it seg faults. The loop seg faults without the insert in there, but right when insert is called it seg faults. I tested the insert function outside of the copy constructor and it seems to work just fine.