Please critique my Java JRPG code

[twiggystardust]

Hello fellow programmers! As some of you know lately I have been working on a JRPG in the likes of Final Fantasy 1 - 3. I have been coding away, trying new things, breaking the game, fixing it and adding new features. I've never really been able to have anyone else look over my code and critique it (none of my friends are programmers.) So I thought I'd ask here. It is in Java but I know most of you know multiple languages. So if you want to look it over or if you would like to critique my code the git repository is https://www.github.com/twiggystardust/RPGTest . Thanks if you check it out.

[tath]

JRPG - Java RPG

[twiggystardust]

I changed it to Java JRPG. but tath, I did not mean java rpg at all. JRPG stands for Japanese Role Playing Game. No I am not Japanese but that is the style of game I created.

[Cheraphy]

I'll check it out tonight and see if I have any relevant points to make.

Incidentally, the Dark Souls franchize is technically JRPG, but in no way conforms the the typical style of a JRPG.

[MiiNiPaa]

the Dark Souls franchize is technically JRPG

I always felt that it was more roguelike.

[Disch]

Randomly generated dungeons, and randomly distributed items that need to be identified are staples if not defining characteristics of a roguelike. Dark Souls has neither, so I would not consider it a roguelike at all.

I'd call Dark Souls an action RPG. Similar to games like Secret of Mana, or even Zelda (although Zelda waters down the RPG elements)

[twiggystardust]

MiiNiPaa: I think he meant because it was developed by a Japanese company From Software.

[Cheraphy]

IfFrankZappaWasSkinnierThanHeAlreadyWasGuy wrote:

I think he meant because it was developed by a Japanese company From Software.

Correct

[twiggystardust]

Cheraphy: I just might change my name to that....

EDIT: So I just took a look at my repository, there's a few files in the main package that I have moved into new packages(which you will notice if you go through the packages (player.java, npc.java, tile.java and tileMap.java.)) I need to remove them, but I've never done that before, any help would be greatly appreciated.

[twiggystardust]

*bump

[Danny Toledo]

I need to remove them, but I've never done that before, any help would be greatly appreciated.

Something like this? http://stackoverflow.com/a/2047477

Hope that helps.

[twiggystardust]

So I updated the game a little bit and removed the unneeded files from the repository, so if you wanted to check it out https://github.com/twiggystardust/RPGTest .