winsocket problem, 2 accept() for 1 client?

[Gyiove]

Hello everyone!

Here's my socket class:

class spSocket
{
public:
	SOCKET psocket;
	spchar *ip;
	spchar *port;
	spchar *error;

	spSocket()
	{
		port = 0;
		ip = new spchar(20);
		port = new spchar(20);
		error = new spchar(256);
		psocket = INVALID_SOCKET;
	}

	unsigned int invalid()
	{
		return INVALID_SOCKET;
	}

	int sendmessage(SOCKET sin, void *in, int size)
	{
		int r = send(sin, (char *)in, size, 0);
		return r;
	}

	int receivemessage(SOCKET sin, void *out, int size)
	{
		int r = recv(sin, (char *)out, size, 0);
		return r;
	}

	SOCKET WaitForClient()
	{
		return accept(psocket, NULL, NULL);
	}

	void CloseConnection()
	{
		if (psocket == INVALID_SOCKET) return;
		closesocket(psocket);
		psocket = INVALID_SOCKET;
	}

	void CloseConnection(SOCKET in)
	{
		if (in != INVALID_SOCKET) closesocket(in);
		if (psocket == INVALID_SOCKET) return;
		closesocket(psocket);
		psocket = INVALID_SOCKET;
	}

	bool CreateServer(spchar IP, spchar PORT)
	{
		*ip = IP;
		*port = PORT;
		WSADATA wsaData;
		psocket = INVALID_SOCKET;

		struct addrinfo *result = NULL;
		struct addrinfo hints;

		int iResult = WSAStartup(MAKEWORD(2, 2), &wsaData);
		if (iResult != 0) {
			error->format("WSAStartup failed with error: %d\n", iResult);
			return false;
		}

		ZeroMemory(&hints, sizeof(hints));
		hints.ai_family = AF_INET;
		hints.ai_socktype = SOCK_STREAM;
		hints.ai_protocol = IPPROTO_TCP;
		hints.ai_flags = AI_PASSIVE;

		if (ip->size) iResult = getaddrinfo(ip->getchar(), port->getchar(), &hints, &result);
		else iResult = getaddrinfo(NULL, port->getchar(), &hints, &result);

		if (iResult != 0) {
			error->format("getaddrinfo failed with error: %d\n", iResult);
			WSACleanup();
			return false;
		}

		psocket = socket(result->ai_family, result->ai_socktype, result->ai_protocol);

		if (psocket == INVALID_SOCKET) {
			error->format("socket failed with error: %ld\n", WSAGetLastError());
			freeaddrinfo(result);
			WSACleanup();
			return false;
		}

		if (iResult == SOCKET_ERROR) {
			error->format("ioctlsocket failed with error: %d\n", WSAGetLastError());
			closesocket(psocket);
			WSACleanup();
			return false;
		}

		iResult = bind(psocket, result->ai_addr, (int)result->ai_addrlen);
		if (iResult == SOCKET_ERROR) {
			error->format("bind failed with error: %d\n", WSAGetLastError());
			freeaddrinfo(result);
			closesocket(psocket);
			WSACleanup();
			return false;
		}

		freeaddrinfo(result);
		iResult = listen(psocket, SOMAXCONN);

		if (iResult == SOCKET_ERROR) {
			error->format("listen failed with error: %d\n", WSAGetLastError());
			closesocket(psocket);
			WSACleanup();
			return false;
		}
		return true;
	}

	bool Connect(spchar IP, spchar PORT)
	{
		*ip = IP;
		*port = PORT;
		WSADATA wsaData;
		struct addrinfo *result = NULL, *ptr = NULL, hints;
		int iResult = WSAStartup(MAKEWORD(2, 2), &wsaData);

		if (iResult != 0) {
			error->format("WSAStartup failed with error: %d\n", iResult);
			return false;
		}

		ZeroMemory(&hints, sizeof(hints));
		hints.ai_family = AF_UNSPEC;
		hints.ai_socktype = SOCK_STREAM;
		hints.ai_protocol = IPPROTO_TCP;
		iResult = getaddrinfo(ip->getchar(), port->getchar(), &hints, &result);

		if (iResult != 0)
		{
			error->format("getaddrinfo failed with error: %d\n", iResult);
			WSACleanup();
			return false;
		}

		for (ptr = result; ptr != NULL; ptr = ptr->ai_next) 
		{
			psocket = socket(ptr->ai_family, ptr->ai_socktype, ptr->ai_protocol);

			if (psocket == INVALID_SOCKET) {
				error->format("socket failed with error: %ld\n", WSAGetLastError());
				WSACleanup();
				return false;
			}

			iResult = connect(psocket, ptr->ai_addr, (int)ptr->ai_addrlen);

			if (iResult == SOCKET_ERROR)
			{
				closesocket(psocket);
				psocket = INVALID_SOCKET;
				error->format("The server is down... did not connect");
			}
		}

		freeaddrinfo(result);

		if (psocket == INVALID_SOCKET)
		{
			error->format("Unable to connect to server!\n");
			WSACleanup();
			return false;
		}

		if (iResult == SOCKET_ERROR)
		{
			error->format("ioctlsocket failed with error: %d\n", WSAGetLastError());
			closesocket(psocket);
			WSACleanup();
			return false;
		}
		return true;
	}

	~spSocket()
	{


	}
};

This is how i'm using it:

int _tmain(int argc, _TCHAR* argv[])
{
	/*cout << "1- create server" << endl;
	cout << "2- create client" << endl;*/

	cout << "3- create simple server" << endl;
	cout << "4- create simple client" << endl;
	cout << endl << endl;
	int o = 1;
	running = 0;
	cin >> o;

	if (o == 3)
	{
		char buffer[128];
		spSocket a;
		a.CreateServer("", "27000");
		SOCKET t = a.WaitForClient();
		/*
		This last WaitForClient should block my program and wait for another connection
		but it doesn't do that.
		The last one returns valid client SOCKET but the first one is unknown for me.
		*/
		t = a.WaitForClient(); 

		a.receivemessage(t, buffer, 128);
		cout << "got message:" << buffer << endl;

		cin >> buffer;
		cout << "sending:" << buffer << endl;
		a.sendmessage(t, buffer, 128);
		system("pause");
		return 0;
	}

	if (o == 4)
	{
		char buffer[128];
		spSocket a;
		a.Connect("", "27000");
		cin >> buffer;
		cout << "sending:" << buffer << endl;
		a.sendmessage(a.psocket, buffer, 128);

		a.receivemessage(a.psocket, buffer, 128);
		cout << "got message:" << buffer << endl;
		system("pause");
		return 0;
	}
	system("pause");
	return 0;
}

Thanks!

[Gyiove]

		/* i
		nside:
		bool Connect(spchar IP, spchar PORT) 
		*/

		for (ptr = result; ptr != NULL; ptr = ptr->ai_next) 
		{
			psocket = socket(ptr->ai_family, ptr->ai_socktype, ptr->ai_protocol);

			if (psocket == INVALID_SOCKET) {
				error->format("socket failed with error: %ld\n", WSAGetLastError());
				WSACleanup();
				return false;
			}

			iResult = connect(psocket, ptr->ai_addr, (int)ptr->ai_addrlen);

			if (iResult == SOCKET_ERROR)
			{
				closesocket(psocket);
				psocket = INVALID_SOCKET;
				error->format("The server is down... did not connect");
				continue;
			}
			break // <-- forgot to break.
		}

[AcarX]

Shouldn't you also add continue; after error->format("The server is down... did not connect"); ?

[Gyiove]

oh yeah thanks.
I already did it actually in my code back in project yet i forgot to bring that update here.