Random String Generator in C++

[mausy131]

Hi there,

I need some help with my code.
It is a random string generator which works perfect.
However there is one problem.
I want to get the string in my memory using
cin, getline, scanf, or whatever, but that
doesn't work. Can someone tell me how to get
the string I generated and how to store it in a variable?

CODE:"

#include <iostream>
#include <string>
#include <cstdlib>
#include <ctime>
using namespace std;

static const char alphanum[] =
"0123456789"
"!@#$%^&*"
"ABCDEFGHIJKLMNOPQRSTUVWXYZ"
"abcdefghijklmnopqrstuvwxyz";

int stringLength = sizeof(alphanum) - 1;

char genRandom()  // Random string generator function.
{

    return alphanum[rand() % stringLength];
}

int main()
{
    srand(time(0));
    for(int z=0; z < 21; z++)
    {
        cout << genRandom();

    }
    return 0;

}

[S G H]

// If you use C's char arrays:
char String[128] = {0};
for(unsigned int i = 0; i < 21; ++i)
{
    String[i] = genRandom();
}
// If you use C++'s std::string:
std::string Str;
for(unsigned int i = 0; i < 21; ++i)
{
    Str += genRandom();
}

Also pointing out:

return alphanum[1+(rand()%sizeof(alphanum)) % stringLength];
// Because of this, the very first character will never be taken/used/printed
// Use this instead, which is also faster:
return alphanum[rand() % stringLength]

[mausy131]

Thanks for your reply (:

code:

#include <iostream>
#include <string>
#include <cstdlib>
#include <ctime>
using namespace std;

static const char alphanum[] =
"0123456789"
"!@#$%^&*"
"ABCDEFGHIJKLMNOPQRSTUVWXYZ"
"abcdefghijklmnopqrstuvwxyz";

int stringLength = sizeof(alphanum) - 1;

char genRandom()
{

    return alphanum[rand() % stringLength];
}

int main()
{
    srand(time(0));
    std::string Str;
    for(unsigned int i = 0; i < 20; ++i)
    {
    Str += genRandom();

    }
    cout << Str << endl;
    


}


    
    // THANKS FOR THE HELP EssGeEich!

    return 0;

}

[S G H]

mausy131 wrote:

// THANKS FOR THE HELP EssGeEich!

Lol, no need at all.