Function

[bjt223]

The objective of this assignment was to that each player roll a dice and the highest dice roll wins. This should allow each player to roll by hitting the "Enter" key.

My question about this code is that I am having trouble with getting response from the players such yes and no. Also, I am having problem with play one turn as I try to alternative each players but for some reason it doesn't roll and display dice. Lastly, I think I'm having problem with Display winner. Any helpful hints would help me out.

Thank you so much.

 #include "header.h"

// Correct in this area! Fix other functions
int main()
{

	int rollOne;
	int rollTwo;
	char response;
	char player1[NAME_SIZE];
	char player2[NAME_SIZE];

	srand (time(NULL));

	OutputInstructions();

	GetPlayerNames(player1, player2);

	response = GetAndCheckCharResponse();

	while (response)
	{
		rollOne = PlayOneTurn(player1);
		rollTwo = PlayOneTurn(player2);
		DisplayWinner(rollOne, rollTwo, player1, player2);



		response = GetAndCheckCharResponse();
	}

	cout << "Thank you for Playing" << endl;

	return 0;
void DisplayDie(int die)
{
	const string DIE_ONE = "-----------\n"
						   "+ 		  +\n"
						   "+ 		  +\n"
						   "+ 	 0	  +\n"
						   "+ 		  +\n"
						   "+ 		  +\n"
						   "-----------\n";
	const string DIE_TWO = "-----------\n"
						   "+		  +\n"
						   "+ 	0	  +\n"
						   "+ 		  +\n"
						   "+ 		0 +\n"
						   "+ 		  +\n"
						   "-----------\n";
	const string DIE_THREE = "-----------\n"
							 "+  0 	    +\n"
							 "+		    +\n"
							 "+ 	0 	+\n"
							 "+ 		+\n"
							 "+		  0 +\n"
							 "-----------\n";
	const string DIE_FOUR = "-----------\n"
							"+ 		   +\n"
							"+ 	0 	0  +\n"
							"+ 		   +\n"
							"+ 	0 	0  +\n"
							"+ 		   +\n"
							"-----------\n";
	const string DIE_FIVE = "-----------\n"
							"+ 		   +\n"
							"+ 	0 	0  +\n"
							"+ 	  0    +\n"
							"+  0 	0  +\n"
							"+ 		   +\n"
							"-----------\n";
	const string DIE_SIX = "-----------\n"
						   "+   0 	0 +\n"
						   "+ 		  +\n"
						   "+ 	0 	0 +\n"
						   "+ 		  +\n"
						   "+ 	0 	0 +\n"
						   "-----------\n";

	if (die < 1 || die > 6)
	{
		cerr << "***** ERROR - INVALID DIE VALUE *****\n";
	}
	else
	{
		cout << "EDGE << DIE[die-1] << EDGE";
	}
}
int DisplayWinner(int rollOne, int rollTwo, char* player1, char* player2)
{
	char winner;

	if (rollOne > rollTwo)
	{
		cout << " " << player1 << " is the WINNER!!!" << endl;
		winner = player1;
	}
	else if (rollTwo > rollOne)
	{
		cout << " " << player2 << " is the WINNER!!!" << endl;
		winner = player2;
	}
	else
	{
		cout << " " << player1 << "and" << " " << player2
			 << "have tied!" << endl;
		winner = player1, player2;
	}


	return winner;
}
bool GetAndCheckCharResponse()
{

	bool valid;
	char checkResponse;


	do
	{
		cout << "Would you like to play High Roller (y/n)? ";
		cin.get(checkResponse);
		cin.ignore(1000, '\n');
		valid = checkResponse == 'Y' || checkResponse == 'y'
				|| checkResponse == 'N'  || checkResponse == 'n';

		if (!valid)
		{
			cout << "**Invalid Input - Please enter 'Y' or 'N' **";

		}
	}
	while (!valid);

	return checkResponse;
}
void GetPlayerNames(char player1[NAME_SIZE],
					 char player2[NAME_SIZE])
{
	cout << "First player, please enter your name: ";
	cin.getline(player1, NAME_SIZE);
	cin.ignore(1000, '\n');

	cout << "Second player, please enter your name: ";
	cin.getline(player2, NAME_SIZE);
	cin.ignore(1000, '\n');

}
int PlayOneTurn(char player[])
{
	int die;
	int roll;
	char player1;
	char player2;


	cout << " " << player1 << "\'s turn. ";

	PressEnterToRoll();

	DisplayDie(die);

	die = RollDie(roll);


	cout << " " << player2 << " \'s turn. ";

	PressEnterToRoll();

	die = RollDie(roll);

	DisplayDie(die);

	return die;
}
void PressEnterToRoll()
{
	string rollDice;
	cout << "Please <enter> to roll...";
	cin >> rollDice;

}

int RollDie(int roll)
{
	roll = rand() % 6 + 1;

	return roll;
}

[bjt223]

Can soneone help me out here? I think there something wrong in this area.

int PlayOneTurn(char player[])
{
	int die;
	int roll;
	char player1;
	char player2;


	cout << " " << player1 << "\'s turn. ";

	PressEnterToRoll();

	DisplayDie(die);

	die = RollDie(roll);


	cout << " " << player2 << " \'s turn. ";

	PressEnterToRoll();

	die = RollDie(roll);

	DisplayDie(die);

	return die;
}

[MiiNiPaa]

DisplayDie(die);
die = RollDie(roll);

You are trying to display die before it was thrown.

[bjt223]

Okay, my next problem is that whenever I try to press enter, it would not roll.

int main()
{

	int rollOne;
	int rollTwo;
	char response;
	char player1[NAME_SIZE];
	char player2[NAME_SIZE];

	srand (time(NULL));

	OutputInstructions();

	GetPlayerNames(player1, player2);

	response = GetAndCheckCharResponse();

	while (response)
	{
		rollOne = PlayOneTurn(player1);
		rollTwo = PlayOneTurn(player2);
		DisplayWinner(rollOne, rollTwo, player1, player2);

		response = GetAndCheckCharResponse();
	}

	cout << "Thank you for Playing" << endl;

	return 0;

void PressEnterToRoll()
{
	char rollDice;
	char player[NAME_SIZE];


	cout << "Please <enter> to roll...";
	cin >> rollDice;

	rollDice = PlayOneTurn(player);

}
int PlayOneTurn(char player[])
{
	int die;
	int roll;


	cout << " " << player << "\'s turn. ";

	PressEnterToRoll();
	die = RollDie(roll);

	DisplayDie(die);


	return die;
}

Any hint and ideas please?

[Ispil]

Well, cin requires an input to continue, so hitting enter in that case will not work. Try using getline.