tic tac toe array function problem

[axdel]

So I am testing the winOrTie function which should return false when a player has won or there is a tie. My problem is I am testing it for when player 1 wins on the top horizontal line and player 2 is still allowed to pick one more time after player 1 wins. This does not happen when player 2 wins and I am assuming this is because of the way my while loop is set up but I can't figure out how to fix this. I am thinking I need to set the loop up a different way, any suggestions?

 #include <iostream>
#include <cstdlib>
using namespace std;

// Global constants
const int ROWS = 3;	// Number of rows
const int COLS = 3; // Number of columns
bool win = true;	// Holds if game is won
// Function definitions
void showBoard(char [][COLS], int);	// showBoard prototype
void p1Select (char [][COLS], int);	// player 1 selection prototype
void p2Select (char [][COLS], int);	// player 2 selection prototype
bool winOrTie (char [][COLS]);	// win or tie selection prototype

int main()
{

	char board[ROWS][COLS] = {{42,42,42},
							  {42,42,42},
							  {42,42,42}};
	while (win == true)
	{
		showBoard(board, ROWS);
		p1Select(board, ROWS);
		win = winOrTie(board);
		showBoard(board, ROWS);
		p2Select(board, ROWS);
		win = winOrTie(board);	
	} 
	cout << "game over\n";

    cout << endl;
    system("PAUSE");

    return 0;
}
void showBoard(char array[][COLS], int ROWS)
{
	for (int i = 0; i < ROWS; i++)
	{
		for (int j = 0; j < COLS; j++)
		{
			cout << array[i][j] << " ";
		}
		cout << endl;
	}
}
void p1Select(char array[][COLS], int ROWS)
{
	int i, j;
	char select = 'X';
	cout << "Player 1: Select a row number and column number to place an X: ";
	cin >> i >> j;
	while (i > ROWS && j > COLS)
	{
		cout << "Row and column selection must be numbers 1-3 ";
		cin >> i >> j;	
	}
	array[i-1][j-1] = select;
}
void p2Select(char array[][COLS], int ROWS)
{
	int i, j;
	char select = 'O';
	cout << "Player 2: Select a row number and column number to place an O: ";
	cin >> i >> j;
	while (i > ROWS && j > COLS)
	{
		cout << "Row and column selection must be numbers 1-3 ";
		cin >> i >> j;	
	}
	array[i-1][j-1] = select;
}
bool winOrTie(char array[][COLS])
{
	char X, O;

	if (array[0][0] == 'X' && array[0][1] == 'X' && array[0][2] == 'X')
	{
		cout << "Player 1 wins\n";
		return false;
	}
	else if (array[0][0] == 'O' && array[0][1] == 'O' && array[0][2] == 'O')
	{
		cout << "Player 2 wins\n";
		return false;
	}
}

[kradragon94]

In your loop you may add a line like so:

while (win == true)
	{
		showBoard(board, ROWS);
		p1Select(board, ROWS);
		win = winOrTie(board);
                if (win == false)
                     break;
		showBoard(board, ROWS);
		p2Select(board, ROWS);
		win = winOrTie(board);	
	} 

this prevent you code from continueing after player1's winning
Note that you winOrTie function must return (TRUE) at the end.
And your naming looks confused (in case of winning, return "false"?).

My bad English, please correct me :)

[axdel]

Inserting those lines causes it to end after the first player selects so it doesn't work