help with this error

[mjatt]

I am getting this error :Access violation reading location 0xabababab.

anything wrong with this code???

  #include <iostream>
using namespace std;
#include <string>

struct cont 
{
	string name;
	double money;
};

int main()
{
	cout << " total contributors :"<< endl;
	int x;
	cin >> x;
	cin.get();

	
	cont * p = new cont[x];

	int i;

	for (i = 0; i < x ; i++)
	{
		cout << "name : " << endl;
		getline(cin, p->name);

		

		cout << "money : " << endl;
		cin >> p->money;
		cin.get();
		p = p +1;
	};

	p = p - (x-1);

	cout << "headed patrons : " << endl;
	int j = 0;
	 for (i = 0; i < x; i++)
	 {
		 if (p->money <= 10000)
		 {
			 cout << p->name << endl;
			 j++;
		 };

		 p = p+1;
	 };

	 if (j == 0)
		 cout << " none" << endl;
	 p = p - (x-1);

	 cout << " grand patrons : " <<  endl;


	 int k = 0;

	 for (i = 0; i < x; i++)
	 {
		 if (p->money > 10000)
		 {
			 cout << p->name << endl;
			 k++;
		 };

		 p = p+1;
	 };

	 if (k == 0)
		 cout << " none " << endl;
	 
	 p = p -(x-1);

	 delete [] p;
	 cin.get();
	 cin.get();
}

[keskiverto]

You have:

cont * p = new cont[x];
for ( int i = 0; i < x ; i++)
{
	cin >> p->money;
	p = p +1;
};
p = p - (x-1);

The loop does increment p for 'x' times, doesn't it?

Overall, this is error-prone. Keep the pointer at the start of the array. There are alternatives:

cont * p = new cont[x];
for ( int i = 0; i < x ; ++i )
{
	cin >> p[i].money;
	// or
	cin >> (p+i)->money;
};

[mjatt]

thanx man!