no matching function call

[cory244]

So I have a few errors with no matching function call line 108. Please help I deleted chunks of code to let me post this but I only deleted irrelevant code for the question.

class Sdisk
{
  public :
  Sdisk(string diskname);
  Sdisk(string diskname, int numberofblocks, int blocksize);
  int getblock(int blocknumber, string& buffer);
  int putblock(int blocknumber, string buffer);
  int getblocksize(int blocksize) const;
  string getname(string diskname);
  private :
  string diskname;        // file name of pseudo-disk
  int numberofblocks;     // number of blocks on disk
  int blocksize;          // block size in bytes
};

Sdisk::Sdisk(string discname)
{

 if (diskname == discname)
  {
    fstream iofile;
    string disc = diskname + ".spc";
    iofile.open(disc.c_str());
    iofile >> numberofblocks >> blocksize;
    iofile.close();
  }
 else
  {
    cout << "No disk exist. Error code 1" << endl;
  }
}

Sdisk::Sdisk(string diskname, int numberofblocks, int blocksize) //default constructor
{
  this -> diskname = diskname;
  this -> numberofblocks = numberofblocks;
  this -> blocksize = blocksize;
  string spcfile = diskname + ".spc";
  string datfile = diskname + ".dat";

  ofstream outfile;
  outfile.open(spcfile.c_str());
  outfile << numberofblocks << " " << blocksize;
  outfile.close();

  outfile.open(datfile.c_str());
  for(int i = 0; i < numberofblocks * blocksize; i++)
  {
    outfile.put('#');
  }
  long length = outfile.tellp();
  cout << "File size is: " << length << endl;
  outfile.close();
}

int Sdisk::getblock(int blocknumber, string& buffer)
{
  ifstream enterdat;
  string opendat = diskname + ".dat";
  enterdat.open(opendat.c_str());
  enterdat.seekg(blocksize * blocknumber, ios::beg);
  for(int i = 0; i < blocksize; i++)
  {
    char a = enterdat.get();
    buffer += a;
  }
  enterdat.close();
}
int Sdisk::getblocksize(int blocksize) const
{
  return blocksize;
}
class Filesys: public Sdisk
{
  private:
  int rootsize; //maximum number of entries in ROOT
  int fatsize;  //number of blocks occupied by FAT
  vector<string>  filenames;            // filenames in root
  vector<int>           firstblock;             // firstblocks in ROOT
  vector<int>           fat;                   

  public:
  Filesys( string filename); //creates an Sdrive
  int fsclose();        //
  int fssyncout (); //
  void buildfilenames(); //
  void buildfat(); //

  int newfile ( string file); //
  int rmfile ( string file);//
  int getfirstblock( string file);//

  int addblock ( string file , string block);
  int delblock( string file , int blocknumber);
  int readblock( string file , int blocknumber , string& buffer);

  int writeblock ( string file , int blocknumber , string buffer);
  int nextblock( string file , int blocknumber) ;
  int getrootsize();

  int getfatsize();
  int getblocksize()const;
  string getdiskname() const;
};

int Filesys::getblocksize() const
{
  int tmp = Sdisk::getblocksize();
  return tmp;
}

string Filesys::getdiskname() const
{
  string tmp = Sdisk::getname();
  return tmp;
}

Filesys::Filesys( string filename) : Sdisk( filename)
{
  rootsize = 10; //number of files available in root
  fatsize =  36 ; //getnumberofblocks();

  for(int i = 0 ; i<rootsize; i++)
  {
    filenames.push_back("xxxxx");
    firstblock.push_back(0);
  }
  fat.push_back(3);

  for(int i = 1; i < fatsize; i++)
  {
    fat.push_back(1);
  }

  for(int i = 3; i < fatsize; i++)
  {
    fat[i] = i + 1;
  }
  fat[fat.size() - 1] = 0;
  string tmp1 = filename + ".dat";

  fstream iofile2;
  iofile2.open(tmp1.c_str(), ios::in | ios::out);
  char c;
  c = iofile2.get();
  if(c == '!')
  {
    cout << filename << " has a file system" << endl;
  }
  if(x == '#')
  {
    cout << "Disk" << filename << " already exists." << endl;
    cout << "Putting file system on " << getdiskname() << endl;

    string buffer;
    for(int i = 0; i < 36; i++)
    {
      buffer += '!';
    }
    Sdisk::putblock(0, buffer);
  }
  iofile2.close();
}

int Filesys::fclose()
{
  fssyncout();
}

int Filesys::newfile(string file)
{
  cout << "File " << file << " is being added to the disk: " << getdiskname() << endl;

  if(file.length() > 5)
  {
    cout << "Error 1 File: " << file << " is too large." << endl;
    return 0;
  }

  for(int i = 0; i < filenames.size(); i++)
  {
    if( filenames[i] == file)
    {
      cout << "ERROR 2 File:  "<< file <<" already exists on disk named: "<< getdiskname() << endl;
      return 0;
    }
  }

  for(int i = 0; i < filenames.size(); i++)
    if(filenames[i] == "xxxxx")
    {
      filenames[i] = file;
      cout << "SUCCESS! " << file << " added to disk: " << getdiskname() << endl;
      break;
    }

  fssyncout();
} // end of newfile

int Filesys::rmfile(string file)
{
  cout << "Deleting: " << file << " from disk: " << getdiskname() << endl;
  for(int i=0; i < filenames.size(); i++)
  {
    if(filenames[i] == file)
    {
      if(firstblock[i] == 0)
      {
        filenames[i] = "xxxxx";
        fssyncout();
        return 1;
      }
    }
  }
  return 0;
}//end of remove file

int Filesys::getfirstblock(string file)
{
    for(int i=0; i < filenames.size(); i++)
    {
      if(filenames[i] == file)
      {
        return firstblock[i];
      }
    }
  return 0;
}//end of get the first block

int Filesys::addblock(string file, string block)
{
//check if disk is full
  if(fat[0] == 0)
  {
    cout<<getdiskname()<<" is full"<<endl;
    return -1;
  }

  for(int i = 0; i < filenames.size(); i++)
  {
    if(filenames[i] == file)
    {
      cout << file << " is located in root." << endl;
      return firstblock[i];
    }
    else
    {
      cout << file << " not in files" << endl;
      return 0;
    }
  }

  int nextblock = getfirstblock(file);

  if(nextblock == 0)
  {
    for(int i = 0; i < filenames.size(); i++)
      if(filenames[i] == file)
      {
        firstblock[i] = fat[0];
        break;
      }
  }
  else
  {
    while(fat[nextblock] != 0)
    {
      nextblock = fat[nextblock];
    }
    fat[nextblock] = fat[0];
  }

  //update fat
  int allocate = fat[0];
  fat[0] = fat[fat[0]];
  fat[allocate] = 0;

} //end addingblock

int Filesys::delblock(string file, int blocknumber)
{

} // end delblock

int Filesys::readblock(string file, int blocknumber, string &buffer)
{

}

int Filesys::writeblock(string file, int blocknumber, string buffer)
{

}//end writeblock

int Filesys::nextblock(string file, int blocknumber)
{

}//end of nextblock

int Filesys::getrootsize()
{
  return rootsize;
}

int Filesys:getfatsize()
{
  return fatsize;
}
//NEED TO ADD more here


// You can use this to test your Sdisk class

int main()
{
  Sdisk disk1("test1",16,32);
  string block1, block2, block3, block4;
  for (int i=1; i<=32; i++) block1=block1+"1";
  for (int i=1; i<=32; i++) block2=block2+"2";
  disk1.putblock(4,block1);
  disk1.getblock(4,block3);
  cout << "Should be 32 1s : ";
  cout << block3 << endl;
  disk1.putblock(8,block2);
  disk1.getblock(8,block4);
  cout << "Should be 32 2s : ";
  cout << block4 << endl;
}

[AbstractionAnon]

Line 108: Sdisk:getblocksize is declared to take one argument (line 8). The implementation of this (line 69) really doesn't make sense. You return the argument, where you probably meant to return the member of the class (line 13). If you meant to return the member of the class, then Sdisk:getblocksize shouldn;t take an argument at all.

[SECMoG1T]

int tmp = Sdisk::getblocksize(); there is no matching function call because as you have defined you getblocksize () it seems to be taking an int parameter bur on lines 108 you dint provide
That argument yet it also seems that you haven't overloaded that function or even default intialized its parameter hence the call on line 108 is illegal

 int Sdisk::getblocksize(int blocksize) const /// remove these parameter and you function will be fine 
 {                                                                            /// these patameter overshadows you private member
                                                                              /// blocksize
     return blocksize;
  }

[cory244]

Okay if I comment out the line you listed

int Sdisk::getblocksize(int blocksize) const /// remove these parameter and you function will be fine 
 {                                                                            /// these patameter overshadows you private member
                                                                              /// blocksize
     return blocksize;
  }

It will throw an error on line ln 108 saying error passing argument of int Sdisk::getblocksize()'
I also change the variable in the Sdisk class to look like this

int getblocksize();

[AbstractionAnon]

I also change the variable in the Sdisk class to look like this

Line 8 is a function delcaration, not a variable.

[cory244]

Yeah sorry. So from your first post AbstractionAnon it should look like this then.

int Sdisk::getblocksize()
{
  return blocksize;
}

And when I modify it I get an error on this section of code still or line 108 stating that error passing const Filesys' as 'this' argument of 'int Sdisk::getblocksize()' discards qualifiers

int Filesys::getblocksize() const
{
  int tmp = Sdisk::getblocksize();
  return tmp;
}

[AbstractionAnon]

In line 8, your function declaration is declared as const.
Therefore, your code should match the constness.

int Sdisk::getblocksize() const
{  return blocksize;
}

BTW, you don't need getblocksize as a member of Filesys. Because Filesys inherits Sdisk, all of Sdisk's public functions (including getblocksize), are available to an instance of Filesys. i.e. get rid of line 102 and 106-110.