Converting recursive function into a loop

[amarthy]

I am trying to convert a recursive function into a for loop but it is not working properly. Please advise. Thank you for your help!!

//recursive function (works properly)
int factorial(int n, int acc = 1)
{
	if (n == 1)
		return acc;
	else
		return factorial(n - 1, acc*n);
}

//converting recursive function into a loop (not working)
int factorial(int n)
{
	int acc = 1;
	for (; n > 1; --n){
		acc *= n;
		return acc;
	}

}

[keskiverto]

Explain line 17.

[amarthy]

that is just returning the final value.

i actually got it to work by doing a while loop.

int factorial(int n)
{	int num = n;
	int acc = 1;
	while(num != 1)
	{
		acc = acc * num;
		num = num - 1;
		
	}
	
	return acc;
}

[amarthy]

also got it to work with the for loop!

int factorial(int n)
{
	int acc = 1;
	for (; n >= 1; --n){
		acc *= n;
	}

	return acc;
}