structs + dynamic allocations - output problem

[Soto1991]

When i try to cout the array after activate the functions. the program is stocked! (you can only see the kid's details).

With my best regards :)

  #include <iostream>
#include <string.h>
using namespace std;
 
const int MAX_LETTERS = 30;
 
struct person_t
{
        int id;
        char *firstName;
        person_t *mom;
        person_t *dad;
};
 
struct family_t
{
        char *lastName;
        person_t* mom;
        person_t *dad;
        int numberOfKids;
        person_t* kids;
};
 
void readPerson(person_t *person);
void printPerson(person_t *person);
void readFamily(char *dad, char *mom);
void printFamily(family_t *family);
 
void main()
{
        person_t person1;
        person_t person2;
 
        readPerson(&(person1));
        cout << '\n';
        readPerson(&(person2));
 
        cout << '\n';
 
        family_t *family;
 
        cout << "Enter a name of family's dad (if there is): ";
        cin >> family->dad;
        cout <<
        cout << '\n';
 
        printFamily(&(family));
 
        delete[]person1.firstName;
        delete[]person2.firstName;
        delete[]family.lastName;
 
        cout << '\n';
}
void readPerson(person_t *person)
{
        char temp[MAX_LETTERS];
        cout << "Please enter a name (max 30 letters): ";
        cin >> temp;
 
        person->firstName = new char[strlen(temp) + 1];
        strcpy(person->firstName, temp);
 
        cout << '\n';
 
        cout << "Please enter an id: ";
        cin >> person->id;
 
        person->dad = NULL;
        person->mom = NULL;
}
 
void printPerson(person_t *person)
{
        cout << "Person's name: " << person->firstName << '\n';
        cout << "Perons's id: " << person->id << '\n';
        if (person->dad != NULL)
        {
                cout << "Person's dad: " << person->dad << '\n';
        }
        else if (person->mom !=NULL)
        {
                cout << "Person's mom: " << person->mom << '\n';
        }
}
 
void readFamily(char *dad, char *mom)
{
        family_t *family;
        dad = &family->dad;
        char temp[MAX_LETTERS];
        cout << "Please enter a family's dad: ";
        cin >> *dad=*(famliy->dad);
 
        cout << "Enter a name for family (max 30 letters): ";
        cin >> temp;
 
        family->lastName = new char[strlen(temp) + 1];
        strcpy(temp, family->lastName);
 
        cout << "Enter number of kids: ";
        cin >> family->numberOfKids;
 
        family->kids = new person_t[family->numberOfKids];
 
        for (int i = 0; i < family->numberOfKids; i++)
        {
                cout << "Enter details for kid number " << i + 1 << '\n';
                readPerson(&(family->kids[i]));
        }
}
 
void printFamily(family_t *family)
{
        cout << "Family name: " << family->lastName << '\n';
        if (family->dad != NULL && family->mom!=NULL)
        {
                cout << "Family's dad: " << family->dad << '\n';
                cout << "Family's mom: " << family->mom << '\n';
        }
        else
        {
                cout << "There isn't a dad or a mon in the family." << '\n';
        }
        cout << "Kids in the family: " << '\n';
        for (int i = 0; i < family->numberOfKids; i++)
        {
                printPerson(&(family->kids[i]));
        }
 
        for (int i = 0; i < family->numberOfKids; i++)
        {
                delete[]&(family->kids[i]);
        }
        delete[] & (family->kids);
        delete[]&(family->numberOfKids);
}

[ne555]

¿stocked?


> you can only see the kid's details
your code doesn't compile, you cannot run it and see its ouput.

[Soto1991]

ok, so what i need to do to fix it?

[ne555]

show your actual code.

foo.cpp|29 col 11| error: ‘::main’ must return ‘int’
||  void main()
||            ^
|| foo.cpp: In function ‘int main()’:
foo.cpp|43 col 6| error: no match for ‘operator>>’ (operand types are ‘std::istream {aka std::basic_istream<char>}’ and ‘person_t*’)
||   cin >> family->dad;
||       ^
foo.cpp|44 col 7| error: no match for ‘operator<<’ (operand types are ‘std::ostream {aka std::basic_ostream<char>}’ and ‘std::ostream {aka std::basic_ostream<char>}’)
||   cout <<
||        ^
foo.cpp|47 col 23| error: cannot convert ‘family_t**’ to ‘family_t*’ for argument ‘1’ to ‘void printFamily(family_t*)’
||   printFamily(&(family));
||                        ^
foo.cpp|51 col 17| error: request for member ‘lastName’ in ‘family’, which is of pointer type ‘family_t*’ (maybe you meant to use ‘->’ ?)
||   delete[]family.lastName;
||                  ^
|| foo.cpp: In function ‘void readFamily(char*, char*)’:
foo.cpp|90 col 6| error: cannot convert ‘person_t**’ to ‘char*’ in assignment
||   dad = &family->dad;
||       ^
foo.cpp|93 col 16| error: ‘famliy’ was not declared in this scope
||   cin >> *dad=*(famliy->dad);
||                 ^