Why won't this compute?

[CornholeChamp1]

Why won't this compute? i have been working all day trying to get it to compute correctly!

//============================================================================
// Name        : Currency
// Author      : Corey Woods
// Professor   : 
// Date        : 
// Description : This program will convert 100 U.S dollars to Zambian Kwacha,
//               Icelandic Krona, and Swedish Krona.
//============================================================================

#include <iostream>
#include <iomanip>

using namespace std;

const double ZAMBIAN_KWACHA_PER_DOLLARS = 11.25;
const double ICELANDIC_KRONA_PER_DOLLARS = 126.80;
const double SWEDISH_KRONA_PER_DOLLARS = 8.40;

int selection = 0;
double dollar;

double dollarToZambianKwacha(double zambianKwacha)
{
	cout << "Please input the U.S. Dollar amount for Zambian Kwacha conversion: $";
	cin >> dollar;
	cout << "Your Zambian Kwacha conversion is: " << fixed << setprecision(2) << dollar << endl;

	zambianKwacha = dollar * ZAMBIAN_KWACHA_PER_DOLLARS;

	return zambianKwacha;
}

double dollarToIcelandicKrona(double icelandicKrona)
{
	cout << "Please input the U.S. Dollar amount for Icelandic Krona conversion: $";
	cin >> dollar;
	cout << "Your Icelandic Krona conversion is: " << fixed << setprecision(2) << dollar << endl;

	icelandicKrona = dollar * ICELANDIC_KRONA_PER_DOLLARS;

	return icelandicKrona;
}

double dollarToSwedishKrona(double swedishKrona)
{
	cout << "Please input the U.S. Dollar amount for Swedish Krona conversion: $";
	cin >> dollar;

	swedishKrona = dollar * SWEDISH_KRONA_PER_DOLLARS;
	cout << "Your Swedish Krona conversion is: $" << fixed << setprecision(2) << swedishKrona << endl;

	return swedishKrona;
}

double getUserChoice()
{
		while(true)
		{
			cout << "Please select from the following options: " << endl;
			cout << "Option 1 -> Dollar to Zambian Kwacha Conversion" << endl;
			cout << "Option 2 -> Dollar to Icelandic Krona Conversion" << endl;
			cout << "Option 3 -> Dollar to Swedish Krona Conversion" << endl;
			cout << "Option 4 -> Exit" << endl;
			cin >> selection;
			cout << endl;

			if(selection == 1)
			{
				dollarToZambianKwacha(zambianKwacha);
			}
			else if(selection == 2)
			{
				dollarToIcelandicKrona(icelandicKrona);
			}
			else if(selection == 3)
			{
				dollarToSwedishKrona(swedishKrona);
			}
			else if(selection == 4)
			{
				cout << "Goodbye! Have a nice day!" << endl;
				abort();
			}
			else
			{
				cout << "Incorrect selection! Please try again." << endl << endl;
			}
		}

	return selection;
}

int main()
{
	getUserChoice();
	dollarToZambianKawacha(zambianKwacha);
	dollarToIcelandicKrona(icelandicKrona);
	dollarToSwedishKrona(swedishKrona);

	return 0;
}

[Moschops]

Line 69. The variable zambianKwacha does not exist inside that function.

Read the error messages from the compiler. They exist for a reason.

[TarikNeaj]

Edit: Forget everything that was in this post I misread.

[CornholeChamp1]

its not returning the correct conversion though?

[TarikNeaj]

(Forget my last post)
Your problem, like @Moschops stated, is that the variables you are using does not exist. swedishKrona, icelandicKrona and zambianKwacha does not exist, you havent created them. You need to create these variables before using them, which Im sure you already know. You're also not using the arguments you pass to the functions.

[tom221b]

I have edited your code a bit to get it working. Hope it helps.

//============================================================================
// Name        : Currency
// Author      : Corey Woods
// Professor   :
// Date        :
// Description : This program will convert 100 U.S dollars to Zambian Kwacha,
//               Icelandic Krona, and Swedish Krona.
//============================================================================

#include <iostream>
#include <iomanip>

using namespace std;

const double ZAMBIAN_KWACHA_PER_DOLLARS = 11.25;
const double ICELANDIC_KRONA_PER_DOLLARS = 126.80;
const double SWEDISH_KRONA_PER_DOLLARS = 8.40;

int selection = 0;
double dollar;

double dollarToZambianKwacha()
{
	cout << "Please input the U.S. Dollar amount for Zambian Kwacha conversion: $";
	cin >> dollar;

	double zambianKwacha = dollar * ZAMBIAN_KWACHA_PER_DOLLARS;
	cout << "Your Zambian Kwacha conversion is: " << fixed << setprecision(2) << zambianKwacha << endl;

	return zambianKwacha;
}

double dollarToIcelandicKrona()
{
	cout << "Please input the U.S. Dollar amount for Icelandic Krona conversion: $";
	cin >> dollar;

	double icelandicKrona = dollar * ICELANDIC_KRONA_PER_DOLLARS;
	cout << "Your Icelandic Krona conversion is: " << fixed << setprecision(2) << icelandicKrona << endl;


	return icelandicKrona;
}

double dollarToSwedishKrona()
{
	cout << "Please input the U.S. Dollar amount for Swedish Krona conversion: $";
	cin >> dollar;

	double swedishKrona = dollar * SWEDISH_KRONA_PER_DOLLARS;
	cout << "Your Swedish Krona conversion is: $" << fixed << setprecision(2) << swedishKrona << endl;

	return swedishKrona;
}

void getUserChoice()
{
		while(true)
		{
			cout << "Please select from the following options: " << endl;
			cout << "Option 1 -> Dollar to Zambian Kwacha Conversion" << endl;
			cout << "Option 2 -> Dollar to Icelandic Krona Conversion" << endl;
			cout << "Option 3 -> Dollar to Swedish Krona Conversion" << endl;
			cout << "Option 4 -> Exit" << endl;
			cin >> selection;
			cout << endl;

			if(selection == 1)
			{
				dollarToZambianKwacha();
			}
			else if(selection == 2)
			{
				dollarToIcelandicKrona();
			}
			else if(selection == 3)
			{
				dollarToSwedishKrona();
			}
			else if(selection == 4)
			{
				cout << "Goodbye! Have a nice day!" << endl;
				return;
			}
			else
			{
				cout << "Incorrect selection! Please try again." << endl << endl;
			}
		}
}

int main()
{
	getUserChoice();

	return 0;
}

[CornholeChamp1]

How do you output this all to a file

[TarikNeaj]

By writing code - http://www.cplusplus.com/doc/tutorial/files/