strcpy

[cpp1024]

I'm trying to make a function that copies a string to another string, but my output isn't right. What am I doing wrong?

#include <iostream>

using namespace std;

void strcpy2(char*, const char*);

int main() {
	char c[] = "Pizza";
	char d[] = "Apple";

	cout << "Before:" << endl;
	cout << "c: " << c << endl;
	cout << "d: " << d << endl;
	cout << endl;

	strcpy2(d, c);
	cout << "After:" << endl;
	cout << "c: " << c << endl;
	cout << "d: " << d << endl;
	cout << endl;

	return 0;
}

void strcpy2(char *dest, const char *src) {
	while (*src != '\0') {
		*dest = *src;
		src++;
		dest++;
	}
	*dest = '/0';
}

This is what the output looks like:
Before:
c: Pizza
d: Apple

After:
c: Pizza
d: Pizza0╠╠╠╠╠╠╠╠╠╠Pizza

[SakurasouBusters]

char c[] = "Pizza";
char d[] = "Apple";

Should be :

char c[] = "Pizza\0";
char d[] = "Apple\0";

Or :

char c[] = {'P', 'i', 'z', 'z', 'a', '\0'};
char d[] = {'A', 'p', 'p', 'l', 'e', '\0'};

[integralfx]

*dest = '\0';

@SakurasouBusters
C-style strings are also known as null terminated strings, so your suggested changes do nothing.

[Peter87]

Integralfx is right.

SakurasouBusters, string literals are always null terminated.

char c[] = "Pizza"; is equvalent to char c[] = {'P', 'i', 'z', 'z', 'a', '\0'};.

If you do char c[] = "Pizza\0"; that would mean c is an array of size 7 where the last two elements are null characters.

[CptJY]

@cpp1024

have a look at line 31. It's à \ not a /.

Doing so suppresses the null caracter, and provoques an unexpected output depending on what is in memory.

Hope that helps

[keskiverto]

A compiler does actually warn about the line 31:

31:10: warning: multi-character character constant [-Wmultichar]
 In function 'void strcpy2(char*, const char*)':
31:8: warning: overflow in implicit constant conversion [-Woverflow] 

It does depend on the version of compiler and its options, how verbose they are.
It is a very useful skill to pay attention to what the compiler says.

[cpp1024]

I see, I used the forward slash by mistake. Thanks for helping!