Find letter function

I need to write a function that gets a letter from the user and checks the list to see if that letter is in the file. This is my file:
Alabama
Alaska
Arizona
Arkansas
California
Colorado
Connecticut
Delaware

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
#include "stdafx.h"
#include <iostream>
#include <fstream>
#include <string>
#include <conio.h>
#include <vector>
#include <algorithm>
#include <cstdlib>
using namespace std;
int main()
{
	
	//Open and read file
	std::string line_;
	ifstream file_("LIST.txt");

	if (file_.is_open())

	{
		{

			std::cout << line_ << '\n';

		}
		//Close file
		file_.close();
	}
	else
		std::cout << "File is not open" << '\n';
	std::cin.get();

	////////////////////////

		
	//Function to enter letter
		int EnterLetter();
	{
		//Declare variable for the letter
		int A;

		//Promot user for letter
		cout << "\n\nEnter a letter: ";

		//Input letter
		cin >> A;

		//Confirm the letter
		cout << "You entered" << A;

		//Return the letter
		return A;
	}
	void EnterLetterWithReference(int &A);
	{
		//Declare variable for the letter
		int A;

		//Prompt user for letter
		cout << "\n\nEnter a letter: ";

		//Input letter
		cin >> A;

		//Confirm letter
		cout << "You entered" << A;
	}
	//Function to print a letter
	void PrintLetter(int A);
	{
		//Declare variable for the letter
		int A;
		//Output the letter
		cout << "\nThe letter is" << A;
	}
	//Function to print the letters between A and Z
	void PrintLettersBetweenAAndZ(int A, int Z);
	{
		//Declare variable for the letter
		int A, Z;
		if (A < Z)
		{
			cout << "\n\nThe letters between" << A << "and" << Z << "are:";
			int k;
			for (k = A; k <= Z; k++)
				cout << " " << k;
		}
		else
		{
			//Declare variable for the letter
			int A, Z;
			cout << "\n\nThe letters between" << A << "and" << Z << "are:";
			int k;
			for (k = Z; k >= A; k--)
				cout << " " << k;
		}
	}


		bool IsBetweenZAndA(int letter, int Z, int A);
		{
			//Declare variable for the letter
			int A, Z;

			//Find if letter is between A and Z
			if ((Z <= letter) && (letter <= A))
				return true;
			else
				return false;
		}


	//Function to enter letter between A and Z
		int EnterLetterBetweenAAndZ(int A, int Z)
		{

			//Declare variable for the letter
			int Letter;
			do
			{
				//Prompt user for letter
				cout << "\n\nEnter a letter between" << A << "and" << Z << ":";
				//Input letter
				cin >> Letter
					//Confirm the letter
					cout << "You entered" << Letter;
				//Validate the letter
				if (IsBetweenAAndZ(Letter, A, Z))
				{
					//The letter is correct
					//Return the letter
					return Letter;
				}
				//If letter is incorrect
				else
					cout << "\nThe letter you entered (" << Letter << ") is not between"
					<< A << "and" << Z << ".Try again!";

			} 
			while (IsBetweenAAndZ(Letter, A, Z) == false);
			
	
}
		int _tmain(int argc, _TCHAR* argc[])
		{
			int N1;
			Ni = EnterLetter();

			cout << "\n";

			//print letter function
			PrintLetter(N1);
			PrintLetter(N2);
			PrintLetter(9);
			PrintLetter(N1 + 5);

			PrintLettersbetweenAAndZ();


			PrintLettersbetweenAAndZ();

			PrintLettersbetweenAAndZ(A, Z);
			PrintLettersbetweenAAndZ(N1, N2);
			PrintLettersbetweenAAndZ(N2, Z);
			PrintLettersbetweenAAndZ('A', 'Z');
			PrintLettersbetweenAAndZ(A, Z);

			PrintLettersbetweenAAndZ();

			int N3 = EnterLetterBetweenAAndZ(A, Z);
			cout <<"\n\nThe letter is"<< N3

			

			//Wait for a character before closing the console
			cout << "\nPress any key to continue...";
			_getch();
			return 0;
		}


Any help would be appreciated thank you for your time.
Last edited on
Line 10: If you're using _tmain(), then you should not have main().

Line 22: What's the purpose of this line? line_ is always going to be empty.

Line 36,53,68,76,99,113: You can;t define functions inside another function (main).

Line 36,53,68,76,99: Function implementations do not have a ; after the signature.

Line 45: You're entering an int. Is that what you want?

Line 56: The local declaration of A hides the argument.

Line 66: The local variables A goes out of scope. The value entered is lost.

Line 71: The local declaration of A hides the argument.

Line 73: You're printing an uninitialized variable.

Line 79: This declaration of A and Z hides the arguments A and Z.

Line 80: You're comparing uninitialized variables.

Line 90: A and Z are uninitialized variables.

Line 102: Local declaration of A and Z hides arguments.

Line 105: You're comparing uninitialized variables.
I've tried something different but when I type in a letter and press enter it gives me back a multiple numbers and closes the console before I can read it.

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
{
				//Function to enter letter
				int EnterLetter();

				{
					//Declare variable for the letter
					int A;

					//Promot user for letter
					cout << "\n\nEnter a letter: ";

					//Input letter
					cin >> A;

					//Confirm the letter
					cout << "You entered" << A;

					//Return the letter
					return A;
				}

				std::cout << "Write the path of the file\n";
				std::string path;
				std::cin >> path;

				std::ifstream file(path.c_str());

				if (file.is_open())
				{
					std::cout << "File '" << path << "' opened.\n";

					std::cout << "Enter Letter\n";
					std::string letter;
					std::cin >> letter;

					int countletter = 0;
					std::string candidate;
					while (file >> candidate) 
					{
						if (letter == candidate) ++countletter;
					}

					std::cout << "Letter '" << letter << "' Is valid " << countletter << " times.\n";
				}

				else
				{
					std::cerr << "Invalid letter\n";
					return 1;
				}

				}
Topic archived. No new replies allowed.