Minimum and Maximum values returning as "0"

[danwiffle]

My program compiles and runs, but is returning "0" as the value for the minimum and maximum values. What am I doing wrong?

  #include <iostream>
#include <iomanip>
#include <string>
using namespace std;

int main()

{

 double n1, n2, n3, i;
 char y;
 int minimum;

	cout<<"This program will calculate the min, max, and mean of a set of three numbers.\n\n"; 
	cout<<"Please enter numbers between 1 and 1000.\n\n";
		

	do{
		cout<<"Please enter your first number:\n\n";
		cin>>n1;
	  }while(n1<=0 || n1>=1000);

	do{	  
		cout<<"Please enter your second number:\n\n";
		cin>>n2;
	  }while(n2<=0 || n2>=1000);

	do{
		cout<<"Please enter your third number:\n\n";
		cin>>n3;
	  }while(n3<=0 || n3>=1000);


	cout<<"You have entered the following numbers:\n";
	cout<<n1<<"\n"<<n2<<"\n"<<n3<<"\n\n";

	cout<<"The minimum value is:"<<minimum<<"\n\n";

	
return 0;
}


//create minimum function
int minimum()

{

 int x, y, z;
 int lowest, highest;

	if (x<y)

		{
			lowest = x;
			highest = y;
		}
	else

		{
			lowest = y;
			highest = x;
		}

	if (z<lowest)

		{
			lowest = z;
		}

	else if (z>highest)

		{
			highest = z;
		}

//end of minimum function		
}

[SamuelAdams]

Your not setting the value of minimum anywhere.

[d1g1talarts]

you have not implemented the function you created. you will need to use your minimum function, and i think with the way you have it set up you will want to have 3 parameters passed to your function so that you can access user input.

int minimum(int input1, int input2, int input3) //this is your method declaration
return lowest;// the return your method needs

minimum=minimum(n1,n2,n3)//implementation & setting your variable

as for setting minimum to a number you are going to need to have your method a number and have your var = lowest

[danwiffle]

changed up a few things based off of your advice, but now my code will not compile. I am getting the "expected initializer" error

[cod#include <iostream>
#include <iomanip>
#include <stdio.h>
using namespace std;


int main()
int minimum(int x, int y, int z)

{

float n1, n2, n3, i;
char y;


cout<<"This program will calculate the min, max, and mean of a set of three numbers.\n\n";

cout<<"Please enter numbers between 1 and 1000.\n\n";


do{
cout<<"Please enter your first number:\n\n";
cin>>n1;
}while(n1<=0 || n1>=1000);

do{
cout<<"Please enter your second number:\n\n";
cin>>n2;
}while(n2<=0 || n2>=1000);

do{
cout<<"Please enter your third number:\n\n";
cin>>n3;
}while(n3<=0 || n3>=1000);


cout<<"You have entered the following numbers:\n";
cout<<n1<<"\n"<<n2<<"\n"<<n3<<"\n\n";


getch();

cout<<"The minimum value is:"<<lowest<<"\n\n";


return 0;
}


//create minimum function
minimum (int x, int y, int z)

{

int x, y, z;
int lowest, highest;

if (x<y)

{
lowest = x;
highest = y;
}
else

{
lowest = y;
highest = x;
}

if (z<lowest)

{
lowest = z;
}

else if (z>highest)

{
highest = z;
}

//end of minimum function
}
e][/code]

[Repeater]

The error message also comes with a line, telling you which line to start looking at.

That said:

int main()
int minimum(int x, int y, int z)

This is just plain wrong.

[ne555]

namespace nih{
   double min(double a, double b);
}

int main(){
   double x, y;
   std::cin >> x >> y;
   double minimum = nih::min(x, y);
   std::cout << minimum << '\n';
}

double nih::min(double a, double b){
   double lowest = a;
   if (b<a)
      lowest = b;
   return lowest;
}