an exercise by a begginer (true begginer)

[luciusFernatore]

Good evening from colombia to all.

I am learning programming in c ++, and doing some exercises.

Might you check this one?.

Regards and thanks.


/*Square of Asterisks) Write a program that reads in the size
of the side of a square, then prints a hollow square of that size out
of asterisks and blanks. Your program should work for squares of
all side sizes between 1 and 20.*/

//is this program solution well solved?

#include <iostream>

using std::cout;
using std::cin;
using std::endl;

int main()
{
	

	int sizeSide;
	int column;
	int row = 2;
	int topRow = 0;
	int bottonRow = 0;
	
	
	cout << "Enter the size of the sides of a square ";
	cin >> sizeSide;
	
	//Top side.
	while (topRow < sizeSide)
	{	
		cout << "* ";
		topRow++;	
	}
	
	//Lateral sides
	while(row < sizeSide)
	{
		column = 0;
		
		cout << endl;
		
		while(column < sizeSide)
		{
			//Left side (left column)
			while(column == 0)
			{
				
				cout << "*";
				++column;
			}
			
			//Right side (Right column)
			while(column == sizeSide - 1)
			{
				
				cout << " *";
				++column;		
			}
				
			cout << "  ";
			++column;
		}
		
		++row;
	}
		
	//Bottom side
	cout << endl;
	
	if ( topRow == sizeSide)
	{
		while (bottonRow < sizeSide)
       {
	   		
			cout << "* ";
			bottonRow ++;	
	   }		
	}
	return 0;
}

[keskiverto]

Try with input: 1

Does this really have to be a loop?

while (column == 0)
{
  cout << "*";
  ++column;
}

Would if be enough?

[tpb]

You have a lot of meaningless "loops", i.e., while loops that only execute their body once.
It should be more like this.

#include <iostream>

int main()
{
    using std::cout;

    int size;
    cout << "Enter the size of the sides of a square ";
    std::cin >> size;
    
    for (int col = 0; col < size; col++)
    {
        cout << "* ";
    }        
    cout << '\n';
    
    for (int row = 1; row < size - 1; row++)
    {
        cout << "*";

        for (int col = 1; col < size - 1; col++)
        {
            cout << "  ";
        }

        cout << " *\n";
    }
        
    for (int col = 0; col < size; col++)
    {
        cout << "* ";
    }        
    cout << '\n';
}

[luciusFernatore]

thank you two , the tips i will keep it in mind. Muchas gracias,