Trouble deleting and line is skipping when asking input

[chocotaco]

I'm trying to add, display, search, modify and delete. I've gotten to the add it skips the adding of the artist. The code compiles with no errors. The delete isn't working also I was wondering if anyone could help.

  #include<fstream>
#include<iomanip>
#include <string>
#include <iostream>





using namespace std;


class Album_l
{
private:
	int x = 0;
	int num;
	int album_ID;
	int talbum;
	string album_Artist;
	string album_Genre;
	string album_Format;
	string album_Name;
	string album;

public:
	void get_Album();
	void display_Albums();
	void search_Albums();
	void delete_Album();


};

void Album_l::display_Albums()
{
 ifstream myFile;
 myFile.open("musicL.dat");
 cout << setiosflags(ios::left) << setw(10) << "Album Name"
        << setw(20) << "Album Artist" << setw(10) << "Album Genre" << setw(10) << "Album Type\n"
        << setiosflags(ios::fixed | ios::showpoint);
while(myFile)
{
	getline(myFile,album);
	cout<<album<<endl;
}	

}

void Album_l::delete_Album()
{
	ifstream myFile("musicL.dat");
	ofstream temp("temp.dat");
	
	cout<<"Enter the ID of the Album you want to delete: ";
	cin>>talbum;
	
	while(myFile>>album_ID>>album_Artist>>album_Genre>>album_Name>>album_Format)
	{
		if(talbum!=album_ID){
			temp<<album_ID<<" "<<album_Artist<<" "<<album_Genre<<" "<<album_Name<<" "<<album_Format<<endl;
		}
		if(talbum==album_ID)
		{
			x=1;
		}
	}
	myFile.clear();
	myFile.seekg(0, ios::beg);
	myFile.close();
	temp.close();
	rename("temp.dat", "musicL.dat");
	if(x==0){
		cout<<"There is no album that exists. "<<endl;
	}
	else{
		cout<<"The album has been deleted"<<endl;
	}
	
}

void Album_l::search_Albums()
{}


void Album_l::get_Album()
{
	ofstream myFile;
	myFile.open("musicL.dat", ios::app | ios::binary);
	
	cout<<"Enter Album ID"<<endl;
	cin>>album_ID; 
	cout<<"Enter the Artist"<<endl;
	getline(cin, album_Artist);
	cout<<"Enter the album_Genre";
	getline(cin, album_Genre);
	cout<<"Enter the album name";
	getline(cin,album_Name);
	cout<<"Enter the album format";
	getline(cin, album_Format);
	myFile<<setw(15)<<album_ID<<setw(15)<<album_Artist<<setw(15)<<album_Genre<<setw(15)<<album_Name<<setw(15)<<album_Format<<endl;
	myFile.close();
}

int main()
{

Album_l a;
bool notDone;
int choice;
do
{
	
cout << "\n \t\t\t 1. Add    Records";
cout << "\n \t\t\t 2. List   Records";
cout << "\n \t\t\t 3. Modify Records";
cout << "\n \t\t\t 4. Delete Records";
cout << "\n \t\t\t 5. Exit   Program";
cout << "\n\n";
cout << "\t\t\t Select Your Choice :=> ";
cin>>choice;

/* cin.ignore(256, 10); */
switch(choice)
{
case 1:
a.get_Album();
break;

case 2:
a.display_Albums();

break;

case 3:
a.search_Albums();
break;
case 4:
a.delete_Album();
break;
case 5:
cout<<"Good Bye!";
break;
default:
cout<<"Please try a valid number!";
break;

} 

}

while (choice!=5);




return 0;

}

[ne555]

a couple of question that I do hope you answer.
- ¿what does your `Album_l' class represent? ¿one album or a collection?
- all its method have the form void foo() they don't ask for a parameter and don't return a value, ¿why?
- ¿what's the purpose these member variables: `album', `talbum', `num', `x'?
- I suppose that `.getAlbum() ' is the one that adds elements, ¿why do you open the file in binary mode?
- ¿do you allow spaces or not? ¿where? an example file would help (note that your add function seems to allow, but the delete don't)
- «The delete isn't working» is not descriptive. ¿what does happen/doesn't happen? ¿musicL.dat remains untoched? ¿dissapear? ¿what about temp.dat? ¿does it still exist? ¿was even created in the first place?
- ¿do you need to open/close the file for every operation? ¿can't just load its content in a vector or something and write only at the end?

about the skipping part:
http://www.cplusplus.com/forum/beginner/250556/#msg1103311

[chocotaco]

Album_l is supposed to represent a collection of albums.

getAlbum() does add elements. The binary mode is something I should have taken out. I do allow spaces. num was just something I had just when trying to working I had from an earlier version. talbum was just an example that I was going to use to use an input when asking for deleting the album
I want to be able to delete an album when the option selection and it seems like the musicL.dat doesn't get touched but there is a temp.dat file that is created.

I was basically doing this for the deletion.

[ne555]

> Album_l is supposed to represent a collection of albums.
then your member variables make no sense.
a collection shouldn't have just one `album_Name' (¿which one of all it represents?)

> I do allow spaces
in delete_Album() you have while(myFile>>album_ID>>album_Artist>>album_Genre>>album_Name>>album_Format)
>> will stop at spaces, you need to use

myFile>>album_ID;
myFile.ignore(); //to discard the '\n'
getline(myFile, album_Artist); //and so on 

> musicL.dat doesn't get touched but there is a temp.dat file that is created.
perhaps rename() is failing

if( rename("temp.dat", "musicL.dat") == -1 )
   perror("rename ");