Compiler fail???

[GRex2595]

Can someone please compile and run this and post output for me? I don't know what's wrong and nothing I do to test this is working. I think it may be a compiler error.

#include <iostream>
#include <string>
#include <sstream>
#include <cstdlib>
#include <algorithm>
#include <ctime>

using namespace std;

class Minesweeper
{
	static const int DISPLAY = 0;
	static const int MINES = 1;
	static const int ZONES = 2;
	static const int SHOWN = 3;
public:
	Minesweeper();
	void options();
	bool play();
	int mines;
private:
	int board [24][24][4];
	int rows;
	int columns;
	void count(int, int);
	void place(int);
	void show(int []);
	bool found();
	void clear(int);
	void lose();
	bool position(string, int []);
	void zone();
	void display();
	void displayZones();
};

Minesweeper::Minesweeper()
{
	rows = 0;
	columns = 0;
	mines = 0;
	
	for(int y = 0; y < 24; y++)
	{
		for(int x = 0; x < 24; x++)
		{
			board[x][y][0] = 0;
			board[x][y][1] = 0;
			board[x][y][2] = 0;
			board[x][y][3] = 0;
		}//end for
	}//end for
}//end default constructor
void Minesweeper::options()
{
	//declare variables
	int level;
	string input;

	//get input
	cout << "Welcome to Minesweeper.\n\
Choose your difficulty level\n\
1.	Beginner\n\
2.	Intermediate\n\
3.	Expert\n\n\
Enter difficulty level now:  ";
	getline(cin, input);
	stringstream(input) >> level;
	while(level > 3 || level < 1)
	{
		cout << "Invalid input\n";
		cout << "Enter difficulty level:  ";
		getline(cin, input);
		stringstream(input) >> level;
	}//end while

	//change row and column sizes and number of mines
	switch(level)
	{
	case 1:
		rows = 9;
		columns = 9;
		mines = 10;
		break;
	case 2:
		rows = 16;
		columns = 16;
		mines = 40;
		break;
	case 3:
		rows = 24;
		columns = 24;
		mines = 99;
		break;
	default:
		cout << "Fatal error!\n";
	}//end switch

	system("cls");
}//end options
bool Minesweeper::play()
{
	//declare variables
	string input;
	char coord[3];
	int pos[2];
	char find;
	bool first = true;

	//put mines on board
	place(mines);

	//begin playing
	cout << "Enter coordinates letter followed by number\n";
	while(!found())
	{
		//display board
		display();
		cout << "Enter coordinates (exit to end):  ";
		getline(cin, input);
		transform(input.begin(), input.end(), input.begin(), tolower);

		//get coordinates
		if(!position(input, pos))
			return false;

		if(board[pos[1]][pos[0]][MINES] == 1 && first)
		{
			board[pos[1]][pos[0]][MINES] = 0;
			place(1);
		}//end if
		
		if(board[pos[1]][pos[0]][MINES] != 1)
			show(pos);
		else
		{
			lose();
			return false;
		}//end ifs
		first = false;
	}//end while

	return true;
}//end play
void Minesweeper::place(int m)
{
	//declare variables
	int placing = m;
	int max = rows * columns;

	//random seed
	srand(int(time(0)));

	if(placing == 1)
	{
		for(int y = 0; y < rows; y++)
		{
			for(int x = 0; x < columns; x++)
			{
				board[x][y][ZONES] = 0;
				board[x][y][DISPLAY] = 0;
			}//end for
		}//end for
	}

	//place mines
	while(placing > 0)
	{
		int pos = rand() % max;
		if(board[pos % columns][pos / rows][MINES] != 1)
		{
			board[pos % columns][pos / rows][MINES] = 1;
			placing--;
		}//end if
	}//end while
	
	for(int y = 0; y < rows; y++)
	{
		for(int x = 0; x < columns; x++)
		{
			count(x, y);
		}//end for
	}//end for

	zone();
}//end place
void Minesweeper::count(int xPos, int yPos)
{
	//declare variables
	int xMax;
	int xMin;
	int yMax;
	int yMin;
	int count = 0;

	//get mins and maxes
	if(xPos == 0)
	{
		xMin = 0;
		xMax = 1;
	}
	else if(xPos == columns - 1)
	{
		xMin = -1;
		xMax = 0;
	}
	else
	{
		xMin = -1;
		xMax = 1;
	}//end ifs

	if(yPos == 0)
	{
		yMin = 0;
		yMax = 1;
	}
	else if(yPos == rows - 1)
	{
		yMin = -1;
		yMax = 0;
	}
	else
	{
		yMin = -1;
		yMax = 1;
	}//end ifs

	//add mines to count
	for(int y = yMin; y < yMax; y++)
	{
		for(int x = xMin; x < xMax; x++)
		{
			count += board[xPos + x][yPos + y][MINES];
		}//end for
	}//end for

	//put count into display section
	board[xPos][yPos][DISPLAY] = count;
}//end count
void Minesweeper::zone()
{
	//declare variables
	int zone = 1;
	
	//start zoning
	for(int y = 0; y < rows; y++)
	{
		for(int x = 0; x < columns; x++)
		{
			if(board[x][y][DISPLAY] == 0)
			{
				//declare temporary variables
				int aMin;
				int aMax;
				int bMin;
				int bMax;
				int z;

				if(x == 0)
				{
					aMin = 0;
					aMax = 1;
				}
				else if(x == columns - 1)
				{
					aMin = -1;
					aMax = 0;
				}
				else
				{
					aMin = -1;
					aMax = 1;
				}//end ifs
				if(y == 0)
				{
					bMin = 0;
					bMax = 1;
				}
				else if(y == rows - 1)
				{
					bMin = -1;
					bMax = 0;
				}
				else
				{
					bMin = -1;
					bMax = 1;
				}//end ifs
				if(board[x][y][ZONES] == 0)
				{
					z = zone;
					zone++;
				}
				else
					z = board[x][y][ZONES];

				for(int b = bMin; b < bMax; b++)
				{
					for(int a = aMin; a < aMax; a++)
					{
						board[x + a][y + b][ZONES] = z;
					}//end for
				}//end for

			}//end if
		}//end for
	}//end for
}//end zone
bool Minesweeper::position(string in, int pos[])
{
	//declare variables
	char letter = 'a';
	char copy[3];

	if(in == "exit")
		return false;

	copy[2] = '~';
	in.copy(copy, 3, 0);

	pos[0] = -1;
	pos[1] = -1;

	for(int x = 0; x < rows; x++)
	{
		if(copy[0] == letter)
		{
			pos[0] = x;
			break;
		}//end if
		letter++;
	}//end for
	
	in = copy[1];
	if(copy[2] != '~')
		in += copy[2];
	stringstream(in) >> pos[1];
	pos[1]--;

	if(pos[0] == -1 || (pos[1] < 0 || pos[1] > columns))
	{
		cout << "Invalid input\n";
		cout << "Enter coordinates (exit to end):  ";
		getline(cin, in);
		transform(in.begin(), in.end(), in.begin(), tolower);
		return position(in, pos);
	}//end if
	
	return true;
}//end pos
void Minesweeper::show(int co[])
{
	board[co[1]][co[0]][SHOWN] = 1;
	if(board[co[1]][co[0]][DISPLAY] == 0)
	{
		clear(board[co[1]][co[0]][ZONES]);
	}//end if
}//end show
void Minesweeper::clear(int zone)
{
	for(int y = 0; y < rows; y++)
	{
		for(int x = 0; x < columns; x++)
		{
			if(board[x][y][ZONES] == zone)
				board[x][y][SHOWN] = 1;
				//end if
		}//end for
	}//end for
}//end clear
void Minesweeper::display()
{
	//declare variables
	char letter = 'a';

	//clear screen
	system("cls");

	//test zoning
	displayZones();

	//display board
	for(int y = 0; y < rows; y++)
	{
		cout << letter << "  |";
		for(int x = 0; x < columns; x++)
		{
			cout << " ";
			if(board[x][y][SHOWN] == 1)
			{
				if(board[x][y][DISPLAY] == 0)
					cout << " ";
				else
					cout << board[x][y][DISPLAY];
			}//end if
			else
				cout << "#";
			cout << " |";
		}//end for
		cout << endl;
		letter++;
	}//end for

	cout << endl << "   |";
	for(int x = 1; x <= columns; x++)
	{
		cout << " " << x << " |";
	}
	cout << endl;
}//end display
void Minesweeper::lose()
{
	//clear screen
	system("cls");

	//display board
	for(int y = 0; y < rows; y++)
	{
		cout << "|";
		for(int x = 0; x < columns; x++)
		{
			cout << " ";
				if(board[x][y][MINES] == 1)
					cout << "b";
				else if(board[x][y][SHOWN] == 1)
				{
					if(board[x][y][DISPLAY] == 0)
						cout << " ";
					else
						cout << board[x][y][DISPLAY];
				}
				else
					cout << "#";
			cout << " |";
		}//end for
		cout << endl;
	}//end for
	cout << endl << "You lose\n";
}//end lose
bool Minesweeper::found()
{
	for(int y = 0; y < rows; y++)
	{
		for(int x = 0; x < columns; x++)
		{
			if(board[x][y][MINES] == 0 && board[x][y][SHOWN] == 0)
				return false;
		}//end for
	}//end for

	return true;
}//end found
void Minesweeper::displayZones()
{
	for(int y = 0; y < rows; y++)
	{
		cout << "|";
		for(int x = 0; x < columns; x++)
		{
			cout << " ";
			cout << board[x][y][ZONES];
			cout << " |";
		}//end for
		cout << endl;
	}//end for
}//end displayZones
int main()
{
	//declare objects
	Minesweeper game;

	//play game
	game.options();
	if(game.play())
	{
		cout << "You found all " << game.mines << " mines.\n";
		cout << "You Win!!!\n";
	}
	cout << "Thanks for playing\n";

	system("pause");

return 0;
}//end main 

[cire]

			for(int b = bMin; b < bMax; b++)
				{
					for(int a = aMin; a < aMax; a++)
					{
						board[x + a][y + b][ZONES] = z;
					}//end for
				}//end for 

What happens to row 0 when y = 1?

[GRex2595]

You know in Minesweeper when you click an area of zeroes and it clears everything until it hits numbers? This code makes sure that the object can clear all of those zeroes by putting them into specific zones. Therefore if board[x][1][DISPLAY] == 0 the code will first check to see if there is a zone that that zero is already part of, then put either that zone or the next zone into all of the surrounding cells' zone section of the array.

In other words

a |1|1|1|
b |1|0|0|
c |1|0|0|
   1 2 3

At the beginning, b1's zone is already zero, so it takes what's in my zone variable and puts it in a1-c3. When I have to clear this section, it will show all nine of these cells plus whatever other cells are a part of this zone. When the program goes to check b3's zone, it should pass all the cells around it the number of zone that it's in, which is b2's zone.

[cire]

I wasn't asking what the code is intended to accomplish in general. I was asking a very specific question, because the answer to that question is why you're getting the behavior you're getting.

Edit: And it doesn't look like zone() is actually doing what you want it too.

[GRex2595]

I know what went wrong now. I forgot two equals signs. It's fixed now and runs perfectly. Too bad I went and reinstalled my compiler anyways. Thanks for the help.

[GRex2595]

New problems with this code.

Problems start in zone method.

void Minesweeper::zone()
{
	//declare variables
	int zone = 1;

	//start zoning
	for(int y = 0; y < rows; y++)
	{
		for(int x = 0; x < columns; x++)
		{
			if(board[x][y][DISPLAY] == 0 && board[x][y][ZONES] == 0)  //I've decided this is where problems start
			{
				board[x][y][ZONES] = zone;
				search(x, y, zone);
				zone++;  //should not skip numbers, but is
			}//end if
		}//end for
	}//end for

	//zone non-zeroes
	for(int y = 0; y < rows; y++)
	{
		for(int x = 0; x < columns; x++)
		{
			if(board[x][y][DISPLAY] == 0)
			{
				//declare temps
				int aMin;
				int aMax;
				int bMin;
				int bMax;

				if(x == 0)
				{
					aMin = 0;
					aMax = 1;
				}
				else if(x == columns - 1)
				{
					aMin = -1;
					aMax = 0;
				}
				else
				{
					aMin = -1;
					aMax = 1;
				}//end ifs
				if(y == 0)
				{
					bMin = 0;
					bMax = 1;
				}
				else if(y == rows - 1)
				{
					bMin = -1;
					bMax = 0;
				}
				else
				{
					bMin = -1;
					bMax = 1;
				}//end ifs
				zone = board[x][y][ZONES];

				for(int b = bMin; b <= bMax; b++)
				{
					for(int a = aMin; a <= aMax; a++)
					{
                                                //this section of code works, but can randomly do something else sometimes
						stringstream z;
						stringstream find;
						z << board[a + x][b + y][ZONES];
						find << zone;
						if(int(z.str().find(find.str(), 0)) < 0 && board[a + x][b + y][DISPLAY] != 0)
						{
							board[a + x][b + y][ZONES] *= 10;
							board[a + x][b + y][ZONES] += zone;
						}
						else
							board[a + x][b + y][ZONES] = zone;
						//end ifs
						z.str("");
						find.str("");
					}//end for
				}//end for
			}//end if
		}//end for
	}//end for
}//end zone
void Minesweeper::search(int xPos, int yPos, int z)  //search should allow code to find all adjacent zeroes
{
	//declare variables
	int xMin;
	int xMax;
	int yMin;
	int yMax;

	//get mins and maxes
	if(xPos == 0)
	{
		xMin = 0;
		xMax = 1;
	}
	else if(xPos == columns - 1)
	{
		xMin = -1;
		xMax = 0;
	}
	else
	{
		xMin = -1;
		xMax = 1;
	}//end ifs
	//get mins and maxes
	if(yPos == 0)
	{
		yMin = 0;
		yMax = 1;
	}
	else if(yPos == rows - 1)
	{
		yMin = -1;
		yMax = 0;
	}
	else
	{
		yMin = -1;
		yMax = 1;
	}//end ifs

	for(int y = yMin; y <= yMax; y++)
	{
		for(int x = xMin; x <= xMax; x++)
		{
			if(board[xPos + x][yPos + y][DISPLAY] == 0 && board[xPos + x][yPos + y][ZONES] == 0)
			{
				board[xPos + x][yPos + y][ZONES] = z;  //prevent search from re-evaluating this cell
				search(x, y, z);
			}//end if
		}//end for
	}//end for
}//end search 

My clear method works, but what happens in the zone method has been affecting the clear method as well.

void Minesweeper::clear(int zone)
{
	for(int y = 0; y < rows; y++)
	{
		for(int x = 0; x < columns; x++)
		{
			stringstream z;
			stringstream find;
			z << board[x][y][ZONES];
			find << zone;
			if(int(z.str().find(find.str(), 0)) >= 0)
				board[x][y][SHOWN] = 1;
				//end if
			z.str("");
			find.str("");
		}//end for
	}//end for
}//end clear