a question about rational class

[alirah84]

hi,
I wrote this code about sum,subtraction,divided,multiple of fraction numbers.but when I enter 4 numbers it shows only number 2011 .plz tell me where is problem?
Tanx

#include <iostream>
 
using namespace std;
class rational
{
public:
        int a,b,c,d;
    int plus (int ,int ,int ,int );
        int subtraction (int ,int ,int ,int );
            int multiple (int ,int ,int ,int );
                int divided (int ,int ,int ,int );
void printnumbers ();

};
                int rational :: plus(int a,int b,int c,int d)
                {
                    return a/b +c/d;
                }
                int rational :: subtraction(int a,int b,int c,int d)
                {
                    return a/b - c/d;
                }
                int rational :: multiple(int a,int b,int c,int d)
                    {
                        return (a/b) * (c/d);
                }
                int rational :: divided(int a,int b,int c,int d)
                {
                    return (a/b) / (c/d);
                }
                void rational :: printnumbers () 
                {
                    cout<< (a/b) +(c/d);
                        cout<< (a/b) -( c/d);
                            cout<< (a/b) * (c/d);
                                cout<< (a/b) / (c/d);
                                }
                
                int main()
                {
                    int a,b,c,d;
                cin>>a>>b>>c>>d;
                rational p;
                p.plus(a,b,c,d);
                p.subtraction(a,b,c,d);
                p.multiple(a,b,c,d);
                    p.divided(a,b,c,d);
p.printnumbers () ;
                }

[alirah84]

nobody doesn't see my post?plz help me.

[Peter87]

If you want to have space between the numbers you have to output space.
cout << ' ';

[alirah84]

ok,you're right but when I enter any numbers as input It shows only number 2012 in output.It should give 4 numbers as output but gives only 2012

[Lowest0ne]

Your rational class is confused in it's functions: "Should I use the a,b,c,d that were passed to the function, or the a,b,c,d that I own?". You never assign anything to rational's a,b,c,d so that is probably why you get some junk.

Quick fix, make a constructor and remove the function arguments:

class rational
{
public:
  int a,b,c,d;
  
  //constructor
  rational(int a, int b, int, c, int d);

  int plus (void);
  // other functions
};
rational::rational(int a, int b, int c, int d)
{
  this->a = a;
  this->b = b;
  this->c = c;
  this->d = d;
}

int rational :: plus(void)
{
  return a/b +c/d;
}

int main(void)
{
  rational myrational(1,2,3,4);
  myrational.print();
}

[TheIdeasMan]

The use of ints won't work very well for this - if the user entered 1,2, 3, 4 then then answer for the plus function would 0.

If you want a floating point answer, make the types double.

However you can do it with ints by using cross multiplying to get the answer. This is the mathematical way of doing things. Might also need GCD to reduce the fraction.

[alirah84]

why should rational class has constructor function?(we don't want assign value to numbers). we get 4 numbers(with cin in int main) and they are passed to function arguments . Is it right? Is this program written without constructor function?

[alirah84]

Is this program written without constructor function?

[Lowest0ne]

I provided a quick fix to a problem. You don't need a constructor, but then if you want printnumbers(void) you need to assign a,b,c,d to rational's a,b,c,d for every operation.