issues with scope, among other things

[jamesfalter]

for every method in my cpp file for a simple stack postfix calculator, the compiler returns the error that the stack I am using is 'not declared in this scope'. could someone please help me? the code is below.

#include <iostream>
#include <stack>
#include <cmath>
#include "postfixCalculator.h"
using namespace std;
postfixCalculator() {
  s=new stack();
}
void add(){
  if(!(s.empty())){
    int a=s.top();
    s.pop();
    int b=s.top();
    s.pop();
    int c=a+b;
    s.push(c);
  }
}
void subtract(){
  if(!(s.empty())){
    int a=s.top();
    s.pop();
    int b=s.top();
    s.pop();
    int c=a-b;
    s.push(c);
  }
}
void multiply(){
  if(!(s.empty())){
    int a=s.top();
    s.pop();
    int b=s.top();
    s.pop();
    int c=a*b;
    s.push(c);
  }
}
void divide(){
  if(!(s.empty())){
    int a=s.top();
    s.pop();
    int b=s.top();
    s.pop();
    int c=a/b;
    s.push(c);
  }
}
void addNum(int x){
    s.push(x);
  }
int getTopNum(){
    return s.top();
  }
header file//////////////////////////////////////////////////////////////////
#include <iostream>
#include <stack>
using namespace std;

class postfixCalculator {
 public:
  postfixCalculator();
  void add();
  void subtract();
  void multiply();
  void divide();
  void addNum(int);
  int getTopNum()
  private:
 stack <int> s;
};


test method///////////////////////////////////////////////////////////////////
#include <iostream>
#include "postfixCalculator.cpp"
#include <cmath>
using namespace std;
int main() {
  postfixCalculator p;
	p.addNum (1);
	p.addNum (2);
	p.addNum (3);
	p.addNum (4);
	p.addNum (5);
	p.add();
	p.add();
	p.add();
	p.add();
	cout << "Result is: " << p.getTopNum() << endl;
	return 0;
}

any help would be appreciated.

[snow 56767]

please edit your question using code tags (hint: it is the button that looks like <>)

[Lynx876]

Yeah. No offense to the OP, it being your first post and all. But I've given up reading code without the tags. (:

[Chervil]

Maybe I missed something, I can't see the contents of the header file "postfixCalculator.h"

[jamesfalter]

noob first post mistakes fixed.

[snow 56767]

Alrighty, thank you :D

Try including "postfixCalculator.h" instead of "postfixCalculator.cpp"

[jamesfalter]

well, that certainly stopped the errors from doubling up, but it doesn’t solve the problem entirely.
here is the error log,since its no longer enormous.

In file included from postfixCalculator.cpp:4:0:
postfixCalculator.h:13:17: error: expected ‘;’ at end of member declaration
postfixCalculator.cpp:6:19: error: expected unqualified-id before ‘)’ token
postfixCalculator.cpp: In function ‘void add()’:
postfixCalculator.cpp:10:8: error: ‘s’ was not declared in this scope
postfixCalculator.cpp: In function ‘void subtract()’:
postfixCalculator.cpp:20:8: error: ‘s’ was not declared in this scope
postfixCalculator.cpp: In function ‘void multiply()’:
postfixCalculator.cpp:30:8: error: ‘s’ was not declared in this scope
postfixCalculator.cpp: In function ‘void divide()’:
postfixCalculator.cpp:40:8: error: ‘s’ was not declared in this scope
postfixCalculator.cpp: In function ‘void addNum(int)’:
postfixCalculator.cpp:50:5: error: ‘s’ was not declared in this scope
postfixCalculator.cpp: In function ‘int getTopNum()’:
postfixCalculator.cpp:53:12: error: ‘s’ was not declared in this scope
In file included from testPostfixCalc.cpp:2:0:
postfixCalculator.h:13:17: error: expected ‘;’ at end of member declaration

[LB]

All your functions are just functions in the global scope, they are not member functions. You need to scope them to let the compiler know that they are defining member functions, like in this example:

struct SomeClass
{
    SomeClass();
    ~SomeClass();

   int SomeMemberFunction(int x, int y);
};

SomeClass::SomeClass()
{
}
SomeClass::~SomeClass()
{
}

int SomeClass::SomeMemberFunction(int x, int y)
{
    return x+y;
}

This is also described below by BlackSheep:

[BlackSheep]

You need to let the compiler know that the functions add, subtract etc. belong to the class postfixCalculator:

void postfixCalculator::add() //Prefix postfixCalculator:: to the function definitions
{
//Code
}

[jamesfalter]

okay, that helped a lot. down to just three things in the error log....

In file included from postfixCalculator.cpp:4:0:
postfixCalculator.h:13:17: error: expected ‘;’ at end of member declaration
postfixCalculator.cpp:6:19: error: expected unqualified-id before ‘)’ token
In file included from testPostfixCalc.cpp:2:0:
postfixCalculator.h:13:17: error: expected ‘;’ at end of member declaration

]
unfortunately, I have no idea what these things mean. Does this also have to do with scope?

[BlackSheep]

You forgot a semi-colon after the declaration of getTopNum().
Also, stack isn't dynamic, so you don't need to call s = new stack() (and you're not allowed to) in your constructor.

[3qX21hU5]

Your missing ; after your member functions. Compiler errors can be a pain to understand and reconize when your just starting. One thing that helped me was to program something that I knew worked withouterrors like the hello world program then start removing things or changing them to see what kind of errors I got. Since you k ow what you changed you know what the error message means so eventually you start to understand them better. Hope that helps and sorry for the typos on my phone

[jamesfalter]

are you referring to the header file when you say declaration?

[BlackSheep]

Yupperdoodle.
Declaration is when you "declare" a function without providing a body:

int function(int a);

Definition is when you actually define the function's body.

[jamesfalter]

and, error free! thanks, internet!