Function calling problem

[FaffyWaffle]

I have been working on this program, and for some reason I cannot connect my BoxDimensions function to my DisplayData function. What would need to be done and how would I to that because I am all out of resources. I'm thinking i should have used a function call but i don't know how to do it properly.

#include<iostream>
#include<iomanip>
using namespace std;

void DisplayData (double length, double width, double height, double volume, double area);

void BoxDimensions (double length, double width, double height, double volume);



int main()
{
	//variable declaration
	double width, length, height, volume;
	char repeat='y';

	//user instructions
	cout<<"This program will accept four inputs."<<endl;
	cout<<"For the measurement you would like too find, "<<endl;
	cout<<"please enter 0."<<endl<<endl;


	do//do-while 
	{

		//intro input
		cout<<"Please enter the width of your box: ";
		cin>>width;
		cout<<"Please enter the length of your box: ";
		cin>>length;
		cout<<"Please enter the height of your box: ";
		cin>>height;
		cout<<"Please enter the volume of your box: ";
		cin>>volume;

		DisplayData (length, width, height, area, volume);
		BoxDimensions (length, width, height, volume);
		

			//rerun the program
		cout<<"Enter y or Y to rerun the program, anything else to quit ";
		cin>>repeat;
	}while (repeat=='y'||repeat=='Y');//end do-while

}//end main

void BoxDimensions(double &length, double &width, double &height, double &volume)

{
//start if-else
		if(volume==0)
		{
		volume=width*length*height;
		}
		else if(width==0)
		{
		width=volume/(height*length);
		}
		else if(length==0)
		{
		length=volume/(height*width);
		}
		else if(height==0)
		{
		height=volume/(length*width);
		}//end else if


void DisplayData(double length, double width, double height, double area, double volume);
{
	//set precision
	cout.setf(ios::fixed, ios::floatfield);
	cout.setf(ios::showpoint);
	cout<<setprecision(2);

	cout<<"The width of your box is "<<setw(21)<<width<<endl;
	cout<<"The length of your box is "<<setw(20)<<length<<endl;
	cout<<"The height of your box is "<<setw(20)<<height<<endl;
	cout<<"The volume of your box is "<<setw(20)<<volume<<endl;
	cout<<"The area of your box is "<<setw(20)<<area<<endl;
	
	
}//end Displaydata 

[aprendiz]

void BoxDimensions(double &length, double &width, double &height, double &volume)

Dont use address of these variable. Just remove &.

void DisplayData(double length, double width, double height, double area, double volume);

A semicolon after function definition?

[FaffyWaffle]

I removed the & and that solved some of the problems. Also added a } after the final else-if. Still wont link the 2 functions though

[aprendiz]

#include<iostream>
#include<iomanip>
using namespace std;

void DisplayData (double length, double width, double height, double volume, double area);

void BoxDimensions (double length, double width, double height, double volume);



int main()
{
	//variable declaration
	double width, length, height, volume, area;
	char repeat='y';

	//user instructions
	cout<<"This program will accept four inputs."<<endl;
	cout<<"For the measurement you would like too find, "<<endl;
	cout<<"please enter 0."<<endl<<endl;


	do//do-while 
	{

		//intro input
		cout<<"Please enter the width of your box: ";
		cin>>width;
		cout<<"Please enter the length of your box: ";
		cin>>length;
		cout<<"Please enter the height of your box: ";
		cin>>height;
		cout<<"Please enter the volume of your box: ";
		cin>>volume;
		BoxDimensions (length, width, height, volume);
		DisplayData (length, width, height, volume, area);
			//rerun the program
		cout<<"Enter y or Y to rerun the program, anything else to quit ";
		cin>>repeat;
	}while (repeat=='y'||repeat=='Y');//end do-while
	return 0;
}//end main

void BoxDimensions(double length, double width, double height, double volume)
{
//start if-else
		if(volume == 0)
		{
			volume=width*length*height;
		}
		else if(width == 0)
		{
			width=volume/(height*length);
		}
		else if(length == 0)
		{
			length=volume/(height*width);
		}
		else if(height == 0)
		{
			height = volume/(length*width);
		}//end else if
		else
			cout<<"\n";
}

void DisplayData(double length, double width, double height, double area, double volume)
{
	//set precision
	cout.setf(ios::fixed, ios::floatfield);
	cout.setf(ios::showpoint);
	cout<<setprecision(2);

	cout<<"The width of your box is "<<setw(21)<<width<<endl;
	cout<<"The length of your box is "<<setw(20)<<length<<endl;
	cout<<"The height of your box is "<<setw(20)<<height<<endl;
	cout<<"The volume of your box is "<<setw(20)<<volume<<endl;
	cout<<"The area of your box is "<<setw(20)<<area<<endl;
}//end Displaydata  

Is it your desired result?

[FaffyWaffle]

Yes it was thank you very much

[Chervil]

I thought the intention of the function BoxDimensions was to calculate the missing value (whichever was input with a value of zero).

In order to achieve that, the parameters must be passed by reference (using &).

There are a couple of other flaws. The parameters are passed according to their position. The function DisplayData has its parameters listed in a different order in the call at line 36 and the definition at line 67.

Also area is not initialised, though I think possibly calculation of the area is still to be done. In the meantime, I would set it to zero.

See this tutorial for how to pass parameters by reference:
http://www.cplusplus.com/doc/tutorial/functions2/