"moving strings"

[thefatshizms]

Hello, been trying to get this code to work, it's supposed to move the '@' sign up and down with the arrow keys, when in fact it does nothing.

char Map[10][30] =
{
    {"###################"},
    {"#                 #"},
    {"#                 #"},
    {"#                 #"},
    {"#                 #"},
    {"#@                #"},
    {"###################"}

};

bool GameStoped = false;

int main()
{
    //pointers();

    while(GameStoped == false) {

        system("cls");
        for(int i = 0; i < 10; ++i) {
            cout << Map[i] << endl;
        }break;

        for(int y = 0; y < 10; ++y) {
            for(int j = 0; j < 10; ++j) {
                switch(Map[y][j]) {
                    case '@':
                    {
                        if(GetAsyncKeyState(VK_UP) != 0) {

                            int y2 = (y-1);

                            switch(Map[y2][j]) {
                                case ' ':
                                {
                                    Map[y][j] = ' ';
                                    y-=1;
                                    Map[y2][j] = '@';
                                }break;
                            }
                        }

                        if(GetAsyncKeyState(VK_DOWN) != 0) {
                            int y2 = (y+1);

                            switch(Map[y2][j]) {
                                case ' ':
                                {
                                    Map[y][j] = ' ';
                                    y+=1;
                                    Map[y2][j] = '@';
                                }break;
                            }
                        }
                    }break;
                } Sleep(10000);
            }

        }
    }
    cin.get();
    return 0;
}

[thefatshizms]

Bump. You don't have to re write/correct the code, I only require a reason why it's not working.

[coder777]

It's not working due to the break; on line 24

[writetonsharma]

reply clashed.

[thefatshizms]

Ok thanks, the reason why I added that break was because it was basically loading the map constantly and flickering (really annoying) How can I solve this? Maybe a bool saying if the map is loaded?

EDIT: tried this:

if(MapLoaded == false) {
        	for(int i = 0; i < 10; ++i) {
        		cout << Map[i] << endl;
        	}
			MapLoaded = true;	
        }

But then the map doesn't load at all.

[coder777]

Maybe a bool saying if the map is loaded?

No, a bool that says map_changed (or so).

Set it initially to true and then when you indeed change it (like after GetAsyncKeyState()):

        if(map_changed)
        {
            system("cls");
            for(int i = 0; i < 10; ++i) {
                cout << Map[i] << endl;
            }break;
        }

[thefatshizms]

I've used your idea, but it's still flickers :/

this is the code(note, I haven't changed the name as of this moment. I wanted to see if works first.)

if(MapLoaded == true) {
			system("cls");
        	for(int i = 0; i < 10; ++i) {
        		cout << Map[i] << endl;
        	}
        	//MapLoaded = false;
			
        }

I first tried putting it to false (it's finished updating) then setting it to true in the key detection but that didn't work.

I know what's doing .. it's obviously the loop (while)

[coder777]

yes sorry, I forgot line 6. It is required so remove the comments.

Set it to true after Map[y2][j] = '@';

[thefatshizms]

That's what i'm doing :/ It very annoying with the flickering.

This is how it is in my code:

if(MapLoaded == true) {
			system("cls");
        	for(int i = 0; i < 10; ++i) {
        		cout << Map[i] << endl;
        	}
        	MapLoaded = false;
			
        }

After button detect:

case ' ':
                                {
                                    Map[y][j] = ' ';
                                    y-=1;
                                    Map[y2][j] = '@';
                                    MapLoaded = true;
                                }break;

[writetonsharma]

this is because you are painting the whole screen. If you can device a trick to just change specific characters on the screen then you would be good.