insertion sort problem

[mahmoud2592]

the problem here is at " insertionSort in_sort[9]; "
error:no matching function for call to "insertionSort::insertionSort()"
what is the solution for that ?

#include <vector>
#include <iostream>
#include <algorithm>
using namespace std;
/* Head ends here */

class insertionSort{
private:
     int temp ;
   int i,j,k,x;
public:
        insertionSort(vector <int>  ar) {

for(i = 1;i<ar.size();i++)
{
    for(j = 0;j<i;j++)
    {

        if(ar[i]<ar[j])
        {
            temp = ar[i];
            for(k = i;k>=j;k--)
            {
                ar[k] = ar[k-1];

                if(ar[k-1]<temp&&ar[k+1]>temp)
                {
                    ar[j] = temp;

                }
                }

            }
            }
            for(j = 0;j<=ar.size()-1 ;j++)
        {
            cout<<ar[j]<<" ";
        }
        cout<< endl;

        }

}
};

/* Tail starts here */
int main(void) {
 insertionSort in_sort[9];
}

[MikeyBoy]

Look at the way you've defined your constructor for insertionSort:

insertionSort(vector <int> ar)

When you create objects of that class, you need to pass in a vector as the argument to the constructor.

[abhishekm71]

insertionSort in_sort[9];

Here you are just trying to create an array of 9 objects of class insertionSort. You are not providing the vector of int needed by the constructor.

Try,

std::vector<int> myVec( 9 );
insertSort in_sort( myVec );

[mahmoud2592]

line 49:error expected at ";" before "in_sort"
what is the solu ?

#include <vector>
#include <iostream>
#include <algorithm>
using namespace std;
/* Head ends here */

class insertionSort{
private:
     int temp ;
   int i,j,k,x;
public:
        insertionSort(vector <int>  ar) {

for(i = 1;i<ar.size();i++)
{
    for(j = 0;j<i;j++)
    {

        if(ar[i]<ar[j])
        {
            temp = ar[i];
            for(k = i;k>=j;k--)
            {
                ar[k] = ar[k-1];

                if(ar[k-1]<temp&&ar[k+1]>temp)
                {
                    ar[j] = temp;

                }
                }

            }
            }
            for(j = 0;j<=ar.size()-1 ;j++)
        {
            cout<<ar[j]<<" ";
        }
        cout<< endl;

        }

}
};

/* Tail starts here */
int main(void) {
 std::vector<int> myVec(9);
insertSort in_sort(myVec);
}

[MikeyBoy]

You've made a typo. Your class name is insertionSort, not insertSort.

[mahmoud2592]

thanks man :)

[vlad from moscow]

However in any case your code is invalid. Consider the loop

            for(k = i;k>=j;k--)
            {
                ar[k] = ar[k-1];

Let assume that j is equal to 0. In this case for k == j you will try to execute

ar[0] = ar[0-1];

[Hzj jie]

p.s.
insertionSort(vector <int> ar) {
to
insertionSort(vector <int>& ar) {
you will have a better perf, and make the class meaningful, otherwise, you do not have any output...

[andywestken]

You should watch the video here
http://en.wikipedia.org/wiki/Insertion_sort

and then adjust your function accordingly.

(You have one loop more than you need.)

Andy

PS All you member variables look like they should be locals; apart from x, which isn't used at all.