Weird compilation error

[harook]

G++ has been kind of trolling me with this huge error report. But I'm totally unable to exatract any information out of it. It would be gread if you could help me.

The error report:

http://pastebin.com/aQpc4hFs 

The code itself:

#include <iostream>

#include "Calendar.h"
#include "Transaction.h"

using namespace std;

int main() {
	
	Calendar *calendar = new Calendar();
	calendar->init(0, 300);
	calendar->push(0,1, new Transaction(calendar));
	calendar->run();
}

----------CALENDAR.H----------

#include <iostream>
#include <queue>

using namespace std;

class Transaction;

struct activationRecord {

	double time;
	int priority;
	Transaction *transaction;
};

class Calendar {

	private:
		double timeStop;
		double time;
		priority_queue<activationRecord> activationCalendar;

	public:
		bool isEmpty();
		void push(double, int, Transaction*);
		void pop();
		void run();
		void init(double, double);

		double getTime();

		activationRecord top();
};

----------CALENDAR.CPP----------

#include <iostream>

#include "Calendar.h"
#include "Transaction.h"

using namespace std;

bool Calendar::isEmpty() {

	return activationCalendar.empty();
}

void Calendar::pop() {

	activationCalendar.pop();
}

void Calendar::push(double t, int p, Transaction *tr) {

	activationRecord r;

	r.priority = p;
	r.time = t;
	r.transaction = tr;

	activationCalendar.push(r);
}

activationRecord Calendar::top() {

	return activationCalendar.top();
}

void Calendar::run() {
	
	activationRecord r;


	while(!activationCalendar.empty()) {


		r = activationCalendar.top();
		activationCalendar.pop();


		if(r.time > timeStop) {
			time = timeStop;
			break;
		}

		//Posun cas na cas aktualniho eventu
		time = r.time;

		cout << "Time: " << time << " ";

		//Vykonej event
		(*r.transaction).choose();
	}
}


void Calendar::init(double start, double stop) {

	 time = start;
	 timeStop = stop;
}

double Calendar::getTime() {

	return time;
}


bool operator <(const activationRecord & a, const activationRecord & b)
{
    return a.time > b.time;
}

----------TRANSACTION.H----------

#include <iostream>

using namespace std;

class Calendar;

class Transaction {

	private:
		int chooser;
		Calendar *cal;

	public:
		Transaction(Calendar*);
		~Transaction();

		void choose();
		void event1();
		void event2();
		void event3();
		void event4();
};
----------TRANSACTION.CPP----------

#include <iostream>

#include "Transaction.h"
#include "Calendar.h"

using namespace std;


Transaction::Transaction(Calendar *c) {

	this->cal = c;
	this->chooser = 1;
}

void Transaction::choose() {

	switch(chooser){
		case(1):
			event1();
			break;
		case(2):
			event2();
			break;
		case(3):
			event3();
			break;
		case(4):
			event4();
			break;
	}
}


void Transaction::event1() {

	cout << "Event1::Transakce" << this << endl;

	chooser = 2;


	cal->push(cal->getTime()+200, 1, new Transaction(cal));


	cal->push(cal->getTime(), 1, this);
}

void Transaction::event2() {

	cout << "Event2::Transakce" << this << endl;

	chooser = 3;

	cal->push(cal->getTime()+50, 1, this);
}

void Transaction::event3() {

	cout << "Event3::Transakce" << this << endl;

	chooser = 4;

	cal->push(cal->getTime(), 1, this);

}

void Transaction::event4() {

	cout << "Event4::Transakce" << this << endl;

}

Ty for any help

[ne555]

make 2>&1 | grep error
/usr/include/c++/4.8.2/bits/stl_function.h:235:20: error: no match for ‘operator<’ (operand types are ‘const activationRecord’ and ‘const activationRecord’)

main.cpp ignores the existence of the bool operator <(const activationRecord & a, const activationRecord & b) function.
Declare it in a header file.

Also, use header guards http://www.cplusplus.com/forum/articles/10627/
Don't using in headers
And stop leaking memory.

[harook]

Thank you for you reply ne555,

problem is when I try to declare it in as private method of Calendar in Calendar.h (like this)

bool operator < (const activationRecord, const activationRecord);

I get this error

binary 'operator <' has too many parameters

Any ideas?

[ne555]

You define it as a global function, declare it as a global function.


> when I try to declare it in as private method of Calendar
If it is private nobody could access it
If it is a method then the prototype should be bool operator < (const activationRecord) const; (remember that the calling object is passed as this)
If the function refers to `activationRecord' objects, then it should be a member of `activationRecord' no of `Calendar'

[harook]

I followed you advice which seems reasonable to me. It led to huge decrease of errors I got, nevertheless there is still a report I can't resolve.

I tried defining the operator method like this:

bool activationRecord::operator <(const activationRecord & a, const activationRecord & b) {
return a.time > b.time;
}

Btw. It's declaration

struct activationRecord {

	double time;
	int priority;
	Transaction *transaction;
	bool operator < (const activationRecord) const;
};

The new, only one row error I'm getting is obvisouly this:

Calendar.cpp:84:89: error: ‘bool activationRecord::operator<(const activationRecord&, const activationRecord&)’ must take exactly one argument
make: *** [Calendar.o] Error 1

And one more thing I don't understand. You mentioned I should not use "using namespace std;" in header file. But I kind on need it there, because I cant define a priority queue there otherwise. Am I getting it wrong.

Thank You,

you've been very helpful.

[ne555]

¿why is your definition different than your declaration?
I don't realize how the compiler could make it clearer: `must take exactly one argument'

struct activationRecord {

	double time;
	int priority;
	Transaction *transaction;
	bool operator < (const activationRecord &) const; //declaration (one argument)
};

bool activationRecord::operator <(const activationRecord & b) const{ //definition (one argument)
   return this->time > b.time;
}

> I should not use "using namespace std;" in header file.
> But I kind on need it there, because I cant define a priority queue there otherwise.
std::priority_queue

[harook]

Im so stupid, thank You so much. I just couldnt solve how to define the operator using just one parameter, i didn't make sense to me. Now I got it.