i'm trying to write a program that gives diamond shape.

[amar27]

hey guys I am pretty new to the c++. I wrote this program which should ask me to input the diamond width and lateral offset and it should then produce a diamond shape.
its asking for the diamond width and lateral offset, but its not producing the diamond shape instead its giving me a whole bunch of lines. can someone please correct this code to help produce a diamond shape. thank you.

#include <iostream>

using namespace std;


void a( void );
void s( void );
void n( void );
void pyramid(int,int);
void wedge(int,int);


void a() {cout << "*";}
void s() {cout << " ";}
void n() {cout << "\n";}

void pyramid (int width, int offset)
{
    int count1, count2;
    for (int j=1; j < width; j += 2)
    {
        for (int i = 0; i < offset; i++) a();
        count2 = j;
        count1 = (width - count2)/2;

 {
            for (int i = 0; i < count1; i++) a();
            for (int i = 0; i < count2; i++) s();
            for (int i = 0; i < count1; i++) n();
            }
            }
        n();
    }


void wedge(int width, int offset)
{
    for (int j = 0; j < width; j++)
    {
        for (int i = 0; i < offset; i++) a();

{
            for (int i = 0; i < 1; i++) a();
            for (int i = 0; i < j; i++) s();
            for (int i = 0; i < width - j - 1; i++) n();

        }
        }
        cout << endl;
    }




int main()
{
    int colWidth, latOffset;

    cout << "This is a program for outputting a diamond formation.\n";
    cout << "First you must select an odd number diamond width.\n";
    cout << "Then you must select a lateral offset even or odd.\n";
    cout << " Input diamond width: ";
    cin >> colWidth;

    if (colWidth % 2 == 0)
    {
        cout << "ERROR: You entered an even number.\nThe program is correcting your error\n";
        colWidth +=1;
    }
    cout << "Input lateral offset: ";
    cin >> latOffset;
    cout << "\n";

    pyramid (colWidth, latOffset);
    wedge (colWidth, latOffset);



    cout << "\nAuthor: Amar" << endl;
    cin.get();
    cin.get();
    return 0;
}

[Vibgyor]

Hey pal!

Here is my code for diamond output

#include <iostream.h>
#include <conio.h>
#include<iomanip.h>
void main()
{
clrscr();
float col,row,side;
cout<<"Enter the size: ";cin>>side;
for(col=side;col>=1;col--)
{ for(row=1;row<=col;row++)
  cout<<" ";
  cout<<"*";
  for(row=side-1;row>=col;row-=0.5)
  cout<<" ";
  if(col==side)
  cout<<'\n';
  else
  cout<<"*\n";
}
for(col=side;col>=1;col--)
{ for(row=side;row>col;row--)
  { if(row==0)
    break;
    else
    cout<<" ";
  }
  cout<<"*";
  for(row=1.5;row<=col+0.5;row+=0.5)
  cout<<" ";
  if(col==1)
  cout<<"*\n"<<setw(side+1)<<"*";
  else
  cout<<"*\n";
}
cout<<"\n\n";
getch();
}

Mine asks you one input but your's is designed to ask for two, I don't get why lateral offset is being asked. Please explain me it's working so that I can help......

[keskiverto]

its giving me a whole bunch of lines.

Explain lines 29 and 45.

[amar27]

Hey keskiverto,

That part has been the main problem for me, I wrote a part this code while my professor was explaining a code for triangle as an example for this homework he gave us. After that I tried to improvise it so that I can get a diamond, but the problem came where I have to input the diamond shape and lateral offset. He didn't explain that while he did that example problem. He explained only one input. I don't know how to explain those lines because i am still trying to figure out how to learn c++. Thankyou for your concern though.

[Vibgyor]

Here is your code pal!

#include <iostream.h>
#include <conio.h>
#include<iomanip.h>
void space()
{cout<<' ';}
void asterisk()
{cout<<'*';}
void nline()
{cout<<'\n';}
void lastasterisk(int side)
{cout<<setw(side+1)<<"*";}

void main()
{
clrscr();
float col,row; int side;
cout<<"Enter the size: "; cin>>side;
if (side%2==0)
{ cout<<"ERROR: You entered an even number.";
   nline();
   cout<<"The program is correcting your error";
   nline();
   side+=1;
}
for(col=side;col>=1;col--)
{ for(row=1;row<=col;row++)
  space();
  asterisk();
  for(row=side-1;row>=col;row-=0.5)
  space();
  if(col==side)
  nline();
  else
  {asterisk();nline();}
}
for(col=side;col>=1;col--)
{ for(row=side;row>col;row--)
  { if(row==0)
    break;
    else
    space();
  }
  asterisk();
  for(row=1.5;row<=col+0.5;row+=0.5)
  space();
  asterisk(); nline();
  if(col==1)
  lastasterisk(side);
}
nline();nline();
getch();
}

I have altered mine as you said............

[amar27]

Thank you very much buddy for your help. but this is a shallow diamond and I need to have two inputs like the code I wrote. but this just has one. thanks anyway.

[48T7M4Gy]

Please show us an example of what the correct output is. Say for width = 7 and offset = 2. Type blanks as '-' character.

[Vibgyor]

hi kemort
That isn't latest.

amar27 asked me in a PM to remodify the program.

So sent him the update but forgot to update it here in fourm:P

#include <iostream.h>
#include <conio.h>
#include<iomanip.h>
void space()
{cout<<' ';}
void asterisk()
{cout<<'*';}
void nline()
{cout<<'\n';}
void lastasterisk(int side,int offset)
{cout<<setw(side+offset+1)<<"*";}

void main()
{
clrscr();
float col,row; int side, offset;
cout<<"Enter the size of diamond: "; cin>>side;
if (side%2==0)
{ cout<<"ERROR: You entered an even number.";
   nline();
   cout<<"The program is correcting your error";
   nline();
   side+=1;
}
cout<<"Enter it's lateral offset: "; cin>>offset;
for(col=side;col>=1;col--)
{ for(row=1;row<=col+offset;row++)
  space();
  asterisk();
  for(row=side-1;row>=col;row-=0.5)
  asterisk();
  if(col==side)
  nline();
  else
  {asterisk();nline();}
}
for(col=side;col>=1;col--)
{ for(row=side;row+offset>col;row--)
  space();
  asterisk();
  for(row=1.5;row<=col+0.5;row+=0.5)
  asterisk();
  asterisk(); nline();
  if(col==1)
  lastasterisk(side,offset);
}
nline();nline();
getch();
}

so....copy the code and run it in your IDE for the output of all kinda inputs :D

Have a nice time!

[EDIT] Please browse this one too http://www.cplusplus.com/forum/general/174405/

[48T7M4Gy]

#include <iostream>

using namespace std;

void pyramid(int, int);
void wedge(int, int);

int main()
{
    int colWidth, latOffset;

    cout << "This is a program for outputting a diamond formation.\n";
    cout << "First you must select an odd number diamond width.\n";
    cout << "Then you must select a lateral offset even or odd.\n";
    cout << " Input diamond width: ";
    cin >> colWidth;

    if (colWidth % 2 == 0)
    {
        cout << "ERROR: You entered an even number.\nThe program is correcting your error\n";
        colWidth += 1;
    }
    cout << "Input lateral offset: ";
    cin >> latOffset;
    cout << "\n";

    pyramid (colWidth, latOffset);
    wedge (colWidth, latOffset);
    
    cout << "\nAuthor: Amar" << endl;
    return 0;
}

void pyramid (int width, int offset)
{
    int count = 1;
    
    for(int i = 1; i < width; i++)
    {
        for(int j = 0; j < offset; j++)
            cout << ' ';
            
        for(int k = 0; k < width - i; k++)
            cout << ' ';
        
        for ( int w = 0; w < count; w++)
            cout << "*";      
    count +=2;
    cout << endl;
    }
}

void wedge(int width, int offset)
{
    // Similar to pyramid
}

[Vibgyor]

@kemort

I am not saying that it's incorrect but your comment, // Similar to pyramid , makes no sense. A diamond doesn't look like this

  *  
 ***
*****
  *  
 ***
*****

And if we do it's reverse then the output will be

  *  
 ***
*****
*****
 ***
  *  

It's not a diamond either.

So correct your code mister.

[48T7M4Gy]

LOL :]