Linked Lists Program

[Aideux]

So, I'm trying to write a program where the user inputs 5 integers, and then the program uses linked lists to sort the integers as they are added to the list. Unfortunately, I've seemed to have confused myself, and now the program crashes after I enter 3 integers. I really need some help figuring this out. Thank you so much.

#include <iostream>
using namespace std;

void getdata(int& ident);
const int nil = 0;
class node_type
{
public:
	int id;
	node_type *next;
};

void main(){
	node_type *first, *p, *q, *newnode;
	int i, ident = 0;
	first = new node_type;
	p = first;
	getdata(ident);
	(*first).id = ident;
	(*first).next = nil;
	for (i = 0; i <= 4; i++){
		newnode = new node_type;
		getdata(ident);
		(*newnode).id = ident;
		q = new node_type;
		getdata(ident);
		(*q).id = ident;
		(*q).next = nil;
		(*p).next = q;
		if (((*first).id) > ((*newnode).id)){
			(*newnode).next = first;
			first = newnode;
		}
		else if ((*first).next == nil){
			(*first).next = newnode;
		}
		else{
			q = first;
			p = (*q).next;
			while (((*newnode).id) > (((*p).id) && ((*p).next) != nil)){
				q = p;
				p = (*p).next;
				if (((*p).id) > ((*newnode).id)){
					(*q).next = newnode;
					(*newnode).next = p;
				}
				else{
					(*p).next = newnode;
				}
			}
		}
		p = q;
	}
	first = p;
	p = first;
	while ((*p).next != nil){
		cout << (*p).id << " ";
		p = (*p).next;
	}

	cout << endl;
}
void getdata(int& ident)
{
	cout << "Enter an integer: ";
	cin >> ident;
}

[coder777]

You have several problems:

1) You create two nodes per iteration (altogether 8)
2) Line 30: You check newnode->id, but what about q?
3) Line 34: That will never happen due to line 29.
4) Line 52: What is the content of q/p supposed to be?
5) Line 54: What is is the content of p?
6) You should use more descriptive names.