StaQue round robin array

[usama shahid]

#include <iostream>
using namespace std;
template <class T>
class StaQue
{
public:
	//constructor
	StaQue(  int size = 1000)
	{
		MAX_SIZE = size;
		front = -1;
		rear = -1;
		data = new T[MAX_SIZE];
		size = 0;
	}
	//destructor
	~StaQue()
	{
		delete[]data;
	}

	
	void Insert(const T &x)
	{
		if (IsFull())
		{
			cout << "queue is full  " << endl;
			return;
		}
		if (IsEmpty())
		{
			front = rear = 0;
			size++;
		}
		else
		{
			
			rear = (rear+1) % MAX_SIZE;
			size++;
		}
		data[rear]= x;
	}
	int Size()
	{
		return size;
	}
	T RemoveLast()
	{
		if (IsEmpty())
		{
			cout << "staque is empty : " << endl;
		}
		else if (front == rear)
		{
			rear = front = -1;
			size--;
		}
		else
		{
			T val = data[rear];
			rear = (rear - 1) % MAX_SIZE;
			return val;
			size--;
		}

	}
	T Last()
	{
		if (IsEmpty())
		{
			cout << "queue is empty : " << endl;
		}
		else
		{
			T val = data[rear];
			return val;
		}

	}
	T First()
	{
		if (IsEmpty())
		{
			cout << "queue is empty : " << endl;
		}
		else
		{
			T val = data[front];
			return val;
		}

	}
	T RemoveFirst()
	{
		if (IsEmpty())
		{
			cout << "queue is empty : " << endl;
		}
		else if (front == rear)
		{
			rear = front = -1;
			size--;
		}
		else
		{
			T val = data[front];
			front = (front + 1) % MAX_SIZE;
			return val;
			size--;
		}
	}
		
	void clear()
	{
		delete[]data;
		front = -1;
		rear = -1;
		data = new <T>[MAX_SIZE];
	}
	bool IsEmpty(void)
	{
		if (front == -1 && rear == -1)
		{
			return true;
		}
		else
		{
			return false;
		}
	}

	
	bool IsFull(void)
	{
		if ((rear + 1) % MAX_SIZE == front)
		{
			return true;
		}
		else
		{
			return false;
		}
	}
	
					   //outputs the data in queue. If the list is empty, outputs “Empty Queue”.
	

private:
	T *data; //array of data items
	int front; //front index
	int rear; //rear index
	int MAX_SIZE;//size of
	int size;
};
int main()
{
	StaQue <double> queue;
	queue.Insert(5.0);
	queue.Insert(6.5);
	
	queue.Insert(-3.0);
	queue.Insert(-8.0);
	
	queue.RemoveLast();
	
	return 0;
}

[helios]

Looks like a worse std::deque.

[usama shahid]

whats wrong whit it ???

[ne555]

bad memoy handling, missing copy constructor and assignment operator.
bad optimization, no move or especial swap
no in-place construction of the element. Elements need default constructor.

bad error handling
you've got undefined behaviour because there are paths that do not return anything
you print error messages to the standard output
the client code is not notified of any errors.

fixed size (¿feature?)
immutable elements
no random access
no const-correctness

bug: line 109 would never be reached


If you wanted a review you should have said so from the start

[usama shahid]

thanks
i will work on it