linked lists c++, pass in and pass out

[chee]

the code works, but im having a little trouble with the output.

#include <iostream.h>
#include <fstream.h>
#include <stdio.h>
#include <stdlib.h>
#include <conio.h>
#include <string.h>


typedef
struct node{
int data1;
node *p;
} nodetype;

void deleteAll(nodetype *start){
nodetype *t1 = start;
nodetype *t2 = start;
int size = 0;

for(int i=0; i<size; i++){
t2=t2->p;
delete t1;
t1=t2;
}

start=NULL;
}

void startlist(nodetype **start){
nodetype *firstone = new nodetype;
nodetype *temp;
(*start)=firstone;
for(int i=0; i<10; i++){
temp=new nodetype;
temp->data1=random(1000);
if(firstone == NULL){
firstone=temp;
firstone=temp;
} // if
else{
firstone->p=temp;
firstone=temp;
} // else
} //for
temp->p = NULL;
} // startlist



void addNode(nodetype *start, int pos, int value){
nodetype *n=new nodetype;
n->data1=value;
nodetype *temp=start;

if(pos==1){ n->p=start;
start=n; } // if

else{
for(int i=0; i<pos-2; i++) temp=temp->p;
n->p = temp->p; temp->p=n;
} // else

} // addnode

void deleteNode(nodetype *start, int pos){
nodetype *temp=start;
nodetype *d = new nodetype;
if(pos==1){
start=start->p;
delete temp;
} //if
else{
for(int i=0; i<pos-1; i++){
d = temp;
temp = temp->p;
} //for
d->p=temp->p;
} //else

} // deletenode

void changeNode(nodetype *start, int pos, int value){
nodetype *temp=start;
for(int i=0; i<pos-1; i++){
temp=temp->p;
}
start->data1=value;

}


void printall(nodetype *start){
nodetype *temp;
temp=start;

if(start==NULL){
cout << "\n\n\tError";
} // if
else{
while(temp!=NULL){
cout << " " << temp->data1;
temp=temp->p;
} // while
} // else

} // printall

int listsize(nodetype *start){
nodetype *temp = start;
int size=0;
for(;;){
if(temp==NULL) break;
temp=temp->p;
size++;
}
cout << "\n\n\tList size = " << size;

return size;
}

int main(){
clrscr();
int pos, value;
char c1;
nodetype *list=NULL;
cout << "\n\n\tstartlist() ";
startlist(&list);
printall(list);
getch();
cout << "\n\n\t Insert Node (Y/N)? ";
c1=getche();
if((c1=='Y')||(c1=='y')){
cout << "\n\tNode# = ";
cin >> pos;
cout << "\n\tValue = ";
cin >> value;
addNode(list, pos,value);
}
cout << "\n\n\t";
printall(list);
listsize(list);
cout << "\n\n\t Change Value (Y/N)? ";
c1=getche();
if((c1=='Y')||(c1=='y')){
cout << "\n\tNode# = ";
cin >> pos;
cout << "\n\tValue = ";
cin >> value;
changeNode(list,pos,value);
}
cout << "\n\n\t";
printall(list);
listsize(list);
cout << "\n\n\t Delete Node (Y/N/ALL)? ";
c1=getche();
if((c1=='Y')||(c1=='y')){
cout << "\n\tNode# = ";
cin >> pos;
deleteNode(list,pos);
}
else{
((c1=='A')||(c1=='a'));
cout << "\n\n\tDeleting Nodes";
deleteAll(list);
}
printall(list);
listsize(list);


cout << "\n\n\tComplete";

return 0;
} //MAIN 

for deleteall i want it to just delete all of the nodes then printout zero, but it just printsout the full numbers. any idea how to fix that, then also there is the problem that i get a memory printout when i printout the random numbers. any help is appreciated

here is the output

        startlist()   4318456  549  604  986  944  712  283  556  734  286  861

         Insert Node (Y/N)? y
        Node# =
3

        Value = 333


          4318456  549  333  604  986  944  712  283  556  734  286  861

        List size = 12

         Change Value (Y/N)? y
        Node# = 2

        Value = 222


          222  549  333  604  986  944  712  283  556  734  286  861

        List size = 12

         Delete Node (Y/N/ALL)? a

        Deleting Nodes  222  549  333  604  986  944  712  283  556  734  286  8
61

        List size = 12

        Complete

as you can see, i just want all the nodes to delete and the list size to equal zero. above that i have the memory being pritned out.

[coder777]

hello chee,

that format isn't easy to read. Does your code always look like that?

You want to manipulate 'start' directly so you have to write instead of void deleteNode(nodetype *start, int pos) -> void deleteNode(nodetype **start, int pos) Note that second '*' (like in 'startlist')

What's this line all about nodetype *d = new nodetype;? new in delete?

So that you use always 'pos' it doesn't look like you want a single linked list? Using vector might probably be easier for your purpose