please help on urgent basis

[Thanz]

Please check the following program why it's giving the 2nd largest value wrong.If I enter 5 values 140,125,150,170 n 160 respectively it shows the largest value :170
the smallest value:125
the 2nd Largest value: 140

2nd largest value shud be 160.


#include <iostream.h>


int main (){
int NumofVariables;
cout<<"Enter number of varible to check: ";
cin>>NumofVariables;
int counter=0;
int userinput=0;
int largest = 0;
int smallest=0;
int secondLargest=0;

do{
cout <<"Enter value for variable:\n";
cin >>userinput;
if(counter==0){
smallest=userinput;
largest=userinput;
secondLargest=userinput;

}
++counter;


if(largest<userinput){
largest=userinput;
}


if (smallest>userinput){
smallest= userinput;
}
if (userinput<largest && userinput>secondLargest ){
secondLargest= userinput;
}

//counter = counter+1;
}
while(counter<NumofVariables);

cout<< "Largest values is :";
cout<<largest;
cout<< "\n smallest values is :";
cout<<smallest;
cout<< "\n 2nd largest values is :";

cout<<secondLargest;

int pause;

cin>>pause;
}

[D80DSL3A]

That's odd. Your code worked fine for me. Output:

Enter number of varible to check: 5
Enter value for variable:
140
Enter value for variable:
125
Enter value for variable:
150
Enter value for variable:
170
Enter value for variable:
160
Largest values is :170
 smallest values is :125
 2nd largest values is :160

I think that your method will fail though if the largest value is entered after the 2nd largest value. ie. The results will depend on the order in which values are entered.

[Thanz]

But it result sould not depend on the order as every time loop runs n check the both conditions.

if (userinput<largest && userinput>secondLargest ){
secondLargest= userinput;

In my point of it's dealing all the conditions so y still result will depend on the order of the values entered..???

[kalgorithmist]

Update this code segment:

if(largest<userinput){
largest=userinput;
}

to this:

if(largest<userinput){
secondLargest = largest;
largest=userinput;
}

[Thanz]

Problem is still same. :(

[whitenite1]

@Thanz

I used kalgorithmist's idea, but deleted

if (userinput<largest && userinput>secondLargest ){
secondLargest= userinput;
}

check, and everything worked beautifully, since secondLargest is already being adjusted.

[D80DSL3A]

I found that both code fragments are needed. kalgorithmist code handles the case where the largest value is entered after the 2nd largest, Your original code (given by whitenite1) handles the other case.
Are you sure that you're running the newer code? It should be working.

[whitenite1]

@fun2code
I checked the program with your suggestion, and found, yes indeed, it worked flawlessly. Here is the program, with corrections:

// High-lowest.cpp : Defines the entry point for the console application.
//

#include "stdafx.h"
#include <iostream>

using namespace std;

int main (){
	int NumofVariables;
	cout<<"Enter number of varible to check: ";
	cin>>NumofVariables;
	int counter=0;
	int userinput=0;
	int largest = 0;
	int smallest=0;
	int secondLargest=0;

	do{
		counter++;
		cout <<"Enter value for variable # " << counter << ": ";
		cin >>userinput;
		if(counter==1)
		{
			smallest=userinput;
			largest=userinput;
			secondLargest=userinput;
		}

		if(largest<userinput)
		{
			secondLargest = largest;
			largest=userinput;
		}

		if (smallest>userinput)
		{
			smallest= userinput;
		}

		if (userinput<largest && userinput>secondLargest )
		{
			secondLargest= userinput;
		}
	}
	while(counter<NumofVariables);

	cout << endl <<endl;
	cout << "The largest value is :\t" <<largest << endl;
	cout << "2nd largest value is :\t" << secondLargest << endl;
	cout << "   Smallest value is :\t" <<smallest << endl;
	cout <<endl;
	int pause;
	cin>>pause;
}

[Thanz]

whitenite1 This Program is working well now tyx.