File Display Program

[BinaryGeek]

I have a program challenge for homework that asks the user for the name of a file. The program should display the contents of the file on the screen. If the files contents wont fit on a single screen, the program should display 24 lines of output at a time, and then pause. Each time the program pauses, it should wait for the user to strike a key before the next 24 lines are displayed.

The function expects a declaration and I have a feeling something else is wrong that I can't see. Any help is greatly appreciated.

Here's what I have so far:

#include <iostream>
#include <fstream>
#include <string>
using namespace std;

void showContent(fstream &);

int main(void)
{
	string fileName;
	char line[100];
	fstream fin;
	fstream dataFile;

	cout << "Enter Filename: " << endl;
	cin >> fileName;

	fin.open(fileName, ios::in);
	dataFile.close();

	showContent(dataFile);

	while(!fin)
	{
		cout << "Error Opening File! Re-enter File Name: " << endl;
		cin >> fileName;
	}

	system("pause");
}

void showContent(fstream &file);
{
	int counter = 0;
	char getch();

	while(!fin.eof())
	{
		if (counter > 25)
		{
			getch();
			counter = 0;
		}

		fin.getline(line, 101, '\n');
		cout << line << endl;
		counter++;
	}
}

[coder777]

you cannot use a local variable (like line within main()) in another function (like showContent()). Just create a new variable within showContent()

[Moschops]

Why do you have two fstream objects? Why do you close datastream without ever having opened it?

[Imadatobanisa]

while(!fin)
{
cout << "Error Opening File! Re-enter File Name: " << endl;
cin >> fileName;
}

Then, what will you do if the comparison expression (fin == 0) is always true?
"cin >> fileName;" seems redundant because it cannot solve the problem (fin == 0).
Loop forever.........

Edit :

showContent(dataFile);

while(!fin)
{
cout << "Error Opening File! Re-enter File Name: " << endl;
cin >> fileName;
}

...is bad code logic. It should be changed to :

while(!fin)
{
cout << "Error Opening File! Re-enter File Name: " << endl;
//Reenter the file name then try again...
}

showContent(dataFile);