Mouse Cursor

[1wvX92yv]

Hello Forum People.....

The following program is not working as intended.

I want to mark 'o' at the cursor position in window.
The screen to client part doesn't seem to work.

</code>
#include <iostream>
#include<windows.h>

using namespace std;

void gotoxy(int x, int y)
{
COORD coord;
coord.X = x;
coord.Y = y;
SetConsoleCursorPosition(GetStdHandle(STD_OUTPUT_HANDLE), coord);
}

int main()
{
cout << "Hello world!" << endl;

int x,y;
while(1)
{

POINT p;
HWND hWnd;
if (GetCursorPos(&p))
{

}

if (ScreenToClient(hWnd,&p))
{

}

gotoxy(p.x,p.y);
cout<<'o';
Sleep(10);

}

return 0;
}
</code>

please help, its an integral part of a bigger program, any help would be greatly appreciated.........

[plexus]

I think you need the proper window handle first.
Try FindWindow() or FindWindowEx().

[Computergeek01]

You should have error messages inside of those if statements, otherwise it's just needless typing. Also plexus is right, you need a valid window handle. I would use "GetActiveWindow()" myself, but either one is better then what you are doing now.

- GetActiveWindow(): http://msdn.microsoft.com/en-us/library/windows/desktop/ms646292(v=vs.85).aspx

EDIT: As for those if then statements, you have to be mindful that both of those functions return zero if they fail, so you what to make them into "if(!...)" statements. If they do fail, you should also have the program tell you why by using std::cout << GetLastError() << std::endl; and look here: http://msdn.microsoft.com/en-us/library/windows/desktop/ms681381(v=vs.85).aspx to see what the error code means.

[andywestken]

(Aside: your opening code tag should not have a / )

Not sure what you want it for??

In addition to converting from screen to client coords, you have to work out the row and column using the size of the console obtained using GetConsoleScreenBufferInfo() -- see code below.

But you should prob. have a look at how to handle console events using ReadConsoleInput, etc.

Reading Input Buffer Events
http://msdn.microsoft.com/en-us/library/windows/desktop/ms685035%28v=vs.85%29.aspx

Andy

#define WIN32_LEAN_AND_MEAN
#include <windows.h>
#include <limits.h>
#include <iostream>
using namespace std;

void gotoxy(int x, int y)
{
    COORD coord;
    coord.X = (SHORT)x;
    coord.Y = (SHORT)y;
    SetConsoleCursorPosition(GetStdHandle(STD_OUTPUT_HANDLE), coord);
}

int main()
{
    // Get screen frame rate, as there's no point going any faster
    DWORD frameRate = 0;

    DEVMODEA devMode = {0};
    devMode.dmSize = sizeof(DEVMODE);
    if(EnumDisplaySettingsA(NULL, ENUM_CURRENT_SETTINGS, &devMode))
        frameRate = devMode.dmDisplayFrequency;
    else
        frameRate = 60; // default value if fail to get actual value

    // get our window
    HWND hWnd = GetConsoleWindow();

    // to remember where we were last time
    POINT posLast = {LONG_MIN, LONG_MIN};

    while(1)
    {
        // get current mouse position in screen coords
        POINT pos = {0, 0};
        if (GetCursorPos(&pos))
        {
            // convert position to client window coords
            if (ScreenToClient(hWnd, &pos))
            {
                // get window's client rect
                RECT rcClient = {0};
                GetClientRect(hWnd, &rcClient);

                // if mouse cursor is inside rect
                if (PtInRect(&rcClient, pos))
                {
                    // and if we've moved since last time
                    if ((posLast.x != pos.x) || (posLast.y != pos.y))
                    {
                        // get size and position of console window/buffer in rows and columns
                        CONSOLE_SCREEN_BUFFER_INFO info = {0};
                        GetConsoleScreenBufferInfo(GetStdHandle(STD_OUTPUT_HANDLE), &info);
                        const SMALL_RECT& smRect = info.srWindow;

                        // calculate row and column corresponding to mouse position
                        // (note this takes accounts of console buffer scrolling)
                        int x = smRect.Left + (pos.x * (smRect.Right  - smRect.Left))
                                / (rcClient.right  - rcClient.left);
                        int y = smRect.Top  + (pos.y * (smRect.Bottom - smRect.Top ))
                                / (rcClient.bottom - rcClient.top );

                        // move to new position and output 'o'
                        gotoxy(x, y);
                        cout << 'o';

                        // update title bar
                        char title[64] = "";
                        wsprintfA(title, "Mouse Test - (%d, %d)", x, y);
                        SetConsoleTitleA(title);

                        // and last position
                        posLast = pos;
                    }
                }
                else
                {
                    // update title bar (for testing purposes) to know we don't care
                    // where the mouse is at the moment
                    SetConsoleTitleA("Mouse Test - (out of window)");
                }

                // wait a short while
                Sleep(1000 / frameRate);
            }
        }
    }

    return 0;
}

[S G H]

Don't use GetCursorPos.
Mouse coordinates aren't console coordinates.
Use console events instead (Read/PeekConsoleInput)