I dont get the right output. Please help me to fix it.

[Ltp]

Whats wrong in the code?

#include <iostream>
using namespace std;
class stack{
private:
	int *st;
	int s;
	int top;
public:
	stack(int);
	//void set_values();
	//void get_values();
	void push(int);
	void pop(int &);
};

stack::stack(int x)
{
	s=x;
	top=0;
	st=new int[s];
}
/*
void stack::set_values()
{
	for(int i=0; i<s; ++i)
		st[i]=rand()%10;
}
void stack::get_values()
{
	for(int i=0; i<s; ++i)
		//cout<<st[i]<<endl
			;
}
*/
void stack::push(int x)
{
	if(top==s)
             cout<<"Stack full.\n";
	else{
		st[++top]=x;
		cout<<st[top]<<endl;
	}
}

void stack::pop(int &x)
{
	if(top==0)
        cout<"Stack empty.\n";

	else
		cout<<st[--top]<<endl;
}

int main()
{
	stack sc(10);
	
	//sc.set_values();
	//sc.get_values();
	
	for(int i=0; i<10; ++i){
		sc.push(rand()%10);
	}
	
	cout<<endl;
	for(int j=0; j<10; ++j){
		sc.pop(j);
	}
	
	system ("Pause");
	return 0;
}

[MrHutch]

Question is vague.

What's the wrong output. What are you getting/expecting?

[coder777]

Whats wrong in the code?

Quit asking this. Describe the problem: What should happen and what happens that makes you think that is wrong

On line 41 you cout the value after top is increased:
cout<<st[top - 1]<<endl;

something else?

[Ltp]

Ok coder. Plz run the code and see the output.

[Ltp]

ihutch, i'm expecting the poped values in order to pushed values.

[MikeyBoy]

Ok coder. Plz run the code and see the output.

We're not going to jump through hoops for you. If you want people to give their time and effort freely to help you, then the onus is on you to do everything you can to make this as easy as possible. That means clearly explaining what the problematic behaviour is, and what your expected behaviour is.

[coder777]

line 40 and 41 are wrong. Write it like so:

		st[top]=x;
		cout<<st[top]<<endl;
		++top;

[Ltp]

I understood what you said, coder. Anyway, thanks again for support.