Can someone tell me how to fix my code?

[misslyss]

I am supposed to write a program that will read 25 positive numbers from the user and stores them in an array. The user can stop entering numbers by entering -1. The program must search print only the unique numbers the user has entered. It should also print out the total number of numbers entered along with the number of unique numbers entered. Any help you can give would be greatly appreciated! I'm very confused. It would be very helpful if you could point out exactly what I'm doing wrong. The program builds but the output doesn't look right. Thanks!

  #include <iostream>
using namespace std;

int main(){
	const int MAX = 25;
	int input[MAX];
	int count = 0;

	do{
		cout << "Enter a number (-1 to stop): ";
		cin >> input[MAX];
		if (input[MAX] != -1 && input[MAX] >= 0){
			input[count++] = input[MAX];
		}
		if (input[MAX] < -1){
			cout << "Invalid input. This will not be included in your values." << endl;
		}
	} while (input[MAX] != -1 && count < MAX);

	for (int i = 0; i < count; i++){
		cout << input[i] << ', ';
	}
	cout << endl;

	int unique[25];
	int count2 = 1;
	int duplicate = 0;

	unique[0] = input[0];

	for (int i = 0; i<count; i++){
		duplicate = 0;

		for (int j = 0; j<count2; j++){

			if (input[i] == unique[j]){
				duplicate = 1;
			}
		}
		if (duplicate == 1){
			continue;
		}
		unique[count2] = input[i];
		count2++;
	}

	for (int i = 0; i < count2; i++){
		cout << "The unique numbers you entered were: " << unique[i] << ' ';
	}


	cout << "You entered " << count << " numbers, " << count2 << " unique." << endl;
	cout << "Have a nice day!" << endl;

	system("pause");
	return 0;
}

[Ganado]

First thing I notice is that you have an array called input that holds 25 values, but then you try to write to input[25].

input[25] is out of bounds of the array, and writing to that location will result in undefined behavior (which is bad).
arrays start at index 0, so if 25 is the size of the array, indices go from [0] to [24].

[misslyss]

Thanks for answering. :) I changed that. But my results still aren't coming out right. I have no idea what else is wrong. Do you see anything else?

[ne555]

> But my results still aren't coming out right.
Provide an example input.
The output that you should get with that.
The output that you are getting.


Also, show updated code.

[dhayden]

Line 21: single quotes enclose individual characters. Double quotes enclose multi-character strings. You want a string here so it should be ", ".

Line 48: Your code will print "The unique numbers you entered were: " for each unique number. You want to print this outside the loop. The loop should only print the numbers and the string to separate them.

[misslyss]

Thanks. The problem I'm having is that the code can't figure out which numbers are unique...it lists them all. For example when I enter 3, 4, 5, 5, 6, 7, 8, 8 it should tell me 4 are unique and they are 3, 4, 6, 7

[dhayden]

Hmm. Post your current code. I was able to get it working and I think the only changes I made were the ones I described.