File Will Not Open! Help ASAP

[marqual123]

I Need Help Getting This File To Open! Please!. This project is due tonight and I cant get the file to open. I Think its a simple mistake. but I cant find it Please Help!

 #include <iostream>
#include <cctype>
#include<stdio.h>
#include<iterator>
#include<fstream>
#include <sstream>

using namespace std;


bool NUM;
int main() 
{

 
  char ch[80]; 
  int i, numbers = 0, other = 0, character = 0, letters = 0, spaces = 0, punct = 0, digits = 0, special = 0, upper = 0, lower = 0;

	ifstream myfile ("C:/Users/marqu_000/Documents/matter.txt");
	
	if(myfile.is_open())
    //getline(myfile);
	while (myfile)
	{
	

  cout << "\nEnter The String:\n " << endl;
  gets (ch);
  bool NUM = false ; //initialises to false
  for (i =0; ch[i] !='\0';i++) 
  {
	
	 
  	if (ch[i] != ' ')
character++;

    if(isalpha(ch[i])) 
       ++letters;
    else if(isspace(ch[i])) 
       ++spaces;
    //else if(ispunct(ch[i])) 
      // ++punct;
    if (ch[i] ==',')
    ++punct;
    else if (ch[i] ==';')
    ++punct;
    else if (ch[i] =='.')
    ++punct;
    else if (ch[i] ==':')
    ++punct;
    else if (ch[i] =='!')
    ++punct;
    else if (ch[i] =='?')
    ++punct;
    else if (ch[i] =='"')
    ++punct;
    else if (ch[i] =='/')
    ++punct;
    else if (ch[i] =='-')
    ++punct;
    else if (ch[i] =='+')
    ++punct;
    else if (ispunct(ch[i]))
    ++special;
    
    else if(isdigit(ch[i])) 
       ++digits;
    ++ch[i];
    
    if (ch[i] >= 'A' && ch[i] <= 'Z')
upper++;
	 if (ch[i] >= 'a' && ch[i] <= 'z')
lower++;

 if (isdigit(ch[i]) == true)
	 NUM++;	
	 if (ch[i] == ' ')
	 ++other;



  }
  cout << "Number of characters: " << character << endl;
  cout << "Number of letters: " << letters << endl;
  cout << "Number of lower cases : " << lower << endl;
  cout << "Number of upper cases : " << upper << endl;
  cout << "Number of digits: " << digits << endl;
  cout << "Number of punctuation characters: " << punct << endl;
  cout << "Number of special characters: " << special <<endl;
  cout << "Number of spaces: " << spaces << endl;
  cout << "Number of words: " << spaces + 1 << endl;
  cout << "Number of numbers " << NUM;
  cout << "\nNumber of others " << other;
 
myfile.close();
}
else
{
	cout << " Unable to open output file. " << endl;
	return 1;
}
  return 0;
}

[jonnin]

I forget... should you be using c:\\folder\\folder2\\filename.txt format? windows uses \ unix uses /

[marqual123]

It gives me the same results "Unable to open file".

[Chervil]

Maybe you don't have access to that path, or the filename is incorrect? You could try to approach it from another angle. This code attempts to first create a file, then read it back in.

#include <iostream>
#include <fstream>

using namespace std;

int main() 
{
    const char * filename = "C:/Users/marqu_000/Documents/test123xyz.txt";
    
    ofstream outfile(filename);
    
    if (!outfile)
    {
        cout << " Unable to open output file. " << endl;
        return 1;
    }
    
    cout << "Output File is open\n";
    
    outfile << "This is a test 123\nApples and pears\n";
    
    outfile.close();
    
    //----------------------------------------------------
    
    ifstream infile (filename);
    
    if (!infile)
    {
        cout << " Unable to open input file. " << endl;
        return 2;
    }
    
    cout << "Input File is open\n";
    
    char line[100];
    while (infile.getline(line, sizeof(line)))
    {
        cout << line << '\n';
    }
    
    cout << "\nDone\n";
    
}

If I run it as it stands, it gives me the error message,

Unable to open output file. 

However, when I change the username "marqu_000" (or entire path) to something which matches my system, then I get this output:

Output File is open
Input File is open
This is a test 123
Apples and pears

Done

[marqual123]

That's weird! I always just use the path to location on my windows computer @Chervil .

[Chervil]

Sorry, I don't understand. Does that mean it worked or failed?

[marqual123]

I tried both ways. Not a completed project yet! *my heads hurting lol *. Been working on this for like 3 days !!! I got the out file to output but its something with the input file! I'm getting errors.

[marqual123]

ITs crazy i have 3 different read string techniques and non of them are making my program valid

[Chervil]

I got the out file to output

That's good! It means:
1. you have the correct pathname
2. you have both read and write access to that directory.
So far so good.

but its something with the input file! I'm getting errors.

Well - the original code in the opening post attempts to open an input file. But the rest of the code is a bit of a muddle. It never actually reads anything from the file.

Do a search for "myfile" to see where it is used, no reading of any kind.