Error: Expression does not have class type

[etaaaaaaa]

In the row 67 there is an error: 'p.MESWERT::getEinheit' does not have class type. What am I doing wrong?

 #include <cassert>
#include <iostream>
#include <vector>
#include <string>

using namespace std;

class MESSWERT
{
private:
    double wert;
    string einheit;
public:
    MESSWERT (double w=0, string e = ""); //konstruktor
    MESSWERT (const MESSWERT &m); //kopiekostruktor
    void setMesswert (double w, string e); //setter
    double getWert(); //getter
    string getEinheit(); //getter?
    void print();
};

//kostruktor initialisation
MESSWERT::MESSWERT (double w, string e)
{
    this->wert =w;
    this->einheit = e;
}

//kopiekonstructor initialisation
MESSWERT::MESSWERT (const MESSWERT &m)
{
    this->wert = m.wert;
    this->einheit = m.einheit;
}

//getter
string MESSWERT::getEinheit()
{
    return this->einheit;
}

//setter
void MESSWERT::setMesswert(double w, string e)
{
    this->einheit = e;
}

void MESSWERT::print()
{
    cout << this->wert << " = " << this->einheit << endl;
}

int main()
{
    MESSWERT mo1(20, "uA");
    MESSWERT mo2(10, "kV");
}

//Methode ohne Parameter zu Normierung
int normieren(MESSWERT &p)
{
   // string str_temp = p.getEinheit();
	if (p.getEinheit() == "A" || p.getEinheit() == "V" || p.getEinheit() == "W")
	{
		return 0;
	}
	if (p.getEinheit.length() != 2 || p.getEinheit[1] != 'A' && p.getEinheit[1] != 'V' && p.getEinheit[1] != 'W')
	{
		return 42;
	}
	switch (p.getEinheit[0])
	{
	case 'n':
		p.getWert() *= 0.000000001;
		break;
	case 'u':
		p.getWert() *= 0.000001;
		break;
	case 'm':
		p.getWert() *= 0.001;
		break;
	case 'k':
		p.getWert() *= 1000.;
		break;
	case 'M':
		p.getWert() *= 1000000;
		break;
	default:
		return 42;
	}
	p.getEinheit = p.getEinheit.substr(1);
	return 0;
}

[Ganado]

getEinheit is a function, it needs to be called with parentheses, like you do on line 63.

[etaaaaaaa]

Okay, it worked, thanks a lot! There is another problem now, in hte line 74 there is an error "no matching function for call to 'MESSWERT::setMesswert()'. Do you have any idea why? Here is the code, it's a bit different now!

#include <cassert>
#include <iostream>
#include <vector>
#include <string>

using namespace std;

class MESSWERT
{
private:
    double wert;
    string einheit;
public:
    MESSWERT (double w=0, string e = ""); //konstruktor
    MESSWERT (const MESSWERT &m); //kopiekostruktor
    void setMesswert (double w, string e); //setter
    double getWert(); //getter
    string getEinheit(); //getter?
    void print();
};

//kostruktor initialisation
MESSWERT::MESSWERT (double w, string e)
{
    this->wert =w;
    this->einheit = e;
}

//kopiekonstructor initialisation
MESSWERT::MESSWERT (const MESSWERT &m)
{
    this->wert = m.wert;
    this->einheit = m.einheit;
}

//getter
string MESSWERT::getEinheit()
{
    return this->einheit;
}

//setter
void MESSWERT::setMesswert(double w, string e)
{
    this->einheit = e;
}

void MESSWERT::print()
{
    cout << this->wert << " = " << this->einheit << endl;
}

int main()
{
    MESSWERT mo1(20, "uA");
    MESSWERT mo2(10, "kV");
}

//Methode ohne Parameter zu Normierung
int normieren(MESSWERT &p)
{

	if (p.getEinheit() == "A" || p.getEinheit() == "V" || p.getEinheit() == "W")
	{
		return 0;
	}
	if (p.getEinheit().length() != 2 || p.getEinheit()[1] != 'A' && p.getEinheit()[1] != 'V' && p.getEinheit()[1] != 'W')
	{
		return 42;
	}
	switch (p.getEinheit()[0])
	{
	case 'n':
		p.setMesswert=(p.setMesswert() * 0.000000001);
		break;
	case 'u':
		p.setMesswert(p.setMesswert() * 0.000001);
		break;
	case 'm':
		p.setMesswert(p.setMesswert() * 0.001);
		break;
	case 'k':
		p.setMesswert(p.setMesswert() * 1000);
		break;
	case 'M':
		p.setMesswert(p.setMesswert() * 1000000);
		break;
	default:
		return 42;
	}
	p.getEinheit() = p.getEinheit().substr(1);
	return 0;
}

[Ganado]

Just another typo. Look closely. What makes line 74 different than line 77, or 80, besides the constant factor?

Remove the equals sign.

[etaaaaaaa]

Yeah, you're right, but it doesnt work anyway, I get errors in the lines 74, 77, 80, 83 and 86, saying 'no matching function for call to 'MESSWERT::setMesswert (double)'

switch (p.getEinheit()[0])
	{
	case 'n':
		p.setMesswert(p.getWert() * 0.000000001);
		break;
	case 'u':
		p.setMesswert(p.getWert() * 0.000001);
		break;
	case 'm':
		p.setMesswert(p.getWert() * 0.001);
		break;
	case 'k':
		p.setMesswert(p.getWert() * 1000);
		break;
	case 'M':
		p.setMesswert(p.getWert() * 1000000);
		break;
	default:

[jonnin]

saying 'no matching function for call to 'MESSWERT::setMesswert (double)'

void MESSWERT::setMesswert(double w, string e)

the compiler is correct. it takes (double, string). ^^^ and, in fact, it uses the string but not the double.

[etaaaaaaa]

Okay, thanks jonnin my man, how do I correct that?

[etaaaaaaa]

Nevermind, it's solved

switch (p.getEinheit()[0])
	{
	case 'n':
		p.setMesswert(p.getWert() * 0.000000001, "");
		break;
	case 'u':
		p.setMesswert(p.getWert() * 0.000001, "");
		break;
	case 'm':
		p.setMesswert(p.getWert() * 0.001, "");
		break;
	case 'k':
		p.setMesswert(p.getWert() * 1000, "");
		break;
	case 'M':
		p.setMesswert(p.getWert() * 1000000, "");
		break;
	default:
		return 42;

[Ganado]

It might compile, but it still doesn't make sense. Are you just copying this from somewhere, without understanding what it's supposed to be doing?

Your function is called setMesswert, yet you set einheit, not wert.