lower to upper

[lovelyhakeem]

i wanna to make a prog which convert small case letters entered by user to upper case letters....i TRIED to use toupper function ...but it only do action with a single character...is there any function which convert all characters like "lovely hakeem" to "LOVELY HAKEEM"
(NOT BY LOOP)

plz help

[Return 0]

There is no way to convert all characters to upper or lower case without looping through the string.

[lovelyhakeem]

actually some one told me that it is possible.....for that reason

[filipe]

You could use std::for_each():

std::string str = "lower";
std::for_each(str.begin(), str.end(), std::toupper);

Technically, though, std::for_each() is still looping through the string.

[Return 0]

Using a string you can use std::transform.

http://www.cplusplus.com/reference/algorithm/transform/

[lovelyhakeem]

ok i will tryyy.tnxxxx

[lovelyhakeem]

it mean that there is no keyword for it????

[filipe]

That's not keyword material. If you want a simple function that will do the job, just write one:

void toUpper(std::string& s)
{
    std::for_each(s.begin(), s.end(), std::toupper);
}

[lovelyhakeem]

ahann....thats well

[Duthomhas]

Important read:
http://www.cplusplus.com/forum/beginner/14081/#msg68655

[edit] FORGET THE REST OF THE CRUFT IN THIS THREAD



People here are just messing around now. Use the method I give in the link if you want to convert a string to upper case. (Presuming locale-sensitive applications aside.)

filipe's std::for_each() throws away the result (and s remains unchanged)

joeneldeasis's strupr() is non-standard, and not C++

rocketboy9000 and PiMaster's loopy code is, well, not (NOT BY LOOP). (Also, it doesn't work right for things like 'á', where std::toupper() should... presuming your locale is properly set. (BTW, you don't need to test whether or not it is already upper before conversion. The function returns the argument character if no change is necessary.)

ne555 knows what he is doing, but a regular expression is totally overkill here -- in any case sed != C++, and he is just messing with you.



The link I gave you gives you working, standard code that will do the job, jumping all the right hoops to work on all modern C++ compilers. Don't let people side-track you.
[/edit]

[joeneldeasis]

you know to best way is? in C.

#include<stdio.h>
main()
{
char *upr;
clrscr();
printf("Enter the word to convert in uppercase: ");
scanf("%s", upr);
strupr(upr);  /*strupr(); converts it in uppercase and strlwr(); converts it in lower case*/
printf("%s",upr);
getch();
}

by joenel :D.. i hope you understand this thing :D

[firedraco]

^
Typeless main?
clrscr()?
scanf without bounds checking on an uninitialized pointer??

Don't even bother with that code...

[joeneldeasis]

huh?
are you a master programmer?
create your own
don't get into this topic
try that code it's working.
duh? :P

[rocketboy9000]

No, it doesn't. You need to include conio.h to make it work, which on many systems either doesn't exist or is different. And yes, many of us consider ourselves to be pretty darn good at programming, which is why we help people with their problems. You are not helping. Here is the proper way to solve this problem:

for(int i=0;i<s.length;i++)
	if(s[i]>='a'&&s[i]<='a')
		s[i]+='A'-'a';

or if you want to use toupper:

for(int i=0;i<s.length;i++)
	if(isupper(s[i]))
		s[i]=toupper(s[i]);

[ne555]

@rocketboy9000:
_ First code only changes 'a' to 'A'
_ Second code does nothing

Regex: "y/a-z/A-Z/" (from the rename.pl manual)

[PiMaster]

My turn! :D

unsigned strlen(const char* str){
	unsigned x=0;
	for(;str[x]!=0;++x){}
	return x;}

unsigned upper(string& str){
	unsigned size=str.length(),x=0;
	for(;x<size;++x){
		if(str[x]>='a' && str[x]<='z'){
			str[x]+='A'-'a';}}
	return x;}

unsigned upper(char* str){
	unsigned size=strlen(str),x=0;
	for(;x<size;++x){
		if(str[x]>='a' && str[x]<='z'){
			str[x]-='a'-'A';}}
	return x;}

unsigned lower(string& str){
	unsigned size=str.length(),x=0;
	for(;x<size;++x){
		if(str[x]>='A' && str[x]<='Z'){
			str[x]+='a'-'A';}}
	return x;}

unsigned lower(char* str){
	unsigned size=strlen(str),x=0;
	for(;x<size;++x){
		if(str[x]>='A' && str[x]<='Z'){
			str[x]+='a'-'A';}}
	return x;}

[joeneldeasis]

what's wrong with my code? it's easy to understand because the value of upr will be automatically converted to upper case.
i've try this in turbo c 2.01 and but it works fine in c. try it

[rocketboy9000]

Oh ****! Serves me right for posting code without testing it.

for(int i=0;i<s.length;i++)
	if(s[i]>='a'&&s[i]<='A')
		s[i]+='A'-'a';

for(int i=0;i<s.length;i++)
	if(islower(s[i]))
		s[i]=toupper(s[i]);

These definitely work I have tested them.
Joe, I have tried to compile it, it will only ever work on your horrible computer:

oren-laptop% gcc fail.c
/tmp/ccaxfMBx.o: In function `main':
fail.c:(.text+0xa): undefined reference to `clrscr'
fail.c:(.text+0x38): undefined reference to `strupr'
fail.c:(.text+0x52): undefined reference to `getch'
collect2: ld returned 1 exit status

[ne555]

void toupper( char *beg, char *end){
	int dist = end-beg;
	if( dist == 1)
		*beg = toupper( *beg );
	else{
		toupper(beg, beg+dist/2); // execute in parallel
		toupper(beg+dist/2, end);
	}
}

@joeneldeasis: http://www.cplusplus.com/forum/general/33439/#msg179871

[Duthomhas]

http://www.cplusplus.com/forum/general/33439/#msg179845