Segmentation fault (core dumped)

[sea711]

Help - Segmentation fault (core dumped). I am going to try to comment out line by line to fix. I wish they gave you a line number. Anybody see anything obvious?

 18 float calc_rect_area(float, float);
 19 
 20 int main ()
 21 {
 22    float check, low, high;
 23    float width, height;
 24    string message;
 25 
 26    get_float(message);
 27    check_valid_input(check, low, high);
 28    calc_rect_area(width, height);
 29 
 30    const float MIN_VALUE = 1;
 31    const float MAX_VALUE = 10;
 32 
 33    float my_input = get_float("Enter a number from 1 to 10 ");
 34    float sample_width = get_float("Enter the width for some imaginary rectangle");
 35    float sample_height = get_float("Enter the height for some imaginary rectangle");
 36 
 37    cout << my_input << endl;
 38 
 39    cout << check_valid_input(my_input, MIN_VALUE, MAX_VALUE) << endl;
 40 
 41    cout << calc_rect_area(sample_width, sample_height) << endl;
 42 
 43    return 0;
 44 }
 45 
 46 float get_float(string message)
 47 {
 48    float check = atof(message.c_str());
 49    return check;
 50 }
 51 
 52 float check_valid_input(float check, float low, float high)
 53 {
 54    float neg = -1.0;
 55 
 56    if(check >= low && check <= high)
 57    {
 58       return check;
 59    }
 60    else
 61    {
 62       return neg;
 63    }
 64 }
 65 
 66 float calc_rect_area(float width, float height)
 67 {
 68    if (height == 0)
 69       return 0;
 70    else
 71       return width + calc_rect_area(width, --height);
 72 }

[Manga]

well, the lines in your code seem to be numbered... in the code!

[sea711]

I mean the segmentation fault error, why not give me a line where the error is?

[xismn]

Why are you calling check_valid_input() and calc_rect_area() on lines 10 and 11, when their arguments have not been initialized?

[ne555]

> I mean the segmentation fault error, why not give me a line where the error is?
¿never heard of a debugger?

http://www.cplusplus.com/forum/general/112111/

[sea711]

How should i initialize check_valid_input() and calc_rect_area() on lines 10 and 11?

[Chervil]

Why do you even need lines 9, 10 11(or 26, 27, 28)? Shouldn't those lines simply be removed?

[sea711]

core no longer dumped. new problems, new post

[Chervil]

Well, there's no place where the questions could be asked. For example the text "Enter a number from 1 to 10 " is passed to the function get_float() which in turn passes it to the function atof() which attempts to parse the string in the hope that it starts with a valid floating-point number. Since it doesn't, the returned value will be zero.

Because 0 is not in the range 1 to 10, the check_valid_input() function will return -1.0.

[Manga]

What everyone is saying is that you have declared variables but not given any value to them. Then, without value, you try to work with them. You must initialize your variables first. That means give them some starting value.